fix(action): create localized template for aria-label #9071

Esri · Sep 19, 2024 · 2afd383 · 2afd383
1 parent 4160af1
commit 2afd383
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/packages/calcite-components/src/components/action/action.tsx b/packages/calcite-components/src/components/action/action.tsx
@@ -298,10 +298,7 @@ export class Action
       buttonId,
       messages,
     } = this;
-    const labelFallback = label || text;
-    const ariaLabel = labelFallback
-      ? `${labelFallback}${indicator ? ` (${messages.indicator})` : ""}`
-      : "";
+    const ariaLabel = messages.indicatorLabel?.replace("{label}", label || text) ?? "";
 
     const buttonClasses = {
       [CSS.button]: true,

diff --git a/packages/calcite-components/src/components/action/assets/action/t9n/messages.json b/packages/calcite-components/src/components/action/assets/action/t9n/messages.json
@@ -1,4 +1,5 @@
 {
   "loading": "Loading",
-  "indicator": "Indicator present"
+  "indicator": "Indicator present",
+  "indicatorLabel": "{text} (Indicator present)"
 }
diff --git a/packages/calcite-components/src/components/action/assets/action/t9n/messages_en.json b/packages/calcite-components/src/components/action/assets/action/t9n/messages_en.json
@@ -1,4 +1,5 @@
 {
   "loading": "Loading",
-  "indicator": "Indicator present"
+  "indicator": "Indicator present",
+  "indicatorLabel": "{text} (Indicator present)"
 }