Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action: Create localized template for aria-label #9071

Closed
2 of 6 tasks
driskull opened this issue Apr 5, 2024 · 7 comments
Closed
2 of 6 tasks

Action: Create localized template for aria-label #9071

driskull opened this issue Apr 5, 2024 · 7 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. i18n-l10n issues dealing with internationalization/localization impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-12-17 - Dec ...

Comments

@driskull
Copy link
Member

driskull commented Apr 5, 2024

Check existing issues

Actual Behavior

aria-label is using a template for its string value here

calcite-design-system/packages/calcite-components/src/components/action/action.tsx

Line 302 in 15ca10a

const ariaLabel = `${label || text}${indicator ? ` (${messages.indicator})` : ""}`;

Expected Behavior

This should use a proper localized template

Reproduction Sample

https://codepen.io/driskull/pen/NWmyeXw?editors=1000

Reproduction Steps

  1. open codepen
  2. Inspect internal element with aria-label aria-label="test (Indicator present)"

Reproduction Version

1.7.1

Relevant Info

#9051 (comment)

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A
@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 5, 2024
@driskull driskull mentioned this issue Apr 5, 2024
Merged
@github-actions github-actions bot added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive calcite-components Issues specific to the @esri/calcite-components package. labels Apr 5, 2024
@geospatialem geospatialem added a11y Issues related to Accessibility fixes or improvements. p - medium Issue is non core or affecting less that 60% of people using the library i18n-l10n issues dealing with internationalization/localization estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Apr 15, 2024
@jcfranco jcfranco added the good first issue Issues that can be worked on by contributors new to calcite-components. label Apr 15, 2024
@geospatialem geospatialem added this to the 2024-10-29 - Oct Release milestone Aug 7, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Aug 7, 2024
@driskull driskull self-assigned this Sep 19, 2024
@driskull driskull added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Sep 19, 2024
driskull added a commit that referenced this issue Sep 19, 2024
@driskull
fix(action): create localized template for aria-label #9071
2afd383
@driskull driskull mentioned this issue Sep 19, 2024
Merged
driskull added a commit that referenced this issue Sep 20, 2024
@driskull
chore(action): add new string for accessible indicator label (#10360)
06c96e9 
**Related Issue:** #9071

## Summary

- check in new string
@driskull
Copy link
Member Author

@geospatialem can we move this issue until the string is available in all locales?

@geospatialem
Copy link
Member

@geospatialem can we move this issue until the string is available in all locales?

Sure, we're currently set for October, would this fit the timeline, or do we need to push to November, @driskull?

@driskull
Copy link
Member Author

Just whenever the strings will be there.

@geospatialem
Copy link
Member

Just whenever the strings will be there.

checked in with Anvesh and we should be on target for October, but can move this out to November if the translations are delayed.

@driskull
Copy link
Member Author

Sounds good!

driskull added a commit that referenced this issue Dec 4, 2024
@driskull
fix(action): create localized template for aria-label #9071
4c2b96f
@driskull driskull mentioned this issue Dec 4, 2024
Merged
driskull added a commit that referenced this issue Dec 4, 2024
@driskull
fix(action): create localized template for aria-label (#10969)
c86baa6 
**Related Issue:** #9071

## Summary

- uses new message string for indicator label
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 4, 2024
@github-actions github-actions bot assigned DitwanP and unassigned driskull Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 6, 2024
@geospatialem
Copy link
Member

Verified in 3.0.0-next.51 with action's label, text, and fallback of an empty string when neither attr/prop is specified.

benelan pushed a commit that referenced this issue Feb 8, 2025
@driskull @benelan
fix(action): create localized template for aria-label (#10969)
cd53fd0 
**Related Issue:** #9071

## Summary

- uses new message string for indicator label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. i18n-l10n issues dealing with internationalization/localization impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

No branches or pull requests
4 participants
@jcfranco @driskull @geospatialem @DitwanP