chore(action): add new string for accessible indicator label #10360
Conversation
github-actions
bot
added
the
bug
driskull
added
the
skip visual snapshots
| : ""; | ||
| const labelFallback = label || text || ""; | ||
| const ariaLabel = indicator | ||
| ? messages.indicatorLabel?.replace("{label}", labelFallback) |
There was a problem hiding this comment.
Don't think we can start using new message string before translations are back. This will be remove aria-label for all non-english locales.
Ex:
<calcite-action icon="banana" scale="l" label="test" indicator text="test2" lang="bs"></calcite-action>
☝️ wouldn't add aria-label to button in shadowRoot.
Alternate: we can request a generate build which return english strings for all locales or wait until the translations are back before start using indicatorLabel string.
There was a problem hiding this comment.
Should we just add the string to the messages for now then and move this issue to another milestone? What would you recommend?
There was a problem hiding this comment.
Maybe we need a better process for issues with string changes to get the strings in first. Separate the issues.
There was a problem hiding this comment.
Should we just add the string to the messages for now then and move this issue to another milestone? What would you recommend?
Yup that works. Lets add separate PR & issue for message string and it as blocker for #9071
Second creating separate issue for strings.
There was a problem hiding this comment.
I'll update the PR to just check in the string. Once the string is localized we can use it.
const labelFallback = label || text || "";
const ariaLabel = indicator
? messages.indicatorLabel?.replace("{label}", labelFallback)
: labelFallback;
|
Sidebar & Unrelated to issue: @geospatialem could you please review if we need |
driskull
changed the title
driskull
added
i18n-l10n
* origin/dev: chore(action): add new string for accessible indicator label (#10360)
…estone-estimates * origin/dev: (29 commits) fix(input-time-zone): fix region mode labeling and value mapping (#10345) fix(dropdown): open dropdown on `ArrowDown` & `ArrowUp` keys (#10264) refactor(components): reduce post-migration TypeScript errors (#10356) refactor: do not use Host in functional components (#10352) refactor(tests): reduce TypeScript errors (#10344) feat(alert): add component tokens (#10218) fix(card): properly handle slotted elements (#10378) refactor(panel): remove duplicate tailwind class (#10379) feat(popover, action): add component tokens (#10253) chore(t9n): add translations (#10339) feat: add 3d building, 3d building parameter, divide, parcel, spaces, spaces parameter, square brackets x, n variable, zoning parameter (#10373) build: update browserslist db (#10370) ci: resolve husky pre-push and pre-commit errors (#10365) docs: update component READMEs (#10371) feat(text-area): add component tokens (#10343) fix(action): prefer `disabled` in favor of `aria-disabled` (#10367) docs(a11y): add reference to a11y guidance to issue template (#10372) chore(action): add new string for accessible indicator label (#10360) feat(chip): add component tokens (#10179) feat(avatar): add component tokens (#10280) ...
Related Issue: #9071
Summary