Merge remote-tracking branch 'origin/dev' into benelan/element-internals

* origin/dev: (230 commits)
  chore: release next
  chore(sort-handle): add messages (#10474)
  feat(accordion-item): stretch slotted actions to fill its height (#9250)
  chore: release next
  feat(dialog, modal, popover, input-date-picker,  input-time-picker, sheet): support stacked component sequential closing with escape (#9231)
  chore: remove commented-out code (#10478)
  chore: add cssrem VSCode extension recommendation (#10300)
  docs(accordion-item): fix deprecation tag (#10479)
  chore: release next
  feat(stepper-item): update component's active state background color. (#10475)
  refactor: use `requestAnimationFrame` to replace `readTask` (#10432)
  chore: release next
  fix(tip): fix rendering tied to named-slot content (#10470)
  ci: compile estimate totals per milestone (#10442)
  chore: release next
  fix(modal): fix rendering tied to named-slot content (#10469)
  chore: release next
  fix(shell-center-row): fix rendering tied to named-slot content (#10451)
  fix(inline-editable): fix rendering tied to default slot content (#10456)
  fix(input, input-number, input-text): should not set slotted actions to be disabled (#10458)
  ...

.github/ISSUE_TEMPLATE/accessibility.yml

@@ -8,7 +8,7 @@ body:
       label: Check existing issues
       description: If someone has already opened an issue for what you are experiencing, please add a 👍 reaction to the existing issue instead of creating a new one. For support, please check the [community forum](https://developers.arcgis.com/calcite-design-system/community/).
       options:
-        - label: I have [checked for existing issues](https://github.com/Esri/calcite-design-system/issues) to avoid duplicates
+        - label: I have [checked for existing issues](https://github.com/Esri/calcite-design-system/issues) to avoid duplicates and reviewed the [Accessibility page](https://developers.arcgis.com/calcite-design-system/foundations/accessibility) for guidance.
     validations:
       required: true
   - type: textarea
@@ -124,6 +124,7 @@ body:
         - ArcGIS Business/Community Analyst
         - ArcGIS Charts
         - ArcGIS Dashboards
+        - ArcGIS Data Pipelines
         - ArcGIS Developer Experience
         - ArcGIS Enterprise
         - ArcGIS Excalibur

.github/ISSUE_TEMPLATE/bug.yml

@@ -118,6 +118,7 @@ body:
         - ArcGIS Business/Community Analyst
         - ArcGIS Charts
         - ArcGIS Dashboards
+        - ArcGIS Data Pipelines
         - ArcGIS Developer Experience
         - ArcGIS Enterprise
         - ArcGIS Excalibur

.github/ISSUE_TEMPLATE/enhancement.yml

@@ -87,6 +87,7 @@ body:
         - ArcGIS Business/Community Analyst
         - ArcGIS Charts
         - ArcGIS Dashboards
+        - ArcGIS Data Pipelines
         - ArcGIS Developer Experience
         - ArcGIS Enterprise
         - ArcGIS Excalibur

.github/ISSUE_TEMPLATE/new-component.yml

@@ -71,6 +71,7 @@ body:
         - ArcGIS Business/Community Analyst
         - ArcGIS Charts
         - ArcGIS Dashboards
+        - ArcGIS Data Pipelines
         - ArcGIS Developer Experience
         - ArcGIS Enterprise
         - ArcGIS Excalibur

.github/scripts/addEsriProductLabel.js

@@ -28,22 +28,27 @@ module.exports = async ({ github, context }) => {
 
   const productRegexMatch = body.match(productRegex);
 
-  const product = (productRegexMatch && productRegexMatch[0] ? productRegexMatch[0] : "").trim();
-
-  if (product !== "N/A") {
-    await createLabelIfMissing({
-      github,
-      context,
-      label: product,
-      color: "006B75",
-      description: `Issues logged by ${product} team members.`,
-    });
-
-    await github.rest.issues.addLabels({
-      issue_number,
-      owner,
-      repo,
-      labels: [product],
-    });
+  // If issue includes "Esri team" line then create label, otherwise log message.
+  if (productRegexMatch) {
+    const product = (productRegexMatch && productRegexMatch[0] ? productRegexMatch[0] : "").trim();
+
+    if (product !== "N/A") {
+      await createLabelIfMissing({
+        github,
+        context,
+        label: product,
+        color: "006B75",
+        description: `Issues logged by ${product} team members.`,
+      });
+
+      await github.rest.issues.addLabels({
+        issue_number,
+        owner,
+        repo,
+        labels: [product],
+      });
+    }
+  } else {
+    console.log(`No Esri team listed on issue #${issue_number}`);
   }
 };

.github/scripts/addUnblockedComment.js

@@ -8,10 +8,10 @@ module.exports = async ({ github, context }) => {
   const payload = /** @type {import('@octokit/webhooks-types').IssuesLabeledEvent} */ (context.payload);
   const { ISSUE_VERIFIERS } = process.env;
   const issueBody = payload.issue.body;
-  const blockedIssuesRegex = /(?!Blocked issues:\s)(#\d+)/gi;
+  const blockedIssuesRegex = /Blocked issues:\s*(#\d+(?:,\s*#\d+)*)/i;
 
   if (!issueBody) {
-    console.log("No issue body was found");
+    console.log("No issue body was found.");
     return;
   }
 
@@ -23,7 +23,7 @@ module.exports = async ({ github, context }) => {
 
   // If "Blocked issues" line is matched in the body then create a comment on each issue listed
   if (blockedIssues) {
-    const issueNumbers = blockedIssues.map((number) => number.slice(1));
+    const issueNumbers = blockedIssues[1].split(",").map((num) => num.trim().slice(1));
 
     for (const issueNumber of issueNumbers) {
       const issueProps = {
@@ -32,10 +32,19 @@ module.exports = async ({ github, context }) => {
         issue_number: Number(issueNumber),
       };
 
-      await github.rest.issues.createComment({
-        ...issueProps,
-        body: `Issue #${context.issue.number} has been closed, this issue is ready for re-evaluation. \n\ncc ${verifiers}`,
-      });
+      try {
+        await github.rest.issues.createComment({
+          ...issueProps,
+          body: `Issue #${context.issue.number} has been closed, this issue is ready for re-evaluation. \n\ncc ${verifiers}`,
+        });
+      } catch (error) {
+        if (error.status === 404) {
+          console.log(`Issue #${issueNumber} does not exist.`);
+          continue;
+        } else {
+          throw error;
+        }
+      }
 
       try {
         await github.rest.issues.removeLabel({

.github/scripts/notifyWhenReadyForDev.js

@@ -42,6 +42,12 @@ module.exports = async ({ github, context }) => {
       label: issueWorkflow.assigned,
     });
 
+    await removeLabel({
+      github,
+      context,
+      label: planning.needsTriage,
+    });
+
     await github.rest.issues.addLabels({
       ...issueProps,
       labels: [issueWorkflow.new, planning.needsMilestone],

.github/scripts/support/resources.js

@@ -25,6 +25,7 @@ const resources = {
       verified: "4 - verified",
     },
     planning: {
+      needsTriage: "needs triage",
       needsMilestone: "needs milestone",
       spike: "spike",
       spikeComplete: "spike complete",

.github/scripts/support/utils.js

@@ -20,7 +20,11 @@ module.exports = {
         name: label,
       });
     } catch (err) {
-      console.log(`The '${label}' label is not associated with the issue`, err);
+      if (err.status === 404) {
+        console.log(`The label '${label}' is not associated with issue #${issue_number}.`, err);
+      } else {
+        console.log("Error while attempting to remove issue label.", err);
+      }
     }
   },
 

.github/scripts/trackMilestoneEstimates.js

@@ -0,0 +1,78 @@
+// @ts-check
+const { writeFile } = require("fs/promises");
+
+/** @param {import('github-script').AsyncFunctionArguments} AsyncFunctionArguments */
+module.exports = async ({ github, context, core }) => {
+  const { repo, owner } = context.repo;
+
+  const outputJson = {};
+  let outputCsv = "id,title,due_on,open_issues,closed_issues,remaining_estimate,completed_estimate";
+
+  try {
+    const milestones = await github.rest.issues.listMilestones({
+      owner: owner,
+      repo: repo,
+      state: "all",
+      sort: "due_on",
+      per_page: 100,
+      direction: "desc",
+    });
+
+    if (milestones.data.length === 0) {
+      console.error("No milestones found.");
+      process.exit(1);
+    }
+
+    for (const milestone of milestones.data) {
+      outputJson[milestone.number] = {
+        title: milestone.title,
+        due_on: milestone.due_on,
+        open_issues: milestone.open_issues,
+        closed_issues: milestone.closed_issues,
+        remaining_estimate: 0,
+        completed_estimate: 0,
+      };
+
+      const issues = await github.paginate(github.rest.issues.listForRepo, {
+        // @ts-ignore milestone.number is valid: https://docs.github.com/en/rest/issues/issues#list-repository-issues--parameters
+        milestone: milestone.number,
+        owner: owner,
+        repo: repo,
+        state: "all",
+        per_page: 100,
+      });
+
+      for (const issue of issues) {
+        if (issue.pull_request) {
+          continue;
+        }
+
+        for (const label of issue.labels) {
+          const estimateLabelMatch = (typeof label === "string" ? label : label?.name)?.match(/estimate - (\d+)/);
+
+          if (estimateLabelMatch?.length > 1) {
+            outputJson[milestone.number][issue.state === "open" ? "remaining_estimate" : "completed_estimate"] +=
+              Number.parseInt(estimateLabelMatch[1]);
+
+            break; // assumes an issue will only have one estimate label
+          }
+        }
+      }
+
+      outputCsv = `${outputCsv}\n${milestone.number},${Object.values(outputJson[milestone.number]).join(",")}`;
+    }
+
+    const stringifiedOutputJson = JSON.stringify(outputJson, null, 2);
+
+    core.debug(`JSON Output:\n${stringifiedOutputJson}`);
+    core.debug(`CSV Output:\n${outputCsv}`);
+
+    await writeFile("./milestone-estimates.csv", outputCsv);
+    await writeFile("./milestone-estimates.json", stringifiedOutputJson);
+
+    process.exit(0);
+  } catch (error) {
+    console.error(error);
+    process.exit(1);
+  }
+};

.github/workflows/deploy-latest.yml

@@ -60,7 +60,6 @@ jobs:
       - name: Build Packages and Publish to NPM
         if: steps.release.outputs.releases_created == 'true'
         env:
-          RELEASED_PATHS: ${{ toJSON(steps.release.outputs.paths_released) }}
           NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
           NPM_CONFIG_PROVENANCE: true
           GH_TOKEN: ${{ secrets.ADMIN_TOKEN }}
@@ -92,7 +91,7 @@ jobs:
           git commit -m "build: update types and package-lock" || true
 
           npm run publish:latest
-          npm run util:upload-release-assets -- "$RELEASED_PATHS"
+          npm run util:upload-release-assets -- "${{toJSON(steps.release.outputs.paths_released)}}"
 
           git checkout -b ci/cherry-pick-release-commit origin/dev
 
@@ -101,7 +100,7 @@ jobs:
               ${{github.workspace}}/packages/*/CHANGELOG.md \
               ${{github.workspace}}/packages/calcite-components-angular/projects/component-library/CHANGELOG.md
 
-            git checkout --theirs
+            git checkout --theirs \
               ${{github.workspace}}/packages/*/package.json \
               ${{github.workspace}}/packages/calcite-components-angular/projects/component-library/package.json
 

.github/workflows/pr-semantic.yml

@@ -9,3 +9,20 @@ jobs:
       - uses: amannn/action-semantic-pull-request@v5.5.3
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          types: |
+            # default https://github.com/commitizen/conventional-commit-types/blob/master/index.json
+            feat
+            fix
+            docs
+            style
+            refactor
+            perf
+            test
+            build
+            ci
+            chore
+            revert
+
+            # custom
+            deprecate

.github/workflows/track-milestone-estimates.yml

@@ -0,0 +1,21 @@
+name: Track Milestone Estimates
+on:
+  workflow_dispatch:
+  issues:
+    types: [closed]
+jobs:
+  estimates:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Create estimates data
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const action = require('${{ github.workspace }}/.github/scripts/trackMilestoneEstimates.js')
+            await action({github, context, core})
+      - name: Upload estimates data
+        uses: actions/upload-artifact@v4
+        with:
+          name: milestone-estimates
+          path: milestone-estimates.*

.husky/pre-commit

@@ -1,11 +1,67 @@
 #!/usr/bin/env sh
 
-lint-staged
-
-types_path="packages/calcite-components/src/components.d.ts"
+ensure_types_are_up_to_date() {
+  types_path="packages/calcite-components/src/components.d.ts"
 
-# make sure the types are always up to date
-if [ -n "$(git diff --name-only -- "$types_path")" ]; then
+  if [ -n "$(git diff --name-only -- "$types_path")" ]; then
     echo "Automatically staging changes to \"$types_path\""
-    git add "$types_path"
-fi
+    git add "$types_path" >/dev/null 2>&1 || true
+  fi
+}
+
+update_stylelint_config_if_sass_file_edited() {
+  staged_files="$(
+    git diff --cached --name-only --diff-filter=ACM -- packages/**/*.scss
+  )" 
+
+  if [ -n "$staged_files" ]; then
+    npm run util:update-stylelint-custom-sass-functions
+    git add "packages/calcite-components/.stylelintrc.cjs" >/dev/null 2>&1 || true
+  fi
+
+  unset staged_files
+}
+
+check_ui_icon_name_consistency() {
+  # this pattern checks for `<iconName>-<size>.svg` or `<iconName>-<size>-f.svg` for filled icons
+  # where `<iconName>` is kebab-case, `<size>` is 16, 24, or 32
+  valid_pattern="^[a-z0-9-]+-(16|24|32)(-f)?\\.svg$"
+
+  # this pattern will check for invalid use of "-f-" anywhere except right before the size
+  invalid_pattern="-[a-z0-9]+-f-"
+
+  staged_files="$(
+    git diff --cached --name-only --diff-filter=ACM -- packages/calcite-ui-icons/icons/*.svg
+  )"
+
+  if [ -n "$staged_files" ]; then
+    for file in $staged_files; do
+      filename="$(basename "$file")"
+
+      # first, ensure the filename follows the valid pattern
+      if ! echo "$filename" | grep -qE "$valid_pattern"; then
+        printf "%s\n%s" \
+          "error: file '$file' does not follow the naming convention:" \
+          "(<iconname>-<size>.svg | <iconname>-<size>-f.svg)"
+        exit 1
+      fi
+
+      # then, ensure there's no invalid use of "-f-" anywhere except right before the size
+      if echo "$filename" | grep -qE "$invalid_pattern"; then
+        printf '%s\n%s' \
+          "error: file '$file' has an invalid '-f-' and does not follow the naming convention:" \
+          "(<iconname>-<size>.svg | <iconname>-<size>-f.svg)"
+        exit 1
+      fi
+    done
+  fi
+
+  unset staged_files
+}
+
+lint-staged
+check_ui_icon_name_consistency
+ensure_types_are_up_to_date
+update_stylelint_config_if_sass_file_edited
+
+exit 0