Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: compile estimate totals per milestone #10442

Merged
merged 8 commits into from
Oct 1, 2024

Conversation

benelan
Copy link
Member

@benelan benelan commented Sep 30, 2024

Related Issue: #8359

Summary

Add an action that creates a spreadsheet and JSON file with the total estimates per milestone. The action runs when an issue closes and can be manually dispatched. The files are saved as artifacts in the workflow run. I'll add a wiki page about running the workflow and retrieving the data once it's live.

It might be because I'm a GraphQL noob, but Monday's API reference was not very helpful. I can give the integration another try if this is not ergonomic enough.

…estone-estimates

* origin/dev: (997 commits)
  fix: correct non-standard filled icon names (#10309)
  fix(panel): initially closed panel should be hidden (#10308)
  chore(linting): automate tracking of custom Sass functions for stylelint (#10313)
  chore: tidy up demo pages (#10314)
  build(deps): update dependency dayjs to v1.11.13 (#10283)
  build(deps): update dependency jsdom to v24.1.3 (#10298)
  build(deps): update dependency husky to v9.1.6 (#10318)
  build(deps): update angular-cli monorepo to v18.2.4 (#10317)
  docs: update component READMEs (#10316)
  refactor(stylelint): change config to module format to enable more dynamic options (#10311)
  refactor: fixup typescript errors (#10295)
  build(deps): update dependency lint-staged to v15.2.10 (#10302)
  build(deps): update dependency focus-trap to v7.6.0 (#10281)
  build(deps): update dependency husky to v9.1.5 (#10297)
  chore: release next
  feat(checkbox): add component tokens (#10221)
  revert: "chore: set default page size for E2E tests (#10219)" (#10299)
  chore(icons): ensure UI icons follow naming convention (#10292)
  chore: release next
  feat: add model-history, raster-function-history, raster function-template-history, raster-tool-history, tool-history (#10305)
  ...
…estone-estimates

* origin/dev: (29 commits)
  fix(input-time-zone): fix region mode labeling and value mapping (#10345)
  fix(dropdown): open dropdown on `ArrowDown` & `ArrowUp` keys (#10264)
  refactor(components): reduce post-migration TypeScript errors (#10356)
  refactor: do not use Host in functional components (#10352)
  refactor(tests): reduce TypeScript errors (#10344)
  feat(alert): add component tokens (#10218)
  fix(card): properly handle slotted elements (#10378)
  refactor(panel): remove duplicate tailwind class (#10379)
  feat(popover, action): add component tokens (#10253)
  chore(t9n): add translations (#10339)
  feat: add 3d building, 3d building parameter, divide, parcel, spaces, spaces parameter, square brackets x, n variable, zoning parameter (#10373)
  build: update browserslist db (#10370)
  ci: resolve husky pre-push and pre-commit errors (#10365)
  docs: update component READMEs (#10371)
  feat(text-area): add component tokens (#10343)
  fix(action): prefer `disabled` in favor of `aria-disabled` (#10367)
  docs(a11y): add reference to a11y guidance to issue template (#10372)
  chore(action): add new string for accessible indicator label (#10360)
  feat(chip): add component tokens (#10179)
  feat(avatar): add component tokens (#10280)
  ...
…estone-estimates

* origin/dev: (26 commits)
  test: fix `window.getComputedStyle` arguments (#10424)
  test(card): remove redundant spy and setup wrapper element (#10429)
  test(heading): avoid `newSpecPage` usage to ease Lumina migration (#10431)
  refactor(themed): drop broken, unused, regexp arg support (#10425)
  docs: component token description consistency (#10430)
  refactor: prevent mixed Sass mixed declaration warnings (#10426)
  deprecate: deprecate `enforce-ref-last-prop` rule (#10421)
  chore(actions): add custom `deprecate` type to semantic-pr check (#10427)
  chore(issue templates): add arcgis data pipelines to team dropdown (#10418)
  fix(tooltip): closed tooltips should not reappear (#10420)
  feat: add dashboard-graph (#10417)
  fix(input-time-zone): fix region mode quirks after update (#10413)
  fix(text-area): ensure border-color token doesn't override invalid styles (#10390)
  ci(changelog): add deprecation commits to changelog automation (#10346)
  fix: properly set aria attributes on components (#10404)
  feat: add parcel parameter (#10384)
  feat(alert): apply --calcite-alert-corner-radius to internal close button (#10388)
  feat(dialog, panel): Add css properties for background-color (#10387)
  fix: remove aria-disabled from components where necessary (#10374)
  feat(action-group, block, panel): add `menuPlacement` and `menuFlipPlacements` properties (#10249)
  ...
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Sep 30, 2024
Copy link
Member

@geospatialem geospatialem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🏆

Code-wise will defer approval to @jcfranco, but in initial sleuthing this looks great! Wondering if there are limitations that should be mentioned here as well, it looks like we can only run on up to 100 milestones and 100 issues for each milestone. Wondering if that could pose a problem, in particular around the 100 milestones since they could be open or closed. WDYT?

@benelan
Copy link
Member Author

benelan commented Sep 30, 2024

I'm paginating the issues so there is no limit. I could do the same for milestones, the downside being runs will take longer. You're the main consumer of this data so let me know how many milestones should be included and if you'd like any additional columns.

@geospatialem
Copy link
Member

I'm paginating the issues so there is no limit. I could do the same for milestones, the downside being runs will take longer. You're the main consumer of this data so let me know how many milestones should be included and if you'd like any additional columns.

No worries, it seems like a good approach and we can re-evaluate in the future if needed. 💪🏻

Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉
📉📈📉📉📉📈📉📉📈📈📉📉📈📈📈📉📉📈📈📈📉📈📈📈📈📉📈📉
📉📈📈📉📉📈📉📈📉📉📈📉📉📈📉📉📈📉📉📉📉📈📉📉📉📉📈📉
📉📈📉📈📉📈📉📈📉📉📈📉📉📈📉📉📈📉📉📉📉📈📈📈📉📉📈📉
📉📈📉📉📈📈📉📈📉📉📈📉📉📈📉📉📈📉📉📉📉📈📉📉📉📉📉📉
📉📈📉📉📉📈📉📉📈📈📉📉📈📈📈📉📉📈📈📈📉📈📈📈📈📉📈📉
📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉📉

@benelan benelan added the skip visual snapshots Pull requests that do not need visual regression testing. label Oct 1, 2024
@benelan benelan merged commit 06105ac into dev Oct 1, 2024
14 checks passed
@benelan benelan deleted the benelan/8359-track-milestone-estimates branch October 1, 2024 21:28
@github-actions github-actions bot added this to the 2.13.1 patch milestone Oct 1, 2024
benelan added a commit that referenced this pull request Oct 7, 2024
* origin/dev: (230 commits)
  chore: release next
  chore(sort-handle): add messages (#10474)
  feat(accordion-item): stretch slotted actions to fill its height (#9250)
  chore: release next
  feat(dialog, modal, popover, input-date-picker,  input-time-picker, sheet): support stacked component sequential closing with escape (#9231)
  chore: remove commented-out code (#10478)
  chore: add cssrem VSCode extension recommendation (#10300)
  docs(accordion-item): fix deprecation tag (#10479)
  chore: release next
  feat(stepper-item): update component's active state background color. (#10475)
  refactor: use `requestAnimationFrame` to replace `readTask` (#10432)
  chore: release next
  fix(tip): fix rendering tied to named-slot content (#10470)
  ci: compile estimate totals per milestone (#10442)
  chore: release next
  fix(modal): fix rendering tied to named-slot content (#10469)
  chore: release next
  fix(shell-center-row): fix rendering tied to named-slot content (#10451)
  fix(inline-editable): fix rendering tied to default slot content (#10456)
  fix(input, input-number, input-text): should not set slotted actions to be disabled (#10458)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants