Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly set aria attributes on components #10404

Merged
merged 4 commits into from
Sep 26, 2024
Merged

fix: properly set aria attributes on components #10404

merged 4 commits into from
Sep 26, 2024

Conversation

driskull
Copy link
Member

@driskull driskull commented Sep 26, 2024 •
edited
Loading

Related Issue: #10407

Summary

  • only sets aria-expanded on button when present on host
  • properly sets boolean values to strings on other components
  • removes aria-hidden from screen reader text

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Sep 26, 2024
@driskull driskull marked this pull request as ready for review September 26, 2024 18:48
driskull
driskull commented Sep 26, 2024
View reviewed changes
packages/calcite-components/src/components/table-row/table-row.tsx
@@ -410,7 +414,7 @@ export class TableRow implements InteractiveComponent, LocalizedComponent {
<InteractiveContainer disabled={this.disabled}>
<tr
aria-rowindex={this.positionAll + 1}
aria-selected={this.selected}
aria-selected={toAriaBoolean(this.selected)}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't doing anything. This fixes it.

driskull
driskull commented Sep 26, 2024
View reviewed changes
packages/calcite-components/src/components/table-header/table-header.tsx
aria-live={this.focused ? "polite" : "off"}
class={CSS.assistiveText}
>
<span aria-live={this.focused ? "polite" : "off"} class={CSS.assistiveText}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen reader text shouldn't have aria-hidden.

driskull
driskull commented Sep 26, 2024
View reviewed changes
packages/calcite-components/src/components/table-cell/table-cell.tsx
aria-live={this.focused ? "polite" : "off"}
class={CSS.assistiveText}
>
<span aria-live={this.focused ? "polite" : "off"} class={CSS.assistiveText}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen reader text shouldn't have aria-hidden.

driskull
driskull commented Sep 26, 2024
View reviewed changes
packages/calcite-components/src/components/button/button.tsx
@@ -267,7 +267,7 @@ export class Button
<InteractiveContainer disabled={this.disabled}>
<Tag
aria-busy={toAriaBoolean(this.loading)}
aria-expanded={this.el.ariaExpanded}
aria-expanded={this.el.ariaExpanded ? this.el.ariaExpanded : null}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only set aria-expanded when set on host

driskull
driskull commented Sep 26, 2024
View reviewed changes
packages/calcite-components/src/components/text-area/text-area.tsx
@@ -366,7 +366,7 @@ export class TextArea
</footer>
<HiddenFormInputSlot component={this} />
{this.isCharacterLimitExceeded() && (
<span aria-hidden={true} aria-live="polite" class={CSS.assistiveText} id={this.guid}>
<span aria-live="polite" class={CSS.assistiveText} id={this.guid}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen reader text shouldn't have aria-hidden.

driskull
driskull commented Sep 26, 2024
View reviewed changes
packages/calcite-components/src/components/tree/tree.tsx
: (
this.selectionMode === "multiple" || this.selectionMode === "multichildren"
).toString()
: toAriaBoolean(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@driskull driskull changed the title fix: properly set boolean aria attributes on components fix: properly set aria attributes on components Sep 26, 2024
jcfranco
jcfranco approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Before merging, can we create and link an issue for this, so it can go through the verification process?

@driskull
Copy link
Member Author

Created and linked issue

@driskull driskull added the skip visual snapshots Pull requests that do not need visual regression testing. label Sep 26, 2024
@driskull driskull merged commit 864f3e3 into dev Sep 26, 2024
19 checks passed
@driskull driskull deleted the dris0000/more-aria-fixes branch September 26, 2024 21:13
benelan added a commit that referenced this pull request Sep 26, 2024
@benelan
Merge remote-tracking branch 'origin/dev' into benelan/text-area-inva…
e8ccf1e 
…lid-border-color

* origin/dev:
  ci(changelog): add deprecation commits to changelog automation (#10346)
  fix: properly set aria attributes on components (#10404)
  feat: add parcel parameter (#10384)
benelan added a commit that referenced this pull request Sep 30, 2024
@benelan
Merge remote-tracking branch 'origin/dev' into benelan/8359-track-mil…
d2794f9 
…estone-estimates

* origin/dev: (26 commits)
  test: fix `window.getComputedStyle` arguments (#10424)
  test(card): remove redundant spy and setup wrapper element (#10429)
  test(heading): avoid `newSpecPage` usage to ease Lumina migration (#10431)
  refactor(themed): drop broken, unused, regexp arg support (#10425)
  docs: component token description consistency (#10430)
  refactor: prevent mixed Sass mixed declaration warnings (#10426)
  deprecate: deprecate `enforce-ref-last-prop` rule (#10421)
  chore(actions): add custom `deprecate` type to semantic-pr check (#10427)
  chore(issue templates): add arcgis data pipelines to team dropdown (#10418)
  fix(tooltip): closed tooltips should not reappear (#10420)
  feat: add dashboard-graph (#10417)
  fix(input-time-zone): fix region mode quirks after update (#10413)
  fix(text-area): ensure border-color token doesn't override invalid styles (#10390)
  ci(changelog): add deprecation commits to changelog automation (#10346)
  fix: properly set aria attributes on components (#10404)
  feat: add parcel parameter (#10384)
  feat(alert): apply --calcite-alert-corner-radius to internal close button (#10388)
  feat(dialog, panel): Add css properties for background-color (#10387)
  fix: remove aria-disabled from components where necessary (#10374)
  feat(action-group, block, panel): add `menuPlacement` and `menuFlipPlacements` properties (#10249)
  ...
@calcite-admin calcite-admin mentioned this pull request Sep 30, 2024
Merged
benelan pushed a commit that referenced this pull request Oct 1, 2024
@calcite-admin @github-actions
chore: release main (#10457)
42c1329 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-ui-icons: 3.32.0</summary>

##
[3.32.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@3.31.0...@esri/calcite-ui-icons@3.32.0)
(2024-09-30)


### Features

* Add 3d building, 3d building parameter, divide, parcel, spaces, spaces
parameter, square brackets x, n variable, zoning parameter
([#10373](#10373))
([3ed86ce](3ed86ce))
* Add content inline right
([#10338](#10338))
([b4530ab](b4530ab))
* Add dashboard-graph
([#10417](#10417))
([737085a](737085a))
* Add justify
([#10272](#10272))
([3d6c013](3d6c013))
* Add model-history, raster-function-history, raster
function-template-history, raster-tool-history, tool-history
([#10305](#10305))
([1e31d43](1e31d43))
* Add parcel parameter
([#10384](#10384))
([c99be67](c99be67))
* Add trace path and trace path complete
([#10196](#10196))
([c37ced5](c37ced5))
* Add validate
([#10354](#10354))
([4160af1](4160af1))
* Add web adaptor
([#10286](#10286))
([791fd78](791fd78))
* Added connection end left, connection end right, connection middle,
connection to connection
([#10198](#10198))
([3d0f703](3d0f703))


### Bug Fixes

* Correct non-standard filled icon names
([#10309](#10309))
([7d67334](7d67334))
</details>

<details><summary>@esri/eslint-plugin-calcite-components:
1.2.1</summary>

##
[1.2.1](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@1.2.0...@esri/eslint-plugin-calcite-components@1.2.1)
(2024-09-30)


### Deprecations

* Deprecate `enforce-ref-last-prop` rule
([#10421](#10421))
([5fde52d](5fde52d))
</details>

<details><summary>@esri/calcite-components: 2.13.0</summary>

##
[2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.12.2...@esri/calcite-components@2.13.0)
(2024-09-30)


### Features

* **accordion-item:** Update component tokens
([ca932b5](ca932b5))
* **action-group, block, panel:** Add `menuPlacement` and
`menuFlipPlacements` properties
([#10249](#10249))
([5ba3112](5ba3112))
* **alert:** Add component tokens
([#10218](#10218))
([550427b](550427b))
* **alert:** Apply --calcite-alert-corner-radius to internal close
button
([#10388](#10388))
([f50c170](f50c170))
* **avatar:** Add component tokens
([#10280](#10280))
([f8f881b](f8f881b))
* **carousel:** Improve support for high item counts
([#10315](#10315))
([6ad2612](6ad2612))
* **checkbox:** Add component tokens
([#10221](#10221))
([1d87dcf](1d87dcf))
* **chip:** Add component tokens
([#10179](#10179))
([ff82570](ff82570))
* **dialog, panel:** Add css properties for background-color
([#10387](#10387))
([d725293](d725293))
* **handle:** Add component tokens
([#10262](#10262))
([5e73b44](5e73b44))
* **input, input-number, input-text:** Add prefix and suffix width css
tokens
([#10206](#10206))
([7a6ee82](7a6ee82))
* **list-item:** Add `unavailable` property
([#10377](#10377))
([9332733](9332733))
* **panel:** Improve panel header layout
([#10446](#10446))
([12f1476](12f1476))
* **popover, action:** Add component tokens
([#10253](#10253))
([80e8112](80e8112))
* **popover:** Apply component tokens to arrow
([#10386](#10386))
([2d19268](2d19268))
* **progress:** Add component tokens
([#10267](#10267))
([8c1259f](8c1259f))
* **text-area:** Add component tokens
([#10343](#10343))
([d2504b7](d2504b7))


### Bug Fixes

* **action-pad:** Fix horizontal action group alignment
([#10359](#10359))
([7b03745](7b03745))
* **action-pad:** Update layout on action-group elements slotted after
initialization
([#10355](#10355))
([cf139fa](cf139fa))
* **action:** Prefer `disabled` in favor of `aria-disabled`
([#10367](#10367))
([1895c07](1895c07))
* **card:** Properly handle slotted elements
([#10378](#10378))
([99a7148](99a7148))
* **combobox:** Correctly select an item with
`selection-mode=‘single-persist’` when items have the same values
([5401ea6](5401ea6))
* **dialog:** Only prevent default on escape key when escapeDisabled is
true
([#10336](#10336))
([0083630](0083630))
* **dropdown:** Open dropdown on `ArrowDown` & `ArrowUp` keys
([#10264](#10264))
([98548e4](98548e4))
* **input-time-zone:** Fix region mode labeling and value mapping
([#10345](#10345))
([cf36299](cf36299))
* **input-time-zone:** Fix region mode quirks after update
([#10413](#10413))
([c137d1f](c137d1f))
* **list, filter:** Fix sync between list items and filtered data
([#10342](#10342))
([9a66601](9a66601))
* **panel:** Initially closed panel should be hidden
([#10308](#10308))
([46de96b](46de96b))
* **popover:** Update focus trap elements on mutation observer
([#10357](#10357))
([725254a](725254a))
* Properly set aria attributes on components
([#10404](#10404))
([864f3e3](864f3e3))
* Remove aria-disabled from components where necessary
([#10374](#10374))
([4f8c16c](4f8c16c))
* **segmented-control:** Honor appearance, layout and scale when items
are added after initialization
([#10368](#10368))
([98177f0](98177f0))
* **shell:** Fix z-index of slotted popover elements
([#10325](#10325))
([7fe1601](7fe1601))
* **text-area:** Ensure border-color token doesn't override invalid
styles
([#10390](#10390))
([699e166](699e166))
* **tooltip:** Closed tooltips should not reappear
([#10420](#10420))
([a2f3925](a2f3925))


### Deprecations

* **checkbox, radio-button:** Deprecate 'guid' properties
([#10445](#10445))
([9729ccf](9729ccf))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-ui-icons bumped from 3.32.0-next.5 to 3.32.0
  * devDependencies
* @esri/eslint-plugin-calcite-components bumped from 1.2.1-next.4 to
1.2.1
</details>

<details><summary>@esri/calcite-components-angular: 2.13.0</summary>

##
[2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.12.2...@esri/calcite-components-angular@2.13.0)
(2024-09-30)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0
</details>

<details><summary>@esri/calcite-components-react: 2.13.0</summary>

##
[2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.12.2...@esri/calcite-components-react@2.13.0)
(2024-09-30)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@benelan benelan mentioned this pull request Oct 1, 2024
Closed
benelan pushed a commit that referenced this pull request Oct 1, 2024
@calcite-admin @github-actions @benelan
chore: release main (#10457)
23beff8 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-ui-icons: 3.32.0</summary>

##
[3.32.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@3.31.0...@esri/calcite-ui-icons@3.32.0)
(2024-09-30)


### Features

* Add 3d building, 3d building parameter, divide, parcel, spaces, spaces
parameter, square brackets x, n variable, zoning parameter
([#10373](#10373))
([3ed86ce](3ed86ce))
* Add content inline right
([#10338](#10338))
([b4530ab](b4530ab))
* Add dashboard-graph
([#10417](#10417))
([737085a](737085a))
* Add justify
([#10272](#10272))
([3d6c013](3d6c013))
* Add model-history, raster-function-history, raster
function-template-history, raster-tool-history, tool-history
([#10305](#10305))
([1e31d43](1e31d43))
* Add parcel parameter
([#10384](#10384))
([c99be67](c99be67))
* Add trace path and trace path complete
([#10196](#10196))
([c37ced5](c37ced5))
* Add validate
([#10354](#10354))
([4160af1](4160af1))
* Add web adaptor
([#10286](#10286))
([791fd78](791fd78))
* Added connection end left, connection end right, connection middle,
connection to connection
([#10198](#10198))
([3d0f703](3d0f703))


### Bug Fixes

* Correct non-standard filled icon names
([#10309](#10309))
([7d67334](7d67334))
</details>

<details><summary>@esri/eslint-plugin-calcite-components:
1.2.1</summary>

##
[1.2.1](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@1.2.0...@esri/eslint-plugin-calcite-components@1.2.1)
(2024-09-30)


### Deprecations

* Deprecate `enforce-ref-last-prop` rule
([#10421](#10421))
([5fde52d](5fde52d))
</details>

<details><summary>@esri/calcite-components: 2.13.0</summary>

##
[2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.12.2...@esri/calcite-components@2.13.0)
(2024-09-30)


### Features

* **accordion-item:** Update component tokens
([ca932b5](ca932b5))
* **action-group, block, panel:** Add `menuPlacement` and
`menuFlipPlacements` properties
([#10249](#10249))
([5ba3112](5ba3112))
* **alert:** Add component tokens
([#10218](#10218))
([550427b](550427b))
* **alert:** Apply --calcite-alert-corner-radius to internal close
button
([#10388](#10388))
([f50c170](f50c170))
* **avatar:** Add component tokens
([#10280](#10280))
([f8f881b](f8f881b))
* **carousel:** Improve support for high item counts
([#10315](#10315))
([6ad2612](6ad2612))
* **checkbox:** Add component tokens
([#10221](#10221))
([1d87dcf](1d87dcf))
* **chip:** Add component tokens
([#10179](#10179))
([ff82570](ff82570))
* **dialog, panel:** Add css properties for background-color
([#10387](#10387))
([d725293](d725293))
* **handle:** Add component tokens
([#10262](#10262))
([5e73b44](5e73b44))
* **input, input-number, input-text:** Add prefix and suffix width css
tokens
([#10206](#10206))
([7a6ee82](7a6ee82))
* **list-item:** Add `unavailable` property
([#10377](#10377))
([9332733](9332733))
* **panel:** Improve panel header layout
([#10446](#10446))
([12f1476](12f1476))
* **popover, action:** Add component tokens
([#10253](#10253))
([80e8112](80e8112))
* **popover:** Apply component tokens to arrow
([#10386](#10386))
([2d19268](2d19268))
* **progress:** Add component tokens
([#10267](#10267))
([8c1259f](8c1259f))
* **text-area:** Add component tokens
([#10343](#10343))
([d2504b7](d2504b7))


### Bug Fixes

* **action-pad:** Fix horizontal action group alignment
([#10359](#10359))
([7b03745](7b03745))
* **action-pad:** Update layout on action-group elements slotted after
initialization
([#10355](#10355))
([cf139fa](cf139fa))
* **action:** Prefer `disabled` in favor of `aria-disabled`
([#10367](#10367))
([1895c07](1895c07))
* **card:** Properly handle slotted elements
([#10378](#10378))
([99a7148](99a7148))
* **combobox:** Correctly select an item with
`selection-mode=‘single-persist’` when items have the same values
([5401ea6](5401ea6))
* **dialog:** Only prevent default on escape key when escapeDisabled is
true
([#10336](#10336))
([0083630](0083630))
* **dropdown:** Open dropdown on `ArrowDown` & `ArrowUp` keys
([#10264](#10264))
([98548e4](98548e4))
* **input-time-zone:** Fix region mode labeling and value mapping
([#10345](#10345))
([cf36299](cf36299))
* **input-time-zone:** Fix region mode quirks after update
([#10413](#10413))
([c137d1f](c137d1f))
* **list, filter:** Fix sync between list items and filtered data
([#10342](#10342))
([9a66601](9a66601))
* **panel:** Initially closed panel should be hidden
([#10308](#10308))
([46de96b](46de96b))
* **popover:** Update focus trap elements on mutation observer
([#10357](#10357))
([725254a](725254a))
* Properly set aria attributes on components
([#10404](#10404))
([864f3e3](864f3e3))
* Remove aria-disabled from components where necessary
([#10374](#10374))
([4f8c16c](4f8c16c))
* **segmented-control:** Honor appearance, layout and scale when items
are added after initialization
([#10368](#10368))
([98177f0](98177f0))
* **shell:** Fix z-index of slotted popover elements
([#10325](#10325))
([7fe1601](7fe1601))
* **text-area:** Ensure border-color token doesn't override invalid
styles
([#10390](#10390))
([699e166](699e166))
* **tooltip:** Closed tooltips should not reappear
([#10420](#10420))
([a2f3925](a2f3925))


### Deprecations

* **checkbox, radio-button:** Deprecate 'guid' properties
([#10445](#10445))
([9729ccf](9729ccf))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-ui-icons bumped from 3.32.0-next.5 to 3.32.0
  * devDependencies
* @esri/eslint-plugin-calcite-components bumped from 1.2.1-next.4 to
1.2.1
</details>

<details><summary>@esri/calcite-components-angular: 2.13.0</summary>

##
[2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.12.2...@esri/calcite-components-angular@2.13.0)
(2024-09-30)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0
</details>

<details><summary>@esri/calcite-components-react: 2.13.0</summary>

##
[2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.12.2...@esri/calcite-components-react@2.13.0)
(2024-09-30)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@calcite-admin calcite-admin mentioned this pull request Oct 1, 2024
Merged
calcite-admin added a commit that referenced this pull request Oct 1, 2024
@calcite-admin @github-actions
chore: release main (#10457)
96dfd3b 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-ui-icons: 3.32.0</summary>

##
[3.32.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@3.31.0...@esri/calcite-ui-icons@3.32.0)
(2024-09-30)


### Features

* Add 3d building, 3d building parameter, divide, parcel, spaces, spaces
parameter, square brackets x, n variable, zoning parameter
([#10373](#10373))
([3ed86ce](3ed86ce))
* Add content inline right
([#10338](#10338))
([b4530ab](b4530ab))
* Add dashboard-graph
([#10417](#10417))
([737085a](737085a))
* Add justify
([#10272](#10272))
([3d6c013](3d6c013))
* Add model-history, raster-function-history, raster
function-template-history, raster-tool-history, tool-history
([#10305](#10305))
([1e31d43](1e31d43))
* Add parcel parameter
([#10384](#10384))
([c99be67](c99be67))
* Add trace path and trace path complete
([#10196](#10196))
([c37ced5](c37ced5))
* Add validate
([#10354](#10354))
([4160af1](4160af1))
* Add web adaptor
([#10286](#10286))
([791fd78](791fd78))
* Added connection end left, connection end right, connection middle,
connection to connection
([#10198](#10198))
([3d0f703](3d0f703))


### Bug Fixes

* Correct non-standard filled icon names
([#10309](#10309))
([7d67334](7d67334))
</details>

<details><summary>@esri/eslint-plugin-calcite-components:
1.2.1</summary>

##
[1.2.1](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@1.2.0...@esri/eslint-plugin-calcite-components@1.2.1)
(2024-09-30)


### Deprecations

* Deprecate `enforce-ref-last-prop` rule
([#10421](#10421))
([5fde52d](5fde52d))
</details>

<details><summary>@esri/calcite-components: 2.13.0</summary>

##
[2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.12.2...@esri/calcite-components@2.13.0)
(2024-09-30)


### Features

* **accordion-item:** Update component tokens
([ca932b5](ca932b5))
* **action-group, block, panel:** Add `menuPlacement` and
`menuFlipPlacements` properties
([#10249](#10249))
([5ba3112](5ba3112))
* **alert:** Add component tokens
([#10218](#10218))
([550427b](550427b))
* **alert:** Apply --calcite-alert-corner-radius to internal close
button
([#10388](#10388))
([f50c170](f50c170))
* **avatar:** Add component tokens
([#10280](#10280))
([f8f881b](f8f881b))
* **carousel:** Improve support for high item counts
([#10315](#10315))
([6ad2612](6ad2612))
* **checkbox:** Add component tokens
([#10221](#10221))
([1d87dcf](1d87dcf))
* **chip:** Add component tokens
([#10179](#10179))
([ff82570](ff82570))
* **dialog, panel:** Add css properties for background-color
([#10387](#10387))
([d725293](d725293))
* **handle:** Add component tokens
([#10262](#10262))
([5e73b44](5e73b44))
* **input, input-number, input-text:** Add prefix and suffix width css
tokens
([#10206](#10206))
([7a6ee82](7a6ee82))
* **list-item:** Add `unavailable` property
([#10377](#10377))
([9332733](9332733))
* **panel:** Improve panel header layout
([#10446](#10446))
([12f1476](12f1476))
* **popover, action:** Add component tokens
([#10253](#10253))
([80e8112](80e8112))
* **popover:** Apply component tokens to arrow
([#10386](#10386))
([2d19268](2d19268))
* **progress:** Add component tokens
([#10267](#10267))
([8c1259f](8c1259f))
* **text-area:** Add component tokens
([#10343](#10343))
([d2504b7](d2504b7))


### Bug Fixes

* **action-pad:** Fix horizontal action group alignment
([#10359](#10359))
([7b03745](7b03745))
* **action-pad:** Update layout on action-group elements slotted after
initialization
([#10355](#10355))
([cf139fa](cf139fa))
* **action:** Prefer `disabled` in favor of `aria-disabled`
([#10367](#10367))
([1895c07](1895c07))
* **card:** Properly handle slotted elements
([#10378](#10378))
([99a7148](99a7148))
* **combobox:** Correctly select an item with
`selection-mode=‘single-persist’` when items have the same values
([5401ea6](5401ea6))
* **dialog:** Only prevent default on escape key when escapeDisabled is
true
([#10336](#10336))
([0083630](0083630))
* **dropdown:** Open dropdown on `ArrowDown` & `ArrowUp` keys
([#10264](#10264))
([98548e4](98548e4))
* **input-time-zone:** Fix region mode labeling and value mapping
([#10345](#10345))
([cf36299](cf36299))
* **input-time-zone:** Fix region mode quirks after update
([#10413](#10413))
([c137d1f](c137d1f))
* **list, filter:** Fix sync between list items and filtered data
([#10342](#10342))
([9a66601](9a66601))
* **panel:** Initially closed panel should be hidden
([#10308](#10308))
([46de96b](46de96b))
* **popover:** Update focus trap elements on mutation observer
([#10357](#10357))
([725254a](725254a))
* Properly set aria attributes on components
([#10404](#10404))
([864f3e3](864f3e3))
* Remove aria-disabled from components where necessary
([#10374](#10374))
([4f8c16c](4f8c16c))
* **segmented-control:** Honor appearance, layout and scale when items
are added after initialization
([#10368](#10368))
([98177f0](98177f0))
* **shell:** Fix z-index of slotted popover elements
([#10325](#10325))
([7fe1601](7fe1601))
* **text-area:** Ensure border-color token doesn't override invalid
styles
([#10390](#10390))
([699e166](699e166))
* **tooltip:** Closed tooltips should not reappear
([#10420](#10420))
([a2f3925](a2f3925))


### Deprecations

* **checkbox, radio-button:** Deprecate 'guid' properties
([#10445](#10445))
([9729ccf](9729ccf))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-ui-icons bumped from 3.32.0-next.5 to 3.32.0
  * devDependencies
* @esri/eslint-plugin-calcite-components bumped from 1.2.1-next.4 to
1.2.1
</details>

<details><summary>@esri/calcite-components-angular: 2.13.0</summary>

##
[2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.12.2...@esri/calcite-components-angular@2.13.0)
(2024-09-30)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0
</details>

<details><summary>@esri/calcite-components-react: 2.13.0</summary>

##
[2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.12.2...@esri/calcite-components-react@2.13.0)
(2024-09-30)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
benelan pushed a commit that referenced this pull request Oct 1, 2024
@calcite-admin @github-actions
chore: release main (#10457)
3fe26ca 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-ui-icons: 3.32.0</summary>

##

[3.32.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@3.31.0...@esri/calcite-ui-icons@3.32.0)
(2024-09-30)


### Features

* Add 3d building, 3d building parameter, divide, parcel, spaces, spaces
parameter, square brackets x, n variable, zoning parameter
([#10373](#10373))

([3ed86ce](3ed86ce))
* Add content inline right
([#10338](#10338))

([b4530ab](b4530ab))
* Add dashboard-graph
([#10417](#10417))

([737085a](737085a))
* Add justify
([#10272](#10272))

([3d6c013](3d6c013))
* Add model-history, raster-function-history, raster
function-template-history, raster-tool-history, tool-history
([#10305](#10305))

([1e31d43](1e31d43))
* Add parcel parameter
([#10384](#10384))

([c99be67](c99be67))
* Add trace path and trace path complete
([#10196](#10196))

([c37ced5](c37ced5))
* Add validate
([#10354](#10354))

([4160af1](4160af1))
* Add web adaptor
([#10286](#10286))

([791fd78](791fd78))
* Added connection end left, connection end right, connection middle,
connection to connection
([#10198](#10198))

([3d0f703](3d0f703))


### Bug Fixes

* Correct non-standard filled icon names
([#10309](#10309))

([7d67334](7d67334))
</details>

<details><summary>@esri/eslint-plugin-calcite-components:
1.2.1</summary>

##

[1.2.1](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@1.2.0...@esri/eslint-plugin-calcite-components@1.2.1)
(2024-09-30)


### Deprecations

* Deprecate `enforce-ref-last-prop` rule
([#10421](#10421))

([5fde52d](5fde52d))
</details>

<details><summary>@esri/calcite-components: 2.13.0</summary>

##

[2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.12.2...@esri/calcite-components@2.13.0)
(2024-09-30)


### Features

* **accordion-item:** Update component tokens

([ca932b5](ca932b5))
* **action-group, block, panel:** Add `menuPlacement` and
`menuFlipPlacements` properties
([#10249](#10249))

([5ba3112](5ba3112))
* **alert:** Add component tokens
([#10218](#10218))

([550427b](550427b))
* **alert:** Apply --calcite-alert-corner-radius to internal close
button
([#10388](#10388))

([f50c170](f50c170))
* **avatar:** Add component tokens
([#10280](#10280))

([f8f881b](f8f881b))
* **carousel:** Improve support for high item counts
([#10315](#10315))

([6ad2612](6ad2612))
* **checkbox:** Add component tokens
([#10221](#10221))

([1d87dcf](1d87dcf))
* **chip:** Add component tokens
([#10179](#10179))

([ff82570](ff82570))
* **dialog, panel:** Add css properties for background-color
([#10387](#10387))

([d725293](d725293))
* **handle:** Add component tokens
([#10262](#10262))

([5e73b44](5e73b44))
* **input, input-number, input-text:** Add prefix and suffix width css
tokens
([#10206](#10206))

([7a6ee82](7a6ee82))
* **list-item:** Add `unavailable` property
([#10377](#10377))

([9332733](9332733))
* **panel:** Improve panel header layout
([#10446](#10446))

([12f1476](12f1476))
* **popover, action:** Add component tokens
([#10253](#10253))

([80e8112](80e8112))
* **popover:** Apply component tokens to arrow
([#10386](#10386))

([2d19268](2d19268))
* **progress:** Add component tokens
([#10267](#10267))

([8c1259f](8c1259f))
* **text-area:** Add component tokens
([#10343](#10343))

([d2504b7](d2504b7))


### Bug Fixes

* **action-pad:** Fix horizontal action group alignment
([#10359](#10359))

([7b03745](7b03745))
* **action-pad:** Update layout on action-group elements slotted after
initialization
([#10355](#10355))

([cf139fa](cf139fa))
* **action:** Prefer `disabled` in favor of `aria-disabled`
([#10367](#10367))

([1895c07](1895c07))
* **card:** Properly handle slotted elements
([#10378](#10378))

([99a7148](99a7148))
* **combobox:** Correctly select an item with
`selection-mode=‘single-persist’` when items have the same values

([5401ea6](5401ea6))
* **dialog:** Only prevent default on escape key when escapeDisabled is
true
([#10336](#10336))

([0083630](0083630))
* **dropdown:** Open dropdown on `ArrowDown` & `ArrowUp` keys
([#10264](#10264))

([98548e4](98548e4))
* **input-time-zone:** Fix region mode labeling and value mapping
([#10345](#10345))

([cf36299](cf36299))
* **input-time-zone:** Fix region mode quirks after update
([#10413](#10413))

([c137d1f](c137d1f))
* **list, filter:** Fix sync between list items and filtered data
([#10342](#10342))

([9a66601](9a66601))
* **panel:** Initially closed panel should be hidden
([#10308](#10308))

([46de96b](46de96b))
* **popover:** Update focus trap elements on mutation observer
([#10357](#10357))

([725254a](725254a))
* Properly set aria attributes on components
([#10404](#10404))

([864f3e3](864f3e3))
* Remove aria-disabled from components where necessary
([#10374](#10374))

([4f8c16c](4f8c16c))
* **segmented-control:** Honor appearance, layout and scale when items
are added after initialization
([#10368](#10368))

([98177f0](98177f0))
* **shell:** Fix z-index of slotted popover elements
([#10325](#10325))

([7fe1601](7fe1601))
* **text-area:** Ensure border-color token doesn't override invalid
styles
([#10390](#10390))

([699e166](699e166))
* **tooltip:** Closed tooltips should not reappear
([#10420](#10420))

([a2f3925](a2f3925))


### Deprecations

* **checkbox, radio-button:** Deprecate 'guid' properties
([#10445](#10445))

([9729ccf](9729ccf))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-ui-icons bumped from 3.32.0-next.5 to 3.32.0
  * devDependencies
* @esri/eslint-plugin-calcite-components bumped from 1.2.1-next.4 to
1.2.1
</details>

<details><summary>@esri/calcite-components-angular: 2.13.0</summary>

##

[2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.12.2...@esri/calcite-components-angular@2.13.0)
(2024-09-30)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0
</details>

<details><summary>@esri/calcite-components-react: 2.13.0</summary>

##

[2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.12.2...@esri/calcite-components-react@2.13.0)
(2024-09-30)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See

[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot]
<github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@macandcheese macandcheese Awaiting requested review from macandcheese

@geospatialem geospatialem Awaiting requested review from geospatialem

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-09-30 - 2.13.0 Sep Main release
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @jcfranco