feat(checkbox): add component tokens #10221

aPreciado88 · 2024-09-05T00:14:27Z

Related Issue: #7180

Summary

Add checkbox component tokens.

--calcite-checkbox-shadow-color: Specifies the component's color.
--calcite-checkbox-shadow-color-hover: Specifies the component's color when hovered.
--calcite-checkbox-color: Specifies the component's font color.

jcfranco

--calcite-checkbox-size is an existing prop, so let's remove it from the PR description. Other than that, proposed component token props LGTM!

jcfranco

👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾
👾🪙👾👾👾🪙🪙🪙🪙👾🪙🪙🪙🪙🪙👾🪙👾👾👾🪙👾🪙👾
👾🪙👾👾👾🪙👾👾👾👾👾👾🪙👾👾👾🪙🪙👾🪙🪙👾🪙👾
👾🪙👾👾👾🪙👾🪙🪙👾👾👾🪙👾👾👾🪙👾🪙👾🪙👾🪙👾
👾🪙👾👾👾🪙👾👾🪙👾👾👾🪙👾👾👾🪙👾👾👾🪙👾👾👾
👾🪙🪙🪙👾🪙🪙🪙🪙👾👾👾🪙👾👾👾🪙👾👾👾🪙👾🪙👾
👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾👾

jcfranco · 2024-09-06T16:40:47Z

packages/calcite-components/src/components/checkbox/checkbox.scss

@@ -4,16 +4,31 @@
 * These properties can be overridden using the component's tag as selector.
 *
 * @prop --calcite-checkbox-size: Specifies the component's height and width.
+ * @prop --calcite-checkbox-box-shadow: Specifies the component's svg box color.


I should've spotted this sooner, but can you revisit the prop description to not mention implementation details (i.e., svg)? Applies to new props.

aPreciado88 · 2024-09-06T17:10:45Z

@ashetland @SkyeSeitz Could you please take a look at the new chromatic build?

cc @alisonailea

alisonailea

just some minor naming tweaks

alisonailea · 2024-09-10T18:48:32Z

packages/calcite-components/src/components/checkbox/checkbox.scss

@@ -4,16 +4,31 @@
 * These properties can be overridden using the component's tag as selector.
 *
 * @prop --calcite-checkbox-size: Specifies the component's height and width.
+ * @prop --calcite-checkbox-box-shadow: Specifies the component's color.


Upldate this to --calcite-checkbox-box-shadow-color

I thought we were using shadow, not box-shadow here? https://github.com/Esri/calcite-design-system/wiki/component-tokens#3-review-component-for-tokenizable-styles

Good catch, I totally missed this. The preferred naming for the CSS properties is parenthesized in the linked doc above, right? E.g., * border-radius (corner-radius)

I renamed this one to --calcite-checkbox-shadow-color, as suggested in the doc above.

I realize it's basically being used as a border - but that begs the question.. Shouldn't this be a separate --calcite-checkbox-border-color (obfuscating the implementation detail of it using box-shadow from the user) - and then a separate calcite-checkbox-shadow css prop that defaults to shadow-none to allow for theming?

@macandcheese Right again. I thought these new props were used for a drop shadow, but I overlooked how they were being applied.

@aPreciado88 The shadow props will need to be updated. The themed helper handles this and another case here. You can use this as a reference to confirm if we’re dealing with a border prop or not. LMK if you have any questions.

Sorry for the hassle, y'all!

I updated the tokens to --calcite-checkbox-border-color and --calcite-checkbox-border-color-hover.

Yeah I'm sorry. I agree with @macandcheese and @jcfranco

alisonailea · 2024-09-10T18:48:59Z

packages/calcite-components/src/components/checkbox/checkbox.scss

@@ -4,16 +4,31 @@
 * These properties can be overridden using the component's tag as selector.
 *
 * @prop --calcite-checkbox-size: Specifies the component's height and width.
+ * @prop --calcite-checkbox-box-shadow: Specifies the component's color.
+ * @prop --calcite-checkbox-box-shadow-hover: Specifies the component's color when hovered.


--calcite-checkbox-box-shadow-color-hover

Just sanity check here on our patterns as it has changed a few times - this is preferable to calcite-checkbox:hover { --calcite-checkbox-shadow: "whatever" }, correct?

I renamed this one to --calcite-checkbox-shadow-color-hover

Just sanity check here on our patterns as it has changed a few times - this is preferable to calcite-checkbox:hover { --calcite-checkbox-shadow: "whatever" }, correct?

I believe so, but I'll let @alisonailea confirm. This approach is more consistent and intuitive than the previous one. It's also not mentioned as an example in the latest Component Tokens wiki.

aPreciado88 · 2024-09-10T19:05:30Z

I updated the tokens to --calcite-checkbox-shadow-color and --calcite-checkbox-shadow-color-hover.
Can you please confirm if this is okay? @alisonailea @macandcheese

alisonailea

Sorry just a few more things

packages/calcite-components/src/components/checkbox/checkbox.scss

alisonailea · 2024-09-11T20:11:44Z

packages/calcite-components/src/custom-theme/checkbox.ts

@@ -1,5 +1,10 @@
 import { html } from "../../support/formatting";

+export const checkboxTokens = {
+  calciteCheckboxSize: "",
+  calciteCheckboxColor: "",


add calciteCheckboxBorderColor

alisonailea

just add the calciteCheckboxBorderColor and we're good to go

jcfranco · 2024-09-12T22:06:54Z

packages/calcite-components/src/components/checkbox/checkbox.scss

@@ -4,16 +4,31 @@
 * These properties can be overridden using the component's tag as selector.
 *
 * @prop --calcite-checkbox-size: Specifies the component's height and width.
+ * @prop --calcite-checkbox-border-color: Specifies the component's color.
+ * @prop --calcite-checkbox-border-color-hover: Specifies the component's color when hovered.
+ * @prop --calcite-checkbox-color: Specifies the component's font color.


Can we revisit this description? It is used to set the color prop, but from a user's perspective, it's setting the check's color.

@alisonailea Do we need to specify icon in the name or is this an exception because the component is mostly an icon? If it's the latter, we could add a note and/or example to the Component Token doc.

we could use -checkbox-icon-color but I think -checkbox-color makes sense here but I'm open to either

I'll leave it as -checkbox-color.

Let’s use --calcite-checkbox-icon-color for consistency. Since we already differentiate the border color, I think sticking with the icon color makes sense.

I updated the token to --calcite-checkbox-icon-color 🚀

…estone-estimates * origin/dev: (997 commits) fix: correct non-standard filled icon names (#10309) fix(panel): initially closed panel should be hidden (#10308) chore(linting): automate tracking of custom Sass functions for stylelint (#10313) chore: tidy up demo pages (#10314) build(deps): update dependency dayjs to v1.11.13 (#10283) build(deps): update dependency jsdom to v24.1.3 (#10298) build(deps): update dependency husky to v9.1.6 (#10318) build(deps): update angular-cli monorepo to v18.2.4 (#10317) docs: update component READMEs (#10316) refactor(stylelint): change config to module format to enable more dynamic options (#10311) refactor: fixup typescript errors (#10295) build(deps): update dependency lint-staged to v15.2.10 (#10302) build(deps): update dependency focus-trap to v7.6.0 (#10281) build(deps): update dependency husky to v9.1.5 (#10297) chore: release next feat(checkbox): add component tokens (#10221) revert: "chore: set default page size for E2E tests (#10219)" (#10299) chore(icons): ensure UI icons follow naming convention (#10292) chore: release next feat: add model-history, raster-function-history, raster function-template-history, raster-tool-history, tool-history (#10305) ...

🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-ui-icons: 3.32.0</summary> ## [3.32.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@3.31.0...@esri/calcite-ui-icons@3.32.0) (2024-09-30) ### Features * Add 3d building, 3d building parameter, divide, parcel, spaces, spaces parameter, square brackets x, n variable, zoning parameter ([#10373](#10373)) ([3ed86ce](3ed86ce)) * Add content inline right ([#10338](#10338)) ([b4530ab](b4530ab)) * Add dashboard-graph ([#10417](#10417)) ([737085a](737085a)) * Add justify ([#10272](#10272)) ([3d6c013](3d6c013)) * Add model-history, raster-function-history, raster function-template-history, raster-tool-history, tool-history ([#10305](#10305)) ([1e31d43](1e31d43)) * Add parcel parameter ([#10384](#10384)) ([c99be67](c99be67)) * Add trace path and trace path complete ([#10196](#10196)) ([c37ced5](c37ced5)) * Add validate ([#10354](#10354)) ([4160af1](4160af1)) * Add web adaptor ([#10286](#10286)) ([791fd78](791fd78)) * Added connection end left, connection end right, connection middle, connection to connection ([#10198](#10198)) ([3d0f703](3d0f703)) ### Bug Fixes * Correct non-standard filled icon names ([#10309](#10309)) ([7d67334](7d67334)) </details> <details><summary>@esri/eslint-plugin-calcite-components: 1.2.1</summary> ## [1.2.1](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@1.2.0...@esri/eslint-plugin-calcite-components@1.2.1) (2024-09-30) ### Deprecations * Deprecate `enforce-ref-last-prop` rule ([#10421](#10421)) ([5fde52d](5fde52d)) </details> <details><summary>@esri/calcite-components: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.12.2...@esri/calcite-components@2.13.0) (2024-09-30) ### Features * **accordion-item:** Update component tokens ([ca932b5](ca932b5)) * **action-group, block, panel:** Add `menuPlacement` and `menuFlipPlacements` properties ([#10249](#10249)) ([5ba3112](5ba3112)) * **alert:** Add component tokens ([#10218](#10218)) ([550427b](550427b)) * **alert:** Apply --calcite-alert-corner-radius to internal close button ([#10388](#10388)) ([f50c170](f50c170)) * **avatar:** Add component tokens ([#10280](#10280)) ([f8f881b](f8f881b)) * **carousel:** Improve support for high item counts ([#10315](#10315)) ([6ad2612](6ad2612)) * **checkbox:** Add component tokens ([#10221](#10221)) ([1d87dcf](1d87dcf)) * **chip:** Add component tokens ([#10179](#10179)) ([ff82570](ff82570)) * **dialog, panel:** Add css properties for background-color ([#10387](#10387)) ([d725293](d725293)) * **handle:** Add component tokens ([#10262](#10262)) ([5e73b44](5e73b44)) * **input, input-number, input-text:** Add prefix and suffix width css tokens ([#10206](#10206)) ([7a6ee82](7a6ee82)) * **list-item:** Add `unavailable` property ([#10377](#10377)) ([9332733](9332733)) * **panel:** Improve panel header layout ([#10446](#10446)) ([12f1476](12f1476)) * **popover, action:** Add component tokens ([#10253](#10253)) ([80e8112](80e8112)) * **popover:** Apply component tokens to arrow ([#10386](#10386)) ([2d19268](2d19268)) * **progress:** Add component tokens ([#10267](#10267)) ([8c1259f](8c1259f)) * **text-area:** Add component tokens ([#10343](#10343)) ([d2504b7](d2504b7)) ### Bug Fixes * **action-pad:** Fix horizontal action group alignment ([#10359](#10359)) ([7b03745](7b03745)) * **action-pad:** Update layout on action-group elements slotted after initialization ([#10355](#10355)) ([cf139fa](cf139fa)) * **action:** Prefer `disabled` in favor of `aria-disabled` ([#10367](#10367)) ([1895c07](1895c07)) * **card:** Properly handle slotted elements ([#10378](#10378)) ([99a7148](99a7148)) * **combobox:** Correctly select an item with `selection-mode=‘single-persist’` when items have the same values ([5401ea6](5401ea6)) * **dialog:** Only prevent default on escape key when escapeDisabled is true ([#10336](#10336)) ([0083630](0083630)) * **dropdown:** Open dropdown on `ArrowDown` & `ArrowUp` keys ([#10264](#10264)) ([98548e4](98548e4)) * **input-time-zone:** Fix region mode labeling and value mapping ([#10345](#10345)) ([cf36299](cf36299)) * **input-time-zone:** Fix region mode quirks after update ([#10413](#10413)) ([c137d1f](c137d1f)) * **list, filter:** Fix sync between list items and filtered data ([#10342](#10342)) ([9a66601](9a66601)) * **panel:** Initially closed panel should be hidden ([#10308](#10308)) ([46de96b](46de96b)) * **popover:** Update focus trap elements on mutation observer ([#10357](#10357)) ([725254a](725254a)) * Properly set aria attributes on components ([#10404](#10404)) ([864f3e3](864f3e3)) * Remove aria-disabled from components where necessary ([#10374](#10374)) ([4f8c16c](4f8c16c)) * **segmented-control:** Honor appearance, layout and scale when items are added after initialization ([#10368](#10368)) ([98177f0](98177f0)) * **shell:** Fix z-index of slotted popover elements ([#10325](#10325)) ([7fe1601](7fe1601)) * **text-area:** Ensure border-color token doesn't override invalid styles ([#10390](#10390)) ([699e166](699e166)) * **tooltip:** Closed tooltips should not reappear ([#10420](#10420)) ([a2f3925](a2f3925)) ### Deprecations * **checkbox, radio-button:** Deprecate 'guid' properties ([#10445](#10445)) ([9729ccf](9729ccf)) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-ui-icons bumped from 3.32.0-next.5 to 3.32.0 * devDependencies * @esri/eslint-plugin-calcite-components bumped from 1.2.1-next.4 to 1.2.1 </details> <details><summary>@esri/calcite-components-angular: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.12.2...@esri/calcite-components-angular@2.13.0) (2024-09-30) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0 </details> <details><summary>@esri/calcite-components-react: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.12.2...@esri/calcite-components-react@2.13.0) (2024-09-30) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-ui-icons: 3.32.0</summary> ## [3.32.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@3.31.0...@esri/calcite-ui-icons@3.32.0) (2024-09-30) ### Features * Add 3d building, 3d building parameter, divide, parcel, spaces, spaces parameter, square brackets x, n variable, zoning parameter ([#10373](#10373)) ([3ed86ce](3ed86ce)) * Add content inline right ([#10338](#10338)) ([b4530ab](b4530ab)) * Add dashboard-graph ([#10417](#10417)) ([737085a](737085a)) * Add justify ([#10272](#10272)) ([3d6c013](3d6c013)) * Add model-history, raster-function-history, raster function-template-history, raster-tool-history, tool-history ([#10305](#10305)) ([1e31d43](1e31d43)) * Add parcel parameter ([#10384](#10384)) ([c99be67](c99be67)) * Add trace path and trace path complete ([#10196](#10196)) ([c37ced5](c37ced5)) * Add validate ([#10354](#10354)) ([4160af1](4160af1)) * Add web adaptor ([#10286](#10286)) ([791fd78](791fd78)) * Added connection end left, connection end right, connection middle, connection to connection ([#10198](#10198)) ([3d0f703](3d0f703)) ### Bug Fixes * Correct non-standard filled icon names ([#10309](#10309)) ([7d67334](7d67334)) </details> <details><summary>@esri/eslint-plugin-calcite-components: 1.2.1</summary> ## [1.2.1](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@1.2.0...@esri/eslint-plugin-calcite-components@1.2.1) (2024-09-30) ### Deprecations * Deprecate `enforce-ref-last-prop` rule ([#10421](#10421)) ([5fde52d](5fde52d)) </details> <details><summary>@esri/calcite-components: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.12.2...@esri/calcite-components@2.13.0) (2024-09-30) ### Features * **accordion-item:** Update component tokens ([ca932b5](ca932b5)) * **action-group, block, panel:** Add `menuPlacement` and `menuFlipPlacements` properties ([#10249](#10249)) ([5ba3112](5ba3112)) * **alert:** Add component tokens ([#10218](#10218)) ([550427b](550427b)) * **alert:** Apply --calcite-alert-corner-radius to internal close button ([#10388](#10388)) ([f50c170](f50c170)) * **avatar:** Add component tokens ([#10280](#10280)) ([f8f881b](f8f881b)) * **carousel:** Improve support for high item counts ([#10315](#10315)) ([6ad2612](6ad2612)) * **checkbox:** Add component tokens ([#10221](#10221)) ([1d87dcf](1d87dcf)) * **chip:** Add component tokens ([#10179](#10179)) ([ff82570](ff82570)) * **dialog, panel:** Add css properties for background-color ([#10387](#10387)) ([d725293](d725293)) * **handle:** Add component tokens ([#10262](#10262)) ([5e73b44](5e73b44)) * **input, input-number, input-text:** Add prefix and suffix width css tokens ([#10206](#10206)) ([7a6ee82](7a6ee82)) * **list-item:** Add `unavailable` property ([#10377](#10377)) ([9332733](9332733)) * **panel:** Improve panel header layout ([#10446](#10446)) ([12f1476](12f1476)) * **popover, action:** Add component tokens ([#10253](#10253)) ([80e8112](80e8112)) * **popover:** Apply component tokens to arrow ([#10386](#10386)) ([2d19268](2d19268)) * **progress:** Add component tokens ([#10267](#10267)) ([8c1259f](8c1259f)) * **text-area:** Add component tokens ([#10343](#10343)) ([d2504b7](d2504b7)) ### Bug Fixes * **action-pad:** Fix horizontal action group alignment ([#10359](#10359)) ([7b03745](7b03745)) * **action-pad:** Update layout on action-group elements slotted after initialization ([#10355](#10355)) ([cf139fa](cf139fa)) * **action:** Prefer `disabled` in favor of `aria-disabled` ([#10367](#10367)) ([1895c07](1895c07)) * **card:** Properly handle slotted elements ([#10378](#10378)) ([99a7148](99a7148)) * **combobox:** Correctly select an item with `selection-mode=‘single-persist’` when items have the same values ([5401ea6](5401ea6)) * **dialog:** Only prevent default on escape key when escapeDisabled is true ([#10336](#10336)) ([0083630](0083630)) * **dropdown:** Open dropdown on `ArrowDown` & `ArrowUp` keys ([#10264](#10264)) ([98548e4](98548e4)) * **input-time-zone:** Fix region mode labeling and value mapping ([#10345](#10345)) ([cf36299](cf36299)) * **input-time-zone:** Fix region mode quirks after update ([#10413](#10413)) ([c137d1f](c137d1f)) * **list, filter:** Fix sync between list items and filtered data ([#10342](#10342)) ([9a66601](9a66601)) * **panel:** Initially closed panel should be hidden ([#10308](#10308)) ([46de96b](46de96b)) * **popover:** Update focus trap elements on mutation observer ([#10357](#10357)) ([725254a](725254a)) * Properly set aria attributes on components ([#10404](#10404)) ([864f3e3](864f3e3)) * Remove aria-disabled from components where necessary ([#10374](#10374)) ([4f8c16c](4f8c16c)) * **segmented-control:** Honor appearance, layout and scale when items are added after initialization ([#10368](#10368)) ([98177f0](98177f0)) * **shell:** Fix z-index of slotted popover elements ([#10325](#10325)) ([7fe1601](7fe1601)) * **text-area:** Ensure border-color token doesn't override invalid styles ([#10390](#10390)) ([699e166](699e166)) * **tooltip:** Closed tooltips should not reappear ([#10420](#10420)) ([a2f3925](a2f3925)) ### Deprecations * **checkbox, radio-button:** Deprecate 'guid' properties ([#10445](#10445)) ([9729ccf](9729ccf)) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-ui-icons bumped from 3.32.0-next.5 to 3.32.0 * devDependencies * @esri/eslint-plugin-calcite-components bumped from 1.2.1-next.4 to 1.2.1 </details> <details><summary>@esri/calcite-components-angular: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.12.2...@esri/calcite-components-angular@2.13.0) (2024-09-30) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0 </details> <details><summary>@esri/calcite-components-react: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.12.2...@esri/calcite-components-react@2.13.0) (2024-09-30) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

feat(checkbox): add component tokens

7d9d84f

github-actions bot assigned aPreciado88 Sep 5, 2024

github-actions bot added the enhancement Issues tied to a new feature or request. label Sep 5, 2024

jcfranco reviewed Sep 5, 2024

View reviewed changes

feat(checkbox): add component tokens

b8eefa1

aPreciado88 marked this pull request as ready for review September 5, 2024 21:04

aPreciado88 requested review from jcfranco, macandcheese, driskull and alisonailea September 5, 2024 21:04

feat(checkbox): add custom theme tokens

5907007

jcfranco approved these changes Sep 6, 2024

View reviewed changes

feat(checkbox): add component tokens

ba442c6

aPreciado88 added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Sep 6, 2024

alisonailea approved these changes Sep 10, 2024

View reviewed changes

feat(checkbox): add component tokens

01ddeee

aPreciado88 added 2 commits September 10, 2024 12:21

feat(checkbox): add component tokens

bbbfebc

feat(checkbox): add component tokens

e42b8ab

alisonailea requested changes Sep 11, 2024

View reviewed changes

alisonailea approved these changes Sep 12, 2024

View reviewed changes

jcfranco reviewed Sep 12, 2024

View reviewed changes

aPreciado88 added 2 commits September 13, 2024 13:24

feat(checkbox): add component tokens

70d8589

feat(checkbox): add component tokens

6e129f5

aPreciado88 added pr ready for visual snapshots Adding this label will run visual snapshot testing. skip visual snapshots Pull requests that do not need visual regression testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Sep 13, 2024

aPreciado88 merged commit 1d87dcf into dev Sep 13, 2024
15 checks passed

aPreciado88 deleted the aPreciado/7180-add-checkbox-design-tokens branch September 13, 2024 21:16

github-actions bot added this to the 2024-09-24 - Sep Main release milestone Sep 13, 2024

aPreciado88 mentioned this pull request Sep 13, 2024

Design token phase II - Integration across components #7180

Open

geospatialem mentioned this pull request Sep 19, 2024

feat(text-area): add component tokens #10343

Merged

calcite-admin mentioned this pull request Sep 30, 2024

chore: release main #10457

Merged

benelan mentioned this pull request Oct 1, 2024

chore: release main (#10457) #10461

Closed

calcite-admin mentioned this pull request Oct 1, 2024

chore: release main (#10457) #10463

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(checkbox): add component tokens #10221

feat(checkbox): add component tokens #10221

aPreciado88 commented Sep 5, 2024 •

edited

Loading

jcfranco left a comment

jcfranco left a comment

jcfranco Sep 6, 2024

aPreciado88 commented Sep 6, 2024

alisonailea left a comment

alisonailea Sep 10, 2024

macandcheese Sep 10, 2024

jcfranco Sep 10, 2024

aPreciado88 Sep 10, 2024

macandcheese Sep 10, 2024 •

edited

Loading

jcfranco Sep 11, 2024

aPreciado88 Sep 11, 2024

alisonailea Sep 12, 2024

alisonailea Sep 10, 2024

macandcheese Sep 10, 2024

aPreciado88 Sep 10, 2024

jcfranco Sep 10, 2024

alisonailea Sep 12, 2024

aPreciado88 commented Sep 10, 2024 •

edited

Loading

alisonailea left a comment

alisonailea Sep 11, 2024

alisonailea left a comment

jcfranco Sep 12, 2024 •

edited

Loading

alisonailea Sep 13, 2024

aPreciado88 Sep 13, 2024

jcfranco Sep 13, 2024 •

edited

Loading

aPreciado88 Sep 13, 2024

feat(checkbox): add component tokens #10221

feat(checkbox): add component tokens #10221

Conversation

aPreciado88 commented Sep 5, 2024 • edited Loading

Summary

jcfranco left a comment

Choose a reason for hiding this comment

jcfranco left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aPreciado88 commented Sep 6, 2024

alisonailea left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

macandcheese Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aPreciado88 commented Sep 10, 2024 • edited Loading

alisonailea left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alisonailea left a comment

Choose a reason for hiding this comment

jcfranco Sep 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jcfranco Sep 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aPreciado88 commented Sep 5, 2024 •

edited

Loading

macandcheese Sep 10, 2024 •

edited

Loading

aPreciado88 commented Sep 10, 2024 •

edited

Loading

jcfranco Sep 12, 2024 •

edited

Loading

jcfranco Sep 13, 2024 •

edited

Loading