Merge remote-tracking branch 'origin/dev' into benelan/8359-track-mil…

…estone-estimates

* origin/dev: (997 commits)
  fix: correct non-standard filled icon names (#10309)
  fix(panel): initially closed panel should be hidden (#10308)
  chore(linting): automate tracking of custom Sass functions for stylelint (#10313)
  chore: tidy up demo pages (#10314)
  build(deps): update dependency dayjs to v1.11.13 (#10283)
  build(deps): update dependency jsdom to v24.1.3 (#10298)
  build(deps): update dependency husky to v9.1.6 (#10318)
  build(deps): update angular-cli monorepo to v18.2.4 (#10317)
  docs: update component READMEs (#10316)
  refactor(stylelint): change config to module format to enable more dynamic options (#10311)
  refactor: fixup typescript errors (#10295)
  build(deps): update dependency lint-staged to v15.2.10 (#10302)
  build(deps): update dependency focus-trap to v7.6.0 (#10281)
  build(deps): update dependency husky to v9.1.5 (#10297)
  chore: release next
  feat(checkbox): add component tokens (#10221)
  revert: "chore: set default page size for E2E tests (#10219)" (#10299)
  chore(icons): ensure UI icons follow naming convention (#10292)
  chore: release next
  feat: add model-history, raster-function-history, raster function-template-history, raster-tool-history, tool-history (#10305)
  ...

.github/CODEOWNERS

@@ -0,0 +1,10 @@
+# The files matching the globs will be assigned to the @usernames that follow
+*                                           # no catch-all code owner to reduce notifications
+.*                                          @benelan @jcfranco
+*.json                                      @benelan @jcfranco
+CHANGELOG.md                                @benelan @jcfranco @geospatialem
+.github/                                    @benelan @jcfranco @geospatialem
+support/                                    @benelan @jcfranco
+/packages/calcite-components-react          @benelan @jcfranco
+/packages/eslint-plugin-calcite-components  @jcfranco
+/packages/calcite-design-tokens             @alisonailea

.github/ISSUE_TEMPLATE/accessibility.yml

@@ -36,7 +36,7 @@ body:
     attributes:
       label: Reproduction Sample
       description: |
-        We provide the following templates to help get started: [codepen](https://codepen.io/pen?template=RwgrjEx) (just Calcite), [codesandbox](https://codesandbox.io/s/calcite-template-p95kp?file=/src/App.js) (Calcite with React wrapper), or [jsbin](https://jsbin.com/qecewik/edit?html,output) (Calcite with ArcGIS JSAPI). You can also make your own sample using one of the those websites. Alternatively, a [documentation sample](https://developers.arcgis.com/calcite-design-system/components) can be used if the issue is reproducible. If you are experiencing build or Node related errors, please provide a GitHub repo for the sample.
+        We provide the following templates to help get started: [codepen](https://codepen.io/pen?template=RwgrjEx) (just Calcite), [React Codesandbox](https://codesandbox.io/s/calcite-template-p95kp?file=/src/App.js) (Calcite with React wrapper), [Angular Codesandbox](https://codesandbox.io/p/sandbox/little-fire-2hx4qh?file=%2Fsrc%2Fapp%2Fapp.component.html%3A16%2C51), or [jsbin](https://jsbin.com/qecewik/edit?html,output) (Calcite with ArcGIS JSAPI). You can also make your own sample using one of the those websites. Alternatively, a [documentation sample](https://developers.arcgis.com/calcite-design-system/components) can be used if the issue is reproducible. If you are experiencing build or Node related errors, please provide a GitHub repo for the sample.
     validations:
       required: true
   - type: textarea
@@ -91,16 +91,15 @@ body:
       multiple: false
       description: What is the impact to you, your team, or organization? Use discretion and only select "need" or "emergency" priorities for high user impact and quality issues. For instance, would someone notice, in a bad way, if this issue were present in the release?
       options:
-        - p4 - not time sensitive
-        - p3 - want for upcoming milestone
-        - p2 - want for current milestone
-        - p1 - need for current milestone
-        - p0 - emergency
+        - impact - p3 - not time sensitive
+        - impact - p2 - want for an upcoming milestone
+        - impact - p1 - need for current milestone
+        - impact - p0 - emergency
   - type: checkboxes
     id: packages
     attributes:
       label: Calcite package
-      description: Select the relevant [package(s)](https://github.com/Esri/calcite-design-system/tree/main/packages) related to the request.
+      description: Select the relevant [package(s)](https://github.com/Esri/calcite-design-system/tree/dev/packages) related to the request.
       options:
         - label: "@esri/calcite-components"
         - label: "@esri/calcite-components-angular"
@@ -119,6 +118,7 @@ body:
       description: If you work at Esri, please select your product team. Otherwise choose "N/A". If your team is not listed, choose "N/A", and then edit the line after submitting the issue.
       options:
         - N/A
+        - Application Protoype Lab - APL
         - ArcGIS Solutions
         - ArcGIS AppStudio
         - ArcGIS Business/Community Analyst

.github/ISSUE_TEMPLATE/bug.yml

@@ -30,7 +30,7 @@ body:
     attributes:
       label: Reproduction Sample
       description: |
-        We provide the following templates to help get started: [codepen](https://codepen.io/pen?template=RwgrjEx) (just Calcite), [codesandbox](https://codesandbox.io/s/calcite-template-p95kp?file=/src/App.js) (Calcite with React wrapper), or [jsbin](https://jsbin.com/qecewik/edit?html,output) (Calcite with ArcGIS JSAPI). You can also make your own sample using one of the those websites. Alternatively, a [documentation sample](https://developers.arcgis.com/calcite-design-system/components) can be used if the issue is reproducible. If you are experiencing build or Node related errors, please provide a GitHub repo for the sample.
+        We provide the following templates to help get started: [codepen](https://codepen.io/pen?template=RwgrjEx) (just Calcite), [React Codesandbox](https://codesandbox.io/s/calcite-template-p95kp?file=/src/App.js) (Calcite with React wrapper), [Angular Codesandbox](https://codesandbox.io/p/sandbox/little-fire-2hx4qh?file=%2Fsrc%2Fapp%2Fapp.component.html%3A16%2C51), or [jsbin](https://jsbin.com/qecewik/edit?html,output) (Calcite with ArcGIS JSAPI). You can also make your own sample using one of the those websites. Alternatively, a [documentation sample](https://developers.arcgis.com/calcite-design-system/components) can be used if the issue is reproducible. If you are experiencing build or Node related errors, please provide a GitHub repo for the sample.
     validations:
       required: true
   - type: textarea
@@ -78,11 +78,10 @@ body:
       multiple: false
       description: What is the impact to you, your team, or organization? Use discretion and only select "need" or "emergency" priorities for high user impact and quality issues. For instance, would someone notice, in a bad way, if this issue were present in the release?
       options:
-        - p4 - not time sensitive
-        - p3 - want for upcoming milestone
-        - p2 - want for current milestone
-        - p1 - need for current milestone
-        - p0 - emergency
+        - impact - p3 - not time sensitive
+        - impact - p2 - want for an upcoming milestone
+        - impact - p1 - need for current milestone
+        - impact - p0 - emergency
   - type: textarea
     id: impact
     attributes:
@@ -94,7 +93,7 @@ body:
     id: packages
     attributes:
       label: Calcite package
-      description: Select the relevant [package(s)](https://github.com/Esri/calcite-design-system/tree/main/packages) related to the request.
+      description: Select the relevant [package(s)](https://github.com/Esri/calcite-design-system/tree/dev/packages) related to the request.
       options:
         - label: "@esri/calcite-components"
         - label: "@esri/calcite-components-angular"
@@ -113,6 +112,7 @@ body:
       description: If you work at Esri, please select your product team. Otherwise choose "N/A". If your team is not listed, choose "N/A", and then edit the line after submitting the issue.
       options:
         - N/A
+        - Application Protoype Lab - APL
         - ArcGIS Solutions
         - ArcGIS AppStudio
         - ArcGIS Business/Community Analyst

.github/ISSUE_TEMPLATE/enhancement.yml

@@ -54,15 +54,15 @@ body:
       multiple: false
       description: What is the impact of the enhancement to you, your team, or organization? Use discretion and only select the "need" priority for high user impact and quality issues in the component(s).
       options:
-        - p4 - not time sensitive
-        - p3 - want for upcoming milestone
-        - p2 - want for current milestone
-        - p1 - need for current milestone
+        - impact - p3 - not time sensitive
+        - impact - p2 - want for an upcoming milestone
+        - impact - p1 - need for current milestone
+        - impact - p0 - emergency
   - type: checkboxes
     id: packages
     attributes:
       label: Calcite package
-      description: Select the relevant [package(s)](https://github.com/Esri/calcite-design-system/tree/main/packages) related to the request.
+      description: Select the relevant [package(s)](https://github.com/Esri/calcite-design-system/tree/dev/packages) related to the request.
       options:
         - label: "@esri/calcite-components"
         - label: "@esri/calcite-components-angular"
@@ -81,6 +81,7 @@ body:
       description: If you work at Esri, please select your product team. Otherwise choose "N/A". If your team is not listed, choose "N/A", and then edit the line after submitting the issue.
       options:
         - N/A
+        - Application Protoype Lab - APL
         - ArcGIS Solutions
         - ArcGIS AppStudio
         - ArcGIS Business/Community Analyst

.github/ISSUE_TEMPLATE/new-component.yml

@@ -51,10 +51,10 @@ body:
       multiple: false
       description: How important is the new component request to you, your team, or organization? Use discretion and only select the "need" priority for high user impact.
       options:
-        - p4 - not time sensitive
-        - p3 - want for upcoming milestone
-        - p2 - want for current milestone
-        - p1 - need for current milestone
+        - impact - p3 - not time sensitive
+        - impact - p2 - want for an upcoming milestone
+        - impact - p1 - need for current milestone
+        - impact - p0 - emergency
   - type: dropdown
     id: esri-team
     validations:
@@ -65,6 +65,7 @@ body:
       description: If you work at Esri, please select your product team. Otherwise choose "N/A". If your team is not listed, choose "N/A", and then edit the line after submitting the issue.
       options:
         - N/A
+        - Application Protoype Lab - APL
         - ArcGIS Solutions
         - ArcGIS AppStudio
         - ArcGIS Business/Community Analyst

.github/ISSUE_TEMPLATE/refactor.yml

@@ -38,7 +38,7 @@ body:
     id: packages
     attributes:
       label: Calcite package
-      description: Select the relevant [package(s)](https://github.com/Esri/calcite-design-system/tree/main/packages) related to the request.
+      description: Select the relevant [package(s)](https://github.com/Esri/calcite-design-system/tree/dev/packages) related to the request.
       options:
         - label: "@esri/calcite-components"
         - label: "@esri/calcite-components-angular"

.github/ISSUE_TEMPLATE/test.yml

@@ -1,12 +1,24 @@
 name: Test
 description: Associate issue for a test (e.g., a new test, an unstable test that was skipped, Chromatic, etc.)
-labels: ["testing", "0 - new", "p - high", "needs milestone"]
+labels: ["testing", "0 - new", "needs milestone"]
 body:
   - type: markdown
     attributes:
       value: |
         - Please [check for existing issues](https://github.com/Esri/calcite-design-system/issues) to avoid duplicates. If someone has already opened an issue for what you are experiencing, please add a 👍 reaction to the existing issue instead of creating a new one.
         - For support, please check the [community forum](https://developers.arcgis.com/calcite-design-system/community/).
+  - type: dropdown
+    id: priority-impact
+    validations:
+      required: true
+    attributes:
+      label: Priority impact
+      multiple: false
+      description: What is the impact of the test? If the test is unstable, the priority may be high, where a new test may have a medium priority.
+      options:
+        - p - high
+        - p - medium
+        - p - low
   - type: input
     id: type
     attributes:

.github/ISSUE_TEMPLATE/tooling.yml

@@ -7,6 +7,18 @@ body:
       value: |
         - Please [check for existing issues](https://github.com/Esri/calcite-design-system/issues) to avoid duplicates. If someone has already opened an issue for what you are experiencing, please add a 👍 reaction to the existing issue instead of creating a new one.
         - For support, please check the [community forum](https://developers.arcgis.com/calcite-design-system/community/).
+  - type: dropdown
+    id: priority-impact
+    validations:
+      required: true
+    attributes:
+      label: Priority impact
+      multiple: false
+      description: What is the impact of the requested improvement? If the need is blocking release, the priority may be high, where a new improvement may have a low or medium priority.
+      options:
+        - p - low
+        - p - medium
+        - p - high
   - type: textarea
     id: summary
     attributes:

.github/scripts/addCalcitePackageLabel.js

@@ -1,10 +1,14 @@
+// @ts-check
+const { createLabelIfMissing } = require("./support/utils");
+
+/** @param {import('github-script').AsyncFunctionArguments} AsyncFunctionArguments */
 module.exports = async ({ github, context }) => {
+  const { repo, owner } = context.repo;
+
+  const payload = /** @type {import('@octokit/webhooks-types').IssuesEvent} */ (context.payload);
   const {
-    repo: { owner, repo },
-    payload: {
-      issue: { body, number: issue_number },
-    },
-  } = context;
+    issue: { body, number: issue_number },
+  } = payload;
 
   if (!body) {
     console.log("could not determine the issue body");
@@ -16,24 +20,14 @@ module.exports = async ({ github, context }) => {
   const packages = body.match(packageRegex) || [];
 
   for (const package of packages) {
-    /** Creates a label if it does not exist */
-    try {
-      await github.rest.issues.getLabel({
-        owner,
-        repo,
-        name: package,
-      });
-    } catch (e) {
-      await github.rest.issues.createLabel({
-        owner,
-        repo,
-        name: package,
-        color: "BFBEAF",
-        description: `Issues specific to the @esri/${package} package.`,
-      });
-    }
+    await createLabelIfMissing({
+      github,
+      context,
+      label: package,
+      color: "BFBEAF",
+      description: `Issues specific to the @esri/${package} package.`,
+    });
 
-    /** add new package label */
     await github.rest.issues.addLabels({
       issue_number,
       owner,

.github/scripts/addEsriProductLabel.js

@@ -1,11 +1,15 @@
+// @ts-check
+const { createLabelIfMissing } = require("./support/utils");
+
+/** @param {import('github-script').AsyncFunctionArguments} AsyncFunctionArguments */
 module.exports = async ({ github, context }) => {
+  const { repo, owner } = context.repo;
+
+  const payload = /** @type {import('@octokit/webhooks-types').IssuesEvent} */ (context.payload);
   const {
-    repo: { owner, repo },
-    payload: {
-      action,
-      issue: { body, number: issue_number },
-    },
-  } = context;
+    action,
+    issue: { body, number: issue_number },
+  } = payload;
 
   if (!body) {
     console.log("could not determine the issue body");
@@ -19,37 +23,32 @@ module.exports = async ({ github, context }) => {
         "(?<=### Esri team\r\n\r\n).+"
       : // otherwise it depends on the submitter's OS
         "(?<=### Esri team[\r\n|\r|\n]{2}).+$",
-    "m"
+    "m",
   );
 
   const productRegexMatch = body.match(productRegex);
 
-  const product = (productRegexMatch && productRegexMatch[0] ? productRegexMatch[0] : "").trim();
+  // If issue includes "Esri team" line then create label, otherwise log message.
+  if (productRegexMatch) {
+    const product = (productRegexMatch && productRegexMatch[0] ? productRegexMatch[0] : "").trim();
 
-  if (product && product !== "N/A") {
-    /** Creates a label if it does not exist */
-    try {
-      await github.rest.issues.getLabel({
-        owner,
-        repo,
-        name: product,
+    if (product !== "N/A") {
+      await createLabelIfMissing({
+        github,
+        context,
+        label: product,
+        color: "006B75",
+        description: `Issues logged by ${product} team members.`,
       });
-    } catch (e) {
-      await github.rest.issues.createLabel({
+
+      await github.rest.issues.addLabels({
+        issue_number,
         owner,
         repo,
-        name: product,
-        color: "006B75",
-        description: `Issues logged by ${product} team members.`,
+        labels: [product],
       });
     }
-
-    /** add new product label */
-    await github.rest.issues.addLabels({
-      issue_number,
-      owner,
-      repo,
-      labels: [product],
-    });
+  } else {
+    console.log(`No Esri team listed on issue #${issue_number}`);
   }
 };

.github/scripts/addPriorityLabel.js

@@ -1,11 +1,15 @@
+// @ts-check
+const { createLabelIfMissing } = require("./support/utils");
+
+/** @param {import('github-script').AsyncFunctionArguments} AsyncFunctionArguments */
 module.exports = async ({ github, context }) => {
+  const { repo, owner } = context.repo;
+
+  const payload = /** @type {import('@octokit/webhooks-types').IssuesEvent} */ (context.payload);
   const {
-    repo: { owner, repo },
-    payload: {
-      action,
-      issue: { body, number: issue_number },
-    },
-  } = context;
+    action,
+    issue: { body, number: issue_number },
+  } = payload;
 
   if (!body) {
     console.log("could not determine the issue body");
@@ -19,32 +23,22 @@ module.exports = async ({ github, context }) => {
         "(?<=### Priority impact\r\n\r\n).+"
       : // otherwise it depends on the submitter's OS
         "(?<=### Priority impact[\r\n|\r|\n]{2}).+$",
-    "m"
+    "m",
   );
 
   const addPriorityRegexMatch = body.match(addPriorityRegex);
 
   const addPriorityLabel = (addPriorityRegexMatch && addPriorityRegexMatch[0] ? addPriorityRegexMatch[0] : "").trim();
 
   if (addPriorityLabel && addPriorityLabel !== "N/A") {
-    /** Creates a label if it does not exist */
-    try {
-      await github.rest.issues.getLabel({
-        owner,
-        repo,
-        name: addPriorityLabel,
-      });
-    } catch (error) {
-      await github.rest.issues.createLabel({
-        owner,
-        repo,
-        name: addPriorityLabel,
-        color: "bb7fe0",
-        description: `User set priority status of ${addPriorityLabel}`,
-      });
-    }
-
-    /** add new priority label */
+    await createLabelIfMissing({
+      github,
+      context,
+      label: addPriorityLabel,
+      color: "bb7fe0",
+      description: `User set priority status of ${addPriorityLabel}`,
+    });
+
     await github.rest.issues.addLabels({
       issue_number,
       owner,