Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

components: refactor aria-attributes to properly set values #10407

Closed
1 of 5 tasks
driskull opened this issue Sep 26, 2024 · 2 comments
Closed
1 of 5 tasks

components: refactor aria-attributes to properly set values #10407

driskull opened this issue Sep 26, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Milestone
2024-09-30 - 2.13...

Comments

@driskull
Copy link
Member

Description

  • only sets aria-expanded on button when present on host
  • properly sets boolean values to strings on other components
  • removes aria-hidden from screen reader text

Proposed Advantages

accessibility

Which Component

all applicable

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@driskull driskull added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 26, 2024
@driskull driskull mentioned this issue Sep 26, 2024
Merged
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Sep 26, 2024
driskull added a commit that referenced this issue Sep 26, 2024
@driskull
fix: properly set aria attributes on components (#10404)
864f3e3 
**Related Issue:** #10407

## Summary

- only sets `aria-expanded` on button when present on host
- properly sets `boolean` values to strings on other components 
- removes `aria-hidden` from screen reader text
@driskull driskull self-assigned this Sep 26, 2024
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Sep 26, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Sep 26, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Sep 27, 2024

🍠 Verified locally on dev

@DitwanP DitwanP closed this as completed Sep 27, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2024-09-30 - 2.13.0 Sep Main release
Development

No branches or pull requests
3 participants
@driskull @geospatialem @DitwanP