Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESLint] Remove ban-props-on-host, enforce-ref-last-prop, require-event-emitter-type rules #10398

Closed
maxpatiiuk opened this issue Sep 26, 2024 · 5 comments
Closed

[ESLint] Remove ban-props-on-host, enforce-ref-last-prop, require-event-emitter-type rules #10398

maxpatiiuk opened this issue Sep 26, 2024 · 5 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.
Milestone
2024-11-26 - 3.0....

Comments

@maxpatiiuk
Copy link
Member

maxpatiiuk commented Sep 26, 2024 •
edited by jcfranco
Loading

Priority impact

p - low

Summary

Calcite developed an enforce-ref-last-prop ESLint rule.
Such rule is not necessary in Lumina - the JSX ref prop is moved to be the last prop at build time, thus the sort order in the component code does not matter.

Update: Also remove ban-props-on-host and require-event-emitter-type rules as they will no longer be needed.

Desired Outcome

After migrating to Lumina, remove the ban-props-on-host, enforce-ref-last-prop and require-event-emitter-type ESLint rules

Resources

No response
@maxpatiiuk maxpatiiuk added tooling Issues relating to build system fixes or improvements. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 26, 2024
@github-actions github-actions bot added the p - low Issue is non core or affecting less that 10% of people using the library label Sep 26, 2024
@jcfranco
Copy link
Member

We can deprecate and remove this in 3.x since https://github.com/Esri/calcite-design-system/pull/9086/files disabled the rule for components.

@jcfranco jcfranco changed the title [ESLint] Disable enforce-ref-last-prop after migration [ESLint] Remove enforce-ref-last-prop Sep 27, 2024
@jcfranco jcfranco added this to the 2024-10-29 - Oct Milestone milestone Sep 27, 2024
@jcfranco jcfranco self-assigned this Sep 27, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 27, 2024
@jcfranco jcfranco mentioned this issue Sep 27, 2024
Merged
jcfranco added a commit that referenced this issue Sep 27, 2024
@jcfranco
deprecate: deprecate enforce-ref-last-prop rule (#10421)
5fde52d 
**Related Issue:** #10398

## Summary

Deprecates this rule for 3.x removal as it is no longer needed after
Stencil 4.14.1 and will be even more obsolete after #10310.
@jcfranco
Copy link
Member

@geospatialem @DitwanP How do you suggest we proceed with this issue? We're deprecating now, but removing in 3.x.

@jcfranco jcfranco changed the title [ESLint] Remove enforce-ref-last-prop [ESLint] Remove enforce-ref-last-prop, require-event-emitter-type Oct 28, 2024
@jcfranco jcfranco changed the title [ESLint] Remove enforce-ref-last-prop, require-event-emitter-type [ESLint] Remove enforce-ref-last-prop, require-event-emitter-type rules Oct 28, 2024
@jcfranco jcfranco mentioned this issue Oct 28, 2024
Merged
jcfranco added a commit that referenced this issue Oct 28, 2024
@jcfranco
deprecate: deprecate require-event-emitter-type rule (#10638)
2eb7409 
**Related Issue:** #10398

## Summary

Deprecates this rule for 3.x removal as it is no longer needed after
#10310.
@jcfranco jcfranco changed the title [ESLint] Remove enforce-ref-last-prop, require-event-emitter-type rules [ESLint] Remove ban-props-on-host, enforce-ref-last-prop, require-event-emitter-type rules Oct 29, 2024
This was referenced Oct 29, 2024
Merged
Merged
jcfranco added a commit that referenced this issue Oct 29, 2024
@jcfranco
deprecate: deprecate ban-props-on-host rule (#10642)
cb04913 
**Related Issue:** #10398

## Summary

Deprecates this rule for 3.x removal as it is no longer needed after
#10310.
@jcfranco jcfranco mentioned this issue Nov 4, 2024
Merged
jcfranco added a commit that referenced this issue Nov 4, 2024
@jcfranco
refactor!: remove deprecated ban-props-on-host, `enforce-ref-last-p…
c399c10 
…rop`, `require-event-emitter-type` rules (#10679)

**Related Issue:** #10398

## Summary

Remove deprecated custom ESLint rules.

BREAKING CHANGE: The following deprecated rules from
`@esri/eslint-plugin-calcite-components` have been removed due to
changes introduced in #10310:

* `ban-props-on-host`
* `enforce-ref-last-prop`
* `require-event-emitter-type`

Developers should either remain on the current version or remove these
rules from their ESLint configuration to avoid potential issues.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Nov 4, 2024
@geospatialem
Copy link
Member

Verified removals on the dev branch. 🧹

Reassigning the issue back to development to remove the remaining markdown files 🔜 :

@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 6, 2024
@geospatialem geospatialem mentioned this issue Nov 6, 2024
Closed
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 2 - in development Issues that are actively being worked on. labels Nov 7, 2024
@geospatialem
Copy link
Member

Verified removals on the dev branch. 🧹

Reassigning the issue back to development to remove the remaining markdown files 🔜 :

Verified - the remaining files will be removed in #10482. Refer to Franco's comment for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @maxpatiiuk @DitwanP