Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input-time-picker: left-hand field initially displays number instead of am/pm when am/pm precedes time for locales with 12 hr time period #4957

Closed
annierm18 opened this issue Jul 18, 2022 · 3 comments
Closed

Input-time-picker: left-hand field initially displays number instead of am/pm when am/pm precedes time for locales with 12 hr time period #4957

annierm18 opened this issue Jul 18, 2022 · 3 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. i18n-l10n issues dealing with internationalization/localization
Milestone
Sprint 2022/08/22...

Comments

@annierm18
Copy link
Contributor

annierm18 commented Jul 18, 2022 •
edited
Loading

Actual Behavior

After completing step 4 in the repro steps, the user will see a number.
Screenshot (94)

However, after step 5, the left field changes to am/pm (translated) and the number shifts to the right.
Screenshot (95)

Expected Behavior

Every time (including the first time) I click the up/down arrows for the left-hand field of the input-time-picker component, I expect that the correct data should appear i.e.

  • a number appears for locales where the formatting is time followed by am/pm OR
  • am/pm (translated) for locales where am/pm precedes the time.

Reproduction Sample

https://jsbin.com/wapobulexo/edit?html,output

Reproduction Steps

Note: So far, my testing has not been impacted by locale set by operating system

  1. Change the browser locale to a locale that has 12 hour time period and its am/pm text precede the time, e.g. Korean or Arabic (Ar)
  2. Navigate to https://developers.arcgis.com/calcite-design-system/components/input-time-picker/
  3. Click the input-time-picker
  4. Use the up/down arrows on the left-most field
  5. Use the up/down arrows in the middle or right field

Reproduction Version

v1.0.0-beta.83

Relevant Info

Reproduced on Chrome and Firefox
Windows10 OS

Regression?

No response
@annierm18 annierm18 added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. i18n-l10n issues dealing with internationalization/localization labels Jul 18, 2022
@jcfranco
Copy link
Member

jcfranco commented Aug 3, 2022

Related issue: #4893

@benelan benelan added this to the Sprint 2022/08/08 - 2022/08/19 milestone Aug 3, 2022
@benelan benelan added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 3, 2022
@benelan benelan self-assigned this Aug 3, 2022
@benelan benelan added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 30, 2022
@benelan benelan mentioned this issue Aug 30, 2022
Merged
benelan added a commit that referenced this issue Aug 30, 2022
@benelan
fix(time-picker, input-time-picker): initialize meridiem at the start…
4207654 
… of the time for rtl locales (#5246)

**Related Issue:** #4957 

## Summary
Makes sure the meridiem location is determined on load.

<!--

Please make sure the PR title and/or commit message adheres to the https://www.conventionalcommits.org/en/v1.0.0/ specification.

Note: If your PR only has one commit and it is NOT semantic, you will need to either

a. add another commit and wait for the check to update
b. proceed to squash merge, but make sure the commit message is the same as the title.

This is because of the way GitHub handles single-commit squash merges (see zeke/semantic-pull-requests#17)

If this is component-related, please verify that:

- [ ] feature or fix has a corresponding test
- [ ] changes have been tested with demo page in Edge

---

If this is skipping an unstable test:

- include info about the test failure
- submit an unstable-test issue by [choosing](https://github.com/Esri/calcite-components/issues/new/choose) the unstable test template and filling it out

-->
@benelan benelan added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Aug 30, 2022
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@benelan benelan removed their assignment Aug 30, 2022
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 8, 2022
@geospatialem
Copy link
Member

Verified on next.

verify-time-picker-locale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. i18n-l10n issues dealing with internationalization/localization
Projects
None yet
Milestone
Sprint 2022/08/22 - 2022/09/02
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @benelan @annierm18