Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(time-picker, input-time-picker): initialize meridiem at the start of the time for rtl locales #5246

Merged
merged 1 commit into from
Aug 30, 2022
Merged

fix(time-picker, input-time-picker): initialize meridiem at the start of the time for rtl locales #5246

merged 1 commit into from
Aug 30, 2022

Conversation

benelan
Copy link
Member

@benelan benelan commented Aug 30, 2022

Related Issue: #4957

Summary

Makes sure the meridiem location is determined on load.

@benelan benelan requested a review from a team as a code owner August 30, 2022 21:20
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Aug 30, 2022
driskull
driskull approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@benelan benelan merged commit 4207654 into master Aug 30, 2022
@benelan benelan deleted the benelan/4957-meridiem-location branch August 30, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@benelan benelan

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Milestone
Sprint 2022/08/22 - 2022/09/02
Development

Successfully merging this pull request may close these issues.
2 participants
@benelan @driskull