Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Filter Control Label - Provide a valid label for form fields - (2036570437) #5626

Closed
Tracked by #4599
dqateam opened this issue Oct 25, 2022 · 6 comments
Closed
Tracked by #4599
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 2 Small fix or update, may require updates to tests. low risk Issues with low risk for consideration in low risk milestones p - high Issue should be addressed in the current milestone, impacts component or core functionality

Comments

@dqateam
Copy link
Collaborator

dqateam commented Oct 25, 2022

Module:

39 Value List and Value List Item
List and List Item

Violation:

Provide a valid label for the component's filter list item

image

WCAG Reference:

Instance ID:

2036570437

Severity:

10

Description:

[Issue]
There is filter form control in the "Test 2. Value List with Filter" section without a programmatically associated label describing their purpose.

[User Impact]
Screen reader users and users with cognitive disabilities may be unable to determine what these controls are for. Speech input users will have difficulty navigating to them.

[Code Reference]

<input aria-label="" class="" enterkeyhint="" inputmode="" placeholder="Filter list items" type="text">

Note:

[Suggestion]
Provide a valid label for form fields. Provide aria-label attributes in the <input> elements.

[Compliant Code Example]

<input aria-label="Filter list items" class="" enterkeyhint="" inputmode="" placeholder="Filter list items" type="text">

Media Type:

Forms

Additional Resources:

  • Report Source: Product accessibility evaluation conducted on the Calcite Design System in August, 2022.
@dqateam dqateam added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Oct 25, 2022
@geospatialem geospatialem changed the title Value List and Value List Item - Provide a valid label for form fields - (2036570437) Value List Filter Control Label - Provide a valid label for form fields - (2036570437) Nov 17, 2022
@driskull
Copy link
Member

This one would apply to list component as well.

@geospatialem geospatialem added the p - low Issue is non core or affecting less that 10% of people using the library label Nov 22, 2022
@geospatialem geospatialem added this to the Freezer milestone Nov 22, 2022
@geospatialem geospatialem changed the title Value List Filter Control Label - Provide a valid label for form fields - (2036570437) List Filter Control Label - Provide a valid label for form fields - (2036570437) Aug 10, 2023
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 2 Small fix or update, may require updates to tests. and removed p - low Issue is non core or affecting less that 10% of people using the library labels Aug 10, 2023
@geospatialem
Copy link
Member

Updated to apply to the list component

@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Aug 10, 2023
@brittneytewks brittneytewks added the low risk Issues with low risk for consideration in low risk milestones label Sep 21, 2023
@driskull
Copy link
Member

The fix should be to change from using aria-label to label within the calcite-filter component.

In the future, we could add a filterLabel property to specifically configure the list filter label.

@geospatialem
Copy link
Member

For now it seems like its mostly covered in JAWS and NVDA. To @driskull's point above, we could add a new prop and in addition, have a fallback on a built-in translation, something like "Filter list items". Going to up the estimate and move to a future milestone to tackle. cc @brittneytewks

@driskull driskull added the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Oct 27, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 0 - new New issues that need assignment. 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 27, 2023
@geospatialem
Copy link
Member

Verified locally with JAWS and NVDA (refer to context in the PR here).

Created #8076 for the property for additional context in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 2 Small fix or update, may require updates to tests. low risk Issues with low risk for consideration in low risk milestones p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Development

No branches or pull requests

5 participants