Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filter] Add filterLabel property #8076

Closed
2 of 5 tasks
geospatialem opened this issue Oct 27, 2023 · 2 comments
Closed
2 of 5 tasks

[Filter] Add filterLabel property #8076

geospatialem opened this issue Oct 27, 2023 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone low risk Issues with low risk for consideration in low risk milestones p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-12-17 - Dec ...

Comments

@geospatialem
Copy link
Member

Check existing issues

Description

Add a new filterLabel property for users to supply their own filter label applicable to their use case.

Currently the filter provides not-so-great context via JAWS and NVDA:

JAWS:

Filter �tree view item�

NVDA:

Filter edit blank

Acceptance Criteria

A new filterLabel, or similar property

Relevant Info

Was referred to in #5626 (comment)

Which Component

Filter

Example Use Case

refer to description above

Priority impact

p3 - want for upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@geospatialem geospatialem added enhancement Issues tied to a new feature or request. a11y Issues related to Accessibility fixes or improvements. 0 - new New issues that need assignment. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. low risk Issues with low risk for consideration in low risk milestones labels Oct 27, 2023
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. p3 - want for upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. labels Oct 27, 2023
@geospatialem geospatialem mentioned this issue Oct 27, 2023
Closed
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Nov 22, 2023
@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
@driskull driskull self-assigned this Dec 6, 2024
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Dec 6, 2024
driskull added a commit that referenced this issue Dec 6, 2024
@driskull
feat(filter): add label property. #8076
ef9b725
@driskull driskull mentioned this issue Dec 6, 2024
Merged
driskull added a commit that referenced this issue Dec 6, 2024
@driskull
feat(list): add filterLabel property. #8076
96f7359
@driskull driskull mentioned this issue Dec 6, 2024
Merged
driskull added a commit that referenced this issue Dec 6, 2024
@driskull
feat(filter): add label property (#11001)
ab20b8e 
**Related Issue:** #8076

## Summary

- add label prop to filter
- add test
driskull added a commit that referenced this issue Dec 9, 2024
@driskull
feat(list): add filterLabel property (#11002)
49c6093 
**Related Issue:** #8076

## Summary

- add `filterLabel` property to the list
- add test
- depends on #11001
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 10, 2024
@geospatialem
Copy link
Member Author

Verified with JAWS and NVDA in 3.0.0-next.53 with the new filter-label attribute (filterLabel prop) in this sample: https://codepen.io/geospatialem/pen/MYgexbN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone low risk Issues with low risk for consideration in low risk milestones p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

No branches or pull requests
3 participants
@driskull @geospatialem @DitwanP