Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(filter): add label property #11001

Merged
merged 2 commits into from
Dec 6, 2024
Merged

feat(filter): add label property #11001

merged 2 commits into from
Dec 6, 2024

Conversation

driskull
Copy link
Member

@driskull driskull commented Dec 6, 2024

Related Issue: #8076

Summary

  • add label prop to filter
  • add test

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Dec 6, 2024
@driskull driskull marked this pull request as ready for review December 6, 2024 19:34
geospatialem
geospatialem approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@geospatialem geospatialem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🏆

packages/calcite-components/src/components/filter/filter.e2e.ts Outdated
@@ -67,6 +67,15 @@ describe("calcite-filter", () => {
expect(await input.getProperty("scale")).toBe(scale);
});

it("honors label property", async () => {
const page = await newE2EPage();
const label = "hell world";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😨! Did you mean to type hello 👋🏻?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops lol

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@driskull driskull mentioned this pull request Dec 6, 2024
Merged
@driskull driskull added the skip visual snapshots Pull requests that do not need visual regression testing. label Dec 6, 2024
benelan
benelan approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@driskull driskull merged commit ab20b8e into dev Dec 6, 2024
13 checks passed
@driskull driskull deleted the dris0000/filter-label-property branch December 6, 2024 23:44
@github-actions github-actions bot added this to the 2024-12-17 - Dec Milestone milestone Dec 6, 2024
driskull added a commit that referenced this pull request Dec 9, 2024
@driskull
feat(list): add filterLabel property (#11002)
49c6093 
**Related Issue:** #8076

## Summary

- add `filterLabel` property to the list
- add test
- depends on #11001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

@geospatialem geospatialem geospatialem approved these changes

@jcfranco jcfranco Awaiting requested review from jcfranco

@eriklharper eriklharper Awaiting requested review from eriklharper

@anveshmekala anveshmekala Awaiting requested review from anveshmekala

Assignees

@driskull driskull

Labels
enhancement Issues tied to a new feature or request. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@driskull @eriklharper @geospatialem @benelan