Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Action Bar] Deprecated "bottom-actions" slot doesn't work #7534

Closed
2 of 3 tasks
macandcheese opened this issue Aug 16, 2023 · 2 comments
Closed
2 of 3 tasks

[Action Bar] Deprecated "bottom-actions" slot doesn't work #7534

macandcheese opened this issue Aug 16, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
1.6.1 Maintenance...

Comments

@macandcheese
Copy link
Contributor

Check existing issues

Actual Behavior

We recently added "actions-end" slot to Action Bar, and deprecated "bottom-actions". But when using "bottom-actions" - the component does not render slot contents.

Expected Behavior

I'd expect the deprecated slot to still render.

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/VwqZjbB?editors=1000

Reproduction Steps

  1. Go to Codepen
  2. View "bottom-actions" slot in HTML
  3. Change to "actions-end"
  4. See slotted contents appear

Reproduction Version

1.6.0

Relevant Info

No response

Regression?

No response

Priority impact

p2 - want for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

Calcite (dev)
@macandcheese macandcheese added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 16, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. Calcite (dev) Issues logged by Calcite developers. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Aug 16, 2023
@macandcheese macandcheese added the breaking change Issues and pull requests with code changes that are not backwards compatible. label Aug 16, 2023
@jcfranco jcfranco added regression Issues that are caused by changes in a release, but were working before that. and removed breaking change Issues and pull requests with code changes that are not backwards compatible. labels Aug 16, 2023
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. p - high Issue should be addressed in the current milestone, impacts component or core functionality and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 16, 2023
@jcfranco jcfranco added this to the 2023 August Priorities milestone Aug 16, 2023
driskull added a commit that referenced this issue Aug 16, 2023
@driskull
fix(action-bar): restore "bottom-actions" slot functionality. #7534
404b472
@driskull driskull mentioned this issue Aug 16, 2023
Merged
driskull added a commit that referenced this issue Aug 16, 2023
@driskull
fix(action-bar): restore "bottom-actions" slot functionality. (#7535)
3aa9afa 
**Related Issue:** #7534

## Summary

- Fix incorrect resources slot value
- Separate state from different slots so they aren't' competing with
each other.
- Add tests
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 16, 2023
@github-actions github-actions bot assigned geospatialem and unassigned driskull Aug 16, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 18, 2023
@geospatialem
Copy link
Member

Verified in 1.6.1-next.2 with the "bottom-actions" and "actions-end" slots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
1.6.1 Maintenance Release
Development

No branches or pull requests
4 participants
@jcfranco @driskull @macandcheese @geospatialem