Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action-bar): restore "bottom-actions" slot functionality. #7535

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

driskull
Copy link
Member

@driskull driskull commented Aug 16, 2023

Related Issue: #7534

Summary

  • Fix incorrect resources slot value
  • Separate state from different slots so they aren't' competing with each other.
  • Add tests

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Aug 16, 2023
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Aug 16, 2023
@driskull driskull marked this pull request as ready for review August 16, 2023 17:58
@driskull driskull requested a review from a team as a code owner August 16, 2023 17:58
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨🔧✨

@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Aug 16, 2023
@driskull driskull merged commit 3aa9afa into main Aug 16, 2023
@driskull driskull deleted the dris0000/action-bar-fix-slot-value branch August 16, 2023 19:07
@github-actions github-actions bot added this to the 2023 August Priorities milestone Aug 16, 2023
benelan added a commit that referenced this pull request Aug 17, 2023
* origin/main:
  chore: release next
  chore: add `directory` to package.json `repository` property (#7510)
  fix(action-bar): restore "bottom-actions" slot functionality. (#7535)
  refactor(action-bar, action-pad, action-group): Remove usage of getSlotted utility (#7464)
  build(deps): update dependency lerna to v7.1.5 (#7502)
  build(deps): update dependency @esri/calcite-ui-icons to v3.23.7 (#7522)
  refactor(shell-panel): Remove usage of getSlotted utility. #6059 (#7465)
  build(deps): update dependency eslint-plugin-unicorn to v46.0.1 (#7501)
  build(deps): replace dependency rollup-plugin-node-resolve with @rollup/plugin-node-resolve 6.0.0 (#7481)
  test: skip unstable tests (#7524)
  build(deps): update dependency lint-staged to v13.2.3 (#7523)
  build(deps): update dependency @types/estree to v1.0.1 (#7483)
  build(deps): update dependency eslint-plugin-react to v7.33.1 (#7500)
  build(deps): update dependency eslint-plugin-jsdoc to v46.4.6 (#7499)
  build(deps): update dependency @types/node to v20.4.10 (#7484)
  chore: release next
  chore: release main (#7485)
benelan pushed a commit that referenced this pull request Aug 18, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 1.6.1</summary>

##
[1.6.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@1.6.0...@esri/calcite-components@1.6.1)
(2023-08-18)


### Bug Fixes

* **action-bar:** Restore "bottom-actions" slot functionality.
([#7535](#7535))
([3aa9afa](3aa9afa))
* Fix open/close event emitting in Safari
([#7551](#7551))
([a68b053](a68b053))
</details>

<details><summary>@esri/calcite-components-react: 1.6.1</summary>

##
[1.6.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@1.6.0...@esri/calcite-components-react@1.6.1)
(2023-08-18)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize undefined versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^1.6.1-next.2 to ^1.6.1
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants