fix: fix open/close event emitting in Safari #7551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
benelan
approved these changes
Aug 18, 2023
jcfranco
added
the
pr ready for visual snapshots
jcfranco
added
pr ready for visual snapshots
jcfranco
deleted the
jcfranco/7549-fix-open-close-timing-issue-affecting-safari
branch
Merged
benelan
pushed a commit
that referenced
this pull request
Aug 18, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 1.6.1</summary> ## [1.6.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@1.6.0...@esri/calcite-components@1.6.1) (2023-08-18) ### Bug Fixes * **action-bar:** Restore "bottom-actions" slot functionality. ([#7535](#7535)) ([3aa9afa](3aa9afa)) * Fix open/close event emitting in Safari ([#7551](#7551)) ([a68b053](a68b053)) </details> <details><summary>@esri/calcite-components-react: 1.6.1</summary> ## [1.6.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@1.6.0...@esri/calcite-components-react@1.6.1) (2023-08-18) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^1.6.1-next.2 to ^1.6.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
benelan
added a commit
that referenced
this pull request
Aug 21, 2023
* origin/main: build(deps): update dependency autoprefixer to v10.4.15 (#7543) build(deps): update dependency postcss to v8.4.28 (#7544) chore: release main (#7539) chore: release next fix: fix open/close event emitting in Safari (#7551) chore(linting): set up spelling linting (#7389) chore(linting): enable one-var rule (#7528)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7549
Summary
This updates how
onToggleOpenCloseComponentdetermines the duration for theopenTransitionPropto be more robust to work consistently across browsers.The previous approach relied on the computed
transitionproperty having all associated transition values laid out per prop, which didn't work in Safari since it won't include all values if shared.This change should be covered by existing tests.
cc @Elijbet