Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List: <Enter> keypress behavior within list-items #7676

Closed
2 of 3 tasks
jrowlingson opened this issue Sep 5, 2023 · 2 comments
Closed
2 of 3 tasks

List: <Enter> keypress behavior within list-items #7676

jrowlingson opened this issue Sep 5, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
1.8.0 Maintenance...

Comments

@jrowlingson
Copy link
Contributor

jrowlingson commented Sep 5, 2023 •
edited
Loading

Check existing issues

Summary

I'm unsure if this is the intended behavior for <calcite-list-item>, but a cursory look through the issues did not yield anything similar.

I see that an <Enter> keypress will open the href=... of both a <calcite-link> and <calcite-button> (ex. 1,2), however, when these are slotted into actions-end of <calcite-list-item> this no longer works (ex. 3,4). Given the naming of the slot, I am assuming a <calcite-action> is expected here, however, this too seems to produce a similar behavior (ex. 6). Note, onKeydown does work for a slotted <calcite-action>.

Actual Behavior

  1. Focus a actions-end slotted <calcite-link href=...>, <calcite-button href=...> (ex. 3,4), or <calcite-action onClick=...> (ex. 6).
  2. Press <Enter>
  3. The browser navigates to the href if its an anchor, or calls the onClick handler if its an action.

Expected Behavior

  1. Focus a actions-end slotted <calcite-link href=...>, <calcite-button href=...> (ex. 3,4), or <calcite-action onClick=...> (ex. 6).
  2. Press <Enter>
  3. The browser does not navigate to the href if its an anchor, or call the onClick handler if its an action.

Reproduction Sample

https://codepen.io/jrowls/pen/OJrbRqj?editors=1000

Reproduction Steps

See codepen sample

Reproduction Version

1.7.0

Working W3C Example/Tutorial

No response

Relevant Info

Firefox 117.0

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

ArcGIS Field Apps
@jrowlingson jrowlingson added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. a11y Issues related to Accessibility fixes or improvements. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 5, 2023
@github-actions github-actions bot added ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. p3 - want for upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. labels Sep 5, 2023
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. and removed p - high Issue should be addressed in the current milestone, impacts component or core functionality labels Sep 5, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Sep 5, 2023
driskull added a commit that referenced this issue Sep 6, 2023
@driskull
fix(list-item): Do not call preventDefault on enter key within slotte…
e864ef6 
…d actions. #7676
@driskull driskull mentioned this issue Sep 6, 2023
Merged
driskull added a commit that referenced this issue Sep 6, 2023
@driskull
fix(list-item): Do not call preventDefault on enter key within slotte…
c3261f0 
…d actions (#7684)

**Related Issue:** #7676

## Summary

- Enter key on any of the actions containers will not do anything
- So enter key will no longer be prevented
- Adds test
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 7, 2023
@geospatialem
Copy link
Member

Verified in 1.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
1.8.0 Maintenance Release
Development

No branches or pull requests
3 participants
@driskull @jrowlingson @geospatialem