fix(list-item): Do not call preventDefault on enter key within slotted actions #7684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
approved these changes
Sep 6, 2023
packages/calcite-components/src/components/list-item/list-item.e2e.ts
Outdated
Show resolved
Hide resolved
| if (key === "Enter") { | ||
| if ( | ||
| key === "Enter" && | ||
| !composedPath.includes(actionsStartEl) && |
There was a problem hiding this comment.
Nice!
Sidebar: it would be useful to do an audit to see if other components might need this too. cc @geospatialem
There was a problem hiding this comment.
Added #7686 for a spike in next month's milestone.
9 tasks
driskull
added
low risk
|
[Belated] low-risk confirmed! |
Merged
benelan
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/main: fix(list): remove unnecessary z-index (#7678) fix(sheet): calciteSheetClose should emit on scrim click (#7685) fix(modal): calciteModalClose should emit on close button click (#7680) fix(list-item): Do not call preventDefault on enter key within slotted actions (#7684) chore(locale): add extra info to default numbering system export (#7683) fix(input-date-picker): apply default numbering system to avoid browser inferring from locale (#7682) chore: release next fix(time-picker): focus corresponding input when nudge buttons are clicked (#7650) build(deps): update dependency @types/sortablejs to v1.15.2 (#7674) feat(flow): split up custom flow item interfaces (#7666)
jcfranco
pushed a commit
that referenced
this pull request
Sep 7, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 1.8.0</summary> ## [1.8.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@1.7.0...@esri/calcite-components@1.8.0) (2023-09-06) ### Features * **flow:** Split up custom flow item interfaces ([#7666](#7666)) ([6c22e7c](6c22e7c)) ### Bug Fixes * **action-group:** Honor flex-grow on slotted actions ([#7690](#7690)) ([0777234](0777234)) * **block:** Provide textual name on collapse and expansion to AT ([#7652](#7652)) ([85bd71b](85bd71b)) * **input-date-picker:** Apply default numbering system to avoid browser inferring from locale ([#7682](#7682)) ([3e1ed2d](3e1ed2d)) * **input-time-zone:** Prevent items from being deselected ([#7661](#7661)) ([c2dd436](c2dd436)) * **list-item:** Do not call preventDefault on enter key within slotted actions ([#7684](#7684)) ([c3261f0](c3261f0)) * **list:** Remove unnecessary z-index ([#7678](#7678)) ([1f4cd97](1f4cd97)) * **modal:** CalciteModalClose should emit on close button click ([#7680](#7680)) ([796bf90](796bf90)) * **sheet:** CalciteSheetClose should emit on scrim click ([#7685](#7685)) ([6ae963e](6ae963e)) * **sheet:** Update shadow style in display-mode="float" ([#7664](#7664)) ([851bedb](851bedb)) * **table:** Allow wrapping text in table-header and table-cell ([#7665](#7665)) ([15cb2bf](15cb2bf)) * **time-picker:** Focus corresponding input when nudge buttons are clicked ([#7650](#7650)) ([9c7d846](9c7d846)) </details> <details><summary>@esri/calcite-components-react: 1.8.0</summary> ## [1.8.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@1.7.0...@esri/calcite-components-react@1.8.0) (2023-09-06) ### Bug Fixes * Resolve vite errors due to using expressions in dynamic imports ([#7671](#7671)) ([b4c1038](b4c1038)) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^1.8.0-next.2 to ^1.8.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7676
Summary