Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flow): split up custom flow item interfaces #7666

Merged
merged 3 commits into from
Sep 5, 2023
Merged

feat(flow): split up custom flow item interfaces #7666

merged 3 commits into from
Sep 5, 2023
+48 −14

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Sep 2, 2023

Related Issue: #7608

Summary

Splits up interfaces for custom flow item class and elements.

This also updates the conventions doc with info on interface usage.

@jcfranco
refactor(flow): split up custom flow item interfaces

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 09541BBFF0C4C795
Learn about vigilant mode
022c093
@jcfranco jcfranco requested a review from a team as a code owner September 2, 2023 07:42
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Sep 2, 2023
@jcfranco jcfranco added skip visual snapshots Pull requests that do not need visual regression testing. and removed refactor Issues tied to code that needs to be significantly reworked. labels Sep 2, 2023
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Sep 2, 2023
@jcfranco jcfranco added the low risk Issues with low risk for consideration in low risk milestones label Sep 2, 2023
@jcfranco jcfranco mentioned this pull request Sep 2, 2023
Closed
driskull
driskull approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, maybe we should patch for this if they need it for implementation.

@jcfranco jcfranco changed the title refactor(flow): split up custom flow item interfaces feat(flow): split up custom flow item interfaces Sep 5, 2023
@jcfranco jcfranco added enhancement Issues tied to a new feature or request. and removed refactor Issues tied to code that needs to be significantly reworked. labels Sep 5, 2023
@jcfranco jcfranco merged commit 6c22e7c into main Sep 5, 2023
@jcfranco jcfranco deleted the jcfranco/split-up-custom-flow-item-interfaces branch September 5, 2023 19:43
@github-actions github-actions bot added this to the 1.7.1 Maintenance Release milestone Sep 5, 2023
@calcite-admin calcite-admin mentioned this pull request Sep 5, 2023
Merged
benelan added a commit that referenced this pull request Sep 6, 2023
@benelan
Merge remote-tracking branch 'origin/main' into benelan/ccr-vite-fix
1e05ae3 
* origin/main:
  fix(list): remove unnecessary z-index (#7678)
  fix(sheet): calciteSheetClose should emit on scrim click (#7685)
  fix(modal): calciteModalClose should emit on close button click (#7680)
  fix(list-item): Do not call preventDefault on enter key within slotted actions (#7684)
  chore(locale): add extra info to default numbering system export (#7683)
  fix(input-date-picker): apply default numbering system to avoid browser inferring from locale (#7682)
  chore: release next
  fix(time-picker): focus corresponding input when nudge buttons are clicked (#7650)
  build(deps): update dependency @types/sortablejs to v1.15.2 (#7674)
  feat(flow): split up custom flow item interfaces (#7666)
jcfranco pushed a commit that referenced this pull request Sep 7, 2023
@calcite-admin @github-actions
chore: release main (#7654)
171c9d0 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 1.8.0</summary>

##
[1.8.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@1.7.0...@esri/calcite-components@1.8.0)
(2023-09-06)


### Features

* **flow:** Split up custom flow item interfaces
([#7666](#7666))
([6c22e7c](6c22e7c))


### Bug Fixes

* **action-group:** Honor flex-grow on slotted actions
([#7690](#7690))
([0777234](0777234))
* **block:** Provide textual name on collapse and expansion to AT
([#7652](#7652))
([85bd71b](85bd71b))
* **input-date-picker:** Apply default numbering system to avoid browser
inferring from locale
([#7682](#7682))
([3e1ed2d](3e1ed2d))
* **input-time-zone:** Prevent items from being deselected
([#7661](#7661))
([c2dd436](c2dd436))
* **list-item:** Do not call preventDefault on enter key within slotted
actions
([#7684](#7684))
([c3261f0](c3261f0))
* **list:** Remove unnecessary z-index
([#7678](#7678))
([1f4cd97](1f4cd97))
* **modal:** CalciteModalClose should emit on close button click
([#7680](#7680))
([796bf90](796bf90))
* **sheet:** CalciteSheetClose should emit on scrim click
([#7685](#7685))
([6ae963e](6ae963e))
* **sheet:** Update shadow style in display-mode="float"
([#7664](#7664))
([851bedb](851bedb))
* **table:** Allow wrapping text in table-header and table-cell
([#7665](#7665))
([15cb2bf](15cb2bf))
* **time-picker:** Focus corresponding input when nudge buttons are
clicked
([#7650](#7650))
([9c7d846](9c7d846))
</details>

<details><summary>@esri/calcite-components-react: 1.8.0</summary>

##
[1.8.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@1.7.0...@esri/calcite-components-react@1.8.0)
(2023-09-06)


### Bug Fixes

* Resolve vite errors due to using expressions in dynamic imports
([#7671](#7671))
([b4c1038](b4c1038))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^1.8.0-next.2 to ^1.8.0
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull

Assignees

@jcfranco jcfranco

Labels
enhancement Issues tied to a new feature or request. low risk Issues with low risk for consideration in low risk milestones skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
1.8.0 Maintenance Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcfranco @driskull