Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stepper: add tokens for responsive layout #8174

Closed
3 of 5 tasks
anveshmekala opened this issue Nov 15, 2023 · 7 comments
Closed
3 of 5 tasks

stepper: add tokens for responsive layout #8174

anveshmekala opened this issue Nov 15, 2023 · 7 comments
Assignees
Labels
ArcGIS Developer Experience Issues logged by ArcGIS Developer Experience team members. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. docs Issues relating to documentation updates only. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive

Comments

@anveshmekala
Copy link
Contributor

Check existing issues

Description

Stepper component is using fixed min-width length to determine displaying single item vs all items as part of responsive layout enhancement. Having these values in design tokens helps users to enhance the values as required.

Acceptance Criteria

  1. Create tokens for min-width value for each scale.
  2. Use the tokens in stepper component to access the min-width of stepper-item per scale.

Relevant Info

No response

Which Component

calcite-stepper

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A

@anveshmekala anveshmekala added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 15, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Nov 15, 2023
@geospatialem geospatialem added the design-tokens Issues requiring design tokens. label Dec 15, 2023
@geospatialem
Copy link
Member

Could be considered as part of the efforts of #7180

@geospatialem geospatialem added docs Issues relating to documentation updates only. ArcGIS Developer Experience Issues logged by ArcGIS Developer Experience team members. labels Dec 15, 2023
@geospatialem
Copy link
Member

geospatialem commented Dec 15, 2023

In addition to the above, we should also add context to the Stepper doc page regarding the width of the component, or container width, which includes:

  • Small: 120px
  • Medium: 180px
  • Large: 200px

Knowing this context, can help developers decide if they would like to enable the single view mode or not.

cc @DitwanP

@anveshmekala
Copy link
Contributor Author

We longer need tokens for min-width of stepper-item as per #8461. Can we close this one? @geospatialem , @DitwanP

@geospatialem geospatialem added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Feb 16, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Feb 16, 2024
Copy link
Contributor

Installed and assigned for verification.

@geospatialem
Copy link
Member

We longer need tokens for min-width of stepper-item as per #8461. Can we close this one? @geospatialem , @DitwanP

Thanks @anveshmekala - marked the issue as installed pending verification. cc @DitwanP we may need an updated doc ref in our doc repo, more context above in #8174 (comment).

@anveshmekala
Copy link
Contributor Author

We longer need tokens for min-width of stepper-item as per #8461. Can we close this one? @geospatialem , @DitwanP

Thanks @anveshmekala - marked the issue as installed pending verification. cc @DitwanP we may need an updated doc ref in our doc repo, more context above in #8174 (comment).

Don't think the min-width's are documented. We no longer use default min-width in stepper. As part of #8461 fix, imposing min-width is removed irrespective of the layout value.

@geospatialem
Copy link
Member

Closing as no longer valid per Anvesh's comment above in #8174 (comment).

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Feb 19, 2024
@geospatialem geospatialem removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArcGIS Developer Experience Issues logged by ArcGIS Developer Experience team members. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. docs Issues relating to documentation updates only. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Projects
None yet
Development

No branches or pull requests

3 participants