Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper component 2.0 update breaks BA Experience builder widget #8461

Closed
2 of 6 tasks
ddred11 opened this issue Dec 19, 2023 · 13 comments
Closed
2 of 6 tasks

Stepper component 2.0 update breaks BA Experience builder widget #8461

ddred11 opened this issue Dec 19, 2023 · 13 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Business/Community Analyst Issues logged by ArcGIS Business/Community Analyst team members. calcite-components Issues specific to the @esri/calcite-components package. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible

Comments

@ddred11
Copy link

ddred11 commented Dec 19, 2023

Check existing issues

Description

Current updated behavior of the stepper widget breaks our UI for the Business Analyst widget in Experience Builder. At the default width of our widget, user can no longer see additional steps or easily click on them to forward the experience. Making this widget wider is a challenge given the canvas space in Experience Builder.
Screenshot 2023-12-19 at 2 54 07 PM.

Acceptance Criteria

We would like to have the component provided properties that would allow developers to set the width where the responsive design of the widget trigger so that we can return our widget to this experience.
Screenshot 2023-12-19 at 2 14 27 PM

Relevant Info

Breaks existing functionality. Will affect current users and the apps they have created with this widget.

Which Component

Stepper component

Example Use Case

No response

Priority impact

p1 - need for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Business/Community Analyst

@ddred11 ddred11 added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Dec 19, 2023
@github-actions github-actions bot added ArcGIS Business/Community Analyst Issues logged by ArcGIS Business/Community Analyst team members. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone calcite-components Issues specific to the @esri/calcite-components package. labels Dec 19, 2023
@geospatialem geospatialem added the design-tokens Issues requiring design tokens. label Dec 21, 2023
@macandcheese
Copy link
Contributor

This will also affect anyone trying to use the Stepper in Modal, as the width is often "below" the current breakpoint to swap to this mode. As a designer / dev user, I want to be able to ensure the Stepper doesn't enter this mode.
Screenshot 2024-01-04 at 12 20 44 PM

@SkyeSeitz
Copy link

Issue #8174 is to add the component tokens to do this customization. In the meantime, can we perhaps add the css vars for Stepper Item's minWidth value at each scale? @geospatialem Is it possible to prioritize for this milestone?

cc @alisonailea

@geospatialem
Copy link
Member

In the meantime, can we perhaps add the css vars for Stepper Item's minWidth value at each scale? @geospatialem Is it possible to prioritize for this milestone?

@SkyeSeitz It looks like there are still some follow-up's if this would indeed solve the use case on the stepper-item component, such as would users need to know the number of stepper-items rendered and set a minWidth based off the number of items?

Instead, wondering if each breakpoint value defined be overridden to another value, or in cases where the user does not want responsive behavior, have the ability to "zero" out the value?

@SkyeSeitz
Copy link

Thanks @geospatialem for the clarifying question!

Regardless of stepper width or number of stepper-items, the consideration for the user is how narrow do they want to allow stepper-items to get before stepper switches to the single view.

Some users may want to set the minWidth to as low as 0px to essentially opt out of the single view. Meaning stepper-items will always continue to squeeze and share inline space as the window narrows.


On the other hand, some users may still want stepper to switch to the single view, but just at a lower threshold where stepper-items are allowed to squeeze further than our default provided minWidth. I think this is especially effective, if wanting to build for windows that may change in width or if the stepper may be viewed on a mobile device.

Happy to discuss further as well!

@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality and removed needs triage Planning workflow - pending design/dev review. labels Jan 17, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jan 18, 2024
@ftiru
Copy link

ftiru commented Jan 29, 2024

@geospatialem Any update on this issue please? We need this fix for the February release of AGOL as our widget is dependent on this feature please.

@eriklharper
Copy link
Contributor

@ftiru Is there a reason why the condensed experience doesn't fit the bill for your scenario? You can still navigate with the left/right arrows to each of the steps.

image

@ftiru
Copy link

ftiru commented Jan 30, 2024

@eriklharper @geospatialem On production right now, users can create apps like this (narrow BA widget with large map) and easily navigate between the 3 steps of the BA widget by clicking on the steppers/headers as follows which has been the default behavior and that our users are familiar with:

image

With the recent calcite update, we lost this option to click on the headers for navigation between steps by default. In addition, the stepper labels (Search, Buffer, Infographics) get hidden even when the widget is still wide as follows:

image

We have to make our BA widget too wide to get that functionality back. For example here. I had to stretch the BA widget as wide as the map to get the default behavior back:

image

Basically, the condensed experience does not work well with our widget as it happens even when the widget is wide as follows:

image

We need to control when the condensed view should happen to our widget as the current calcite default behavior is not working.

@eriklharper
Copy link
Contributor

Curious if you set scale="s" if that would allow the step headings to appear at the right width?

@macandcheese
Copy link
Contributor

We need to support a way to disable or opt-out of this, or at least "fake opting out" by setting css property / breakpoint overrides. The examples above are clearly worse off for the responsive behavior.

Setting a different scale just to get this to fit here would have other implications across the UI - inconsistent font size, spacing, etc., when positioned amongst other "m" scale elements, and would likely be just as fragile as "s" would have its own magic width.

@eriklharper
Copy link
Contributor

@ftiru thanks for the detailed screenshots, these are really helpful!

@eriklharper eriklharper added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Feb 13, 2024
eriklharper added a commit that referenced this issue Feb 14, 2024
**Related Issue:** #8461

## Summary

This PR adds a new `layout` option: `horizontal-single` that replaces
the current responsive behavior of `horizontal` mode.

---------

Co-authored-by: Erik Harper <eriklharper@pm.me>
@eriklharper eriklharper added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Feb 14, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned eriklharper Feb 14, 2024
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Feb 15, 2024
Elijbet pushed a commit that referenced this issue Feb 15, 2024
**Related Issue:** #8461

## Summary

This PR adds a new `layout` option: `horizontal-single` that replaces
the current responsive behavior of `horizontal` mode.

---------

Co-authored-by: Erik Harper <eriklharper@pm.me>
anveshmekala added a commit that referenced this issue Feb 15, 2024
…ut='horizontal'` (#8758)

**Related Issue:**  #8461

## Summary

When `layout="horizontal"`, allows `stepper-item's` to shrink with
container width.
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Feb 15, 2024
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned anveshmekala Feb 15, 2024
@jcfranco jcfranco added regression Issues that are caused by changes in a release, but were working before that. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible labels Feb 15, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Feb 19, 2024
@geospatialem
Copy link
Member

Verified in 2.5.1 with https://codepen.io/geospatialem/pen/ZEPVaZL:

verify-stepper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Business/Community Analyst Issues logged by ArcGIS Business/Community Analyst team members. calcite-components Issues specific to the @esri/calcite-components package. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Projects
None yet
Development

No branches or pull requests

9 participants