Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Panel & Flow Item] heading and description line heights #9862

Closed
2 of 6 tasks
ashetland opened this issue Jul 26, 2024 · 3 comments
Closed
2 of 6 tasks

[Panel & Flow Item] heading and description line heights #9862

ashetland opened this issue Jul 26, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Milestone
2024-12-17 - Dec ...

Comments

@ashetland
Copy link

ashetland commented Jul 26, 2024 •
edited
Loading

Check existing issues

Description

To align with issue #7623, both the heading and description should be assigned calcite-font-line-height-relative-snug and the margin between them removed.

Acceptance Criteria

See above.
When only one text prop is used, the remaining text should be vertically centered in the header.

Relevant Info

cc @driskull @SkyeSeitz

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@ashetland ashetland added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 26, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Jul 26, 2024
@ashetland ashetland added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible label Aug 1, 2024
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 2 Small fix or update, may require updates to tests. labels Aug 6, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Aug 6, 2024
@DitwanP DitwanP mentioned this issue Aug 12, 2024
Merged
@aPreciado88 aPreciado88 self-assigned this Aug 27, 2024
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 27, 2024
@aPreciado88 aPreciado88 mentioned this issue Aug 28, 2024
Closed
@ashetland ashetland added enhancement Issues tied to a new feature or request. and removed bug Bug reports for broken functionality. Issues should include a reproduction of the bug. labels Aug 30, 2024
@ashetland ashetland changed the title [Panel & Flow Item] correct heading and description line heights [Panel & Flow Item] heading and description line heights Aug 30, 2024
@ashetland ashetland mentioned this issue Aug 30, 2024
Open
14 tasks
@aPreciado88
Copy link
Contributor

This is planned to be installed during a December/January release.

@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 2 - in development Issues that are actively being worked on. labels Oct 31, 2024
@aPreciado88 aPreciado88 added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 2, 2024
@aPreciado88 aPreciado88 mentioned this issue Dec 2, 2024
Merged
aPreciado88 added a commit that referenced this issue Dec 3, 2024
@aPreciado88
fix(panel): add correct heading and description line height and align…
0d295b8 
…ment (#10944)

**Related Issue:**
[#9862](#9862)

## Summary

Update `panel` to:

- Use `calcite-font-line-height-relative-snug` as `heading` and
`description`'s line height.
- Vertically center the header's content when only `heading` or
`description` are used.
@aPreciado88 aPreciado88 added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 3, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned aPreciado88 Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 6, 2024
@geospatialem
Copy link
Member

Verified with flow and panel in 3.0.0-next.51 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

No branches or pull requests
4 participants
@geospatialem @DitwanP @ashetland @aPreciado88