Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(panel): add correct heading and description line height and alignment #10944

Conversation

aPreciado88
Copy link
Contributor

Related Issue: #9862

Summary

Update panel to:

  • Use calcite-font-line-height-relative-snug as heading and description's line height.
  • Vertically center the header's content when only heading or description are used.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Dec 2, 2024
@aPreciado88 aPreciado88 added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 2, 2024
@aPreciado88 aPreciado88 added this to the 2024-12-17 - Dec Milestone milestone Dec 2, 2024
@aPreciado88
Copy link
Contributor Author

@ashetland @SkyeSeitz Could you please take a look at the new screenshots?

@ashetland
Copy link

LGTM! 🚀

@aPreciado88 aPreciado88 merged commit 0d295b8 into dev Dec 3, 2024
15 checks passed
@aPreciado88 aPreciado88 deleted the aPreciado88/9862-panel-and-flow-item-heading-and-description-line-heights branch December 3, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants