Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(alert): unskip a11y test #10110

Merged
merged 3 commits into from
Aug 19, 2024
Merged

test(alert): unskip a11y test #10110

merged 3 commits into from
Aug 19, 2024

Conversation

driskull
Copy link
Member

Related Issue: #7748

Summary

  • unskip test

@driskull driskull added the skip visual snapshots Pull requests that do not need visual regression testing. label Aug 19, 2024
@driskull driskull marked this pull request as ready for review August 19, 2024 21:53
@driskull driskull requested a review from macandcheese August 19, 2024 21:53
@driskull
Copy link
Member Author

Ran this a couple times and seems to work.

macandcheese
macandcheese approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it work without the internal properties in the DOM? I suppose the "non queue" Alert should pass this as well?

@driskull
Copy link
Member Author

Updated to not use internal props.

@driskull driskull merged commit 89624d1 into dev Aug 19, 2024
10 checks passed
@driskull driskull deleted the dris0000/unskip-alert-a11y-test branch August 19, 2024 23:16
@github-actions github-actions bot added this to the 2024-08-27 - Aug Release milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macandcheese macandcheese macandcheese approved these changes

Assignees

@driskull driskull

Labels
skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-08-27 - Aug Release
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @macandcheese