Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstable test: alert accessible #7748

Closed
driskull opened this issue Sep 15, 2023 · 3 comments
Closed

Unstable test: alert accessible #7748

driskull opened this issue Sep 15, 2023 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. c-alert Issues that pertain to the calcite-alert component estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing.
Milestone
2024-08-27 - Aug ...

Comments

@driskull
Copy link
Member

driskull commented Sep 15, 2023 •
edited
Loading

Test type

unstable test

Which Component(s)

alert

Unstable Tests

 describe.skip("accessible", () => {
    accessible(html` <calcite-alert open label="test"> ${alertContent} </calcite-alert> `);
  });

  describe.skip("accessible with auto-close", () => {
    accessible(html`
      <calcite-alert open auto-close auto-close-duration="slow" label="test"> ${alertContent} </calcite-alert>
    `);
  });

Test error, if applicable

No response

PR skipped, if applicable

#7749

Additional Info

No response
@driskull driskull added testing Issues related to automated or manual testing. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. labels Sep 15, 2023
driskull added a commit that referenced this issue Sep 15, 2023
@driskull
test(alert): skip unstable accessible test. #7748
3213839
@driskull driskull mentioned this issue Sep 15, 2023
Merged
driskull added a commit that referenced this issue Sep 15, 2023
@driskull
test(alert): skip unstable accessible test (#7749)
e93858a 
**Related Issue:** #7748

## Summary

skip unstable test
@macandcheese macandcheese added the c-alert Issues that pertain to the calcite-alert component label May 1, 2024
@macandcheese macandcheese mentioned this issue May 16, 2024
Closed
@driskull
Copy link
Member Author

Maybe this test will pass now that the AlertManager exists?

driskull added a commit that referenced this issue Aug 19, 2024
@driskull
test(alert): unskip a11y test. #7748
89a269c
@driskull driskull mentioned this issue Aug 19, 2024
Merged
driskull added a commit that referenced this issue Aug 19, 2024
@driskull
test(alert): unskip a11y test (#10110)
89624d1 
**Related Issue:** #7748

## Summary

- unskip test
@DitwanP DitwanP added estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library and removed p - high Issue should be addressed in the current milestone, impacts component or core functionality labels Aug 19, 2024
@DitwanP DitwanP added this to the 2024-08-27 - Aug Release milestone Aug 19, 2024
@DitwanP DitwanP added the 1 - assigned Issues that are assigned to a sprint and a team member. label Aug 19, 2024
@DitwanP DitwanP removed the 0 - new New issues that need assignment. label Aug 19, 2024
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Aug 20, 2024

🍡 Verified locally
image

@DitwanP DitwanP closed this as completed Aug 20, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 20, 2024
@DitwanP DitwanP mentioned this issue Aug 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. c-alert Issues that pertain to the calcite-alert component estimate - 3 A day or two of work, likely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing.
Projects
None yet
Milestone
2024-08-27 - Aug Release
Development

No branches or pull requests
4 participants
@driskull @macandcheese @geospatialem @DitwanP