Fix blocked issues action regex #10132
Assignees
Labels
4 - verified
Issues that have been released and confirmed resolved.
estimate - 2
Small fix or update, may require updates to tests.
p - low
Issue is non core or affecting less that 10% of people using the library
tooling
Issues relating to build system fixes or improvements.
Milestone
Comments
DitwanP
added
tooling
DitwanP
added a commit
that referenced
this issue
Aug 21, 2024
…sue action (#10135) **Related Issue:** #10132 ## Summary Changes the regex to better match the "Blocked issue:" so that randomly mentioned issues don't get matched and attempted to be unblocked. Also, catches the issue not found error in case somehow a issue that doesn't actually exist gets listed as blocked. [Codepen to test regex](https://codepen.io/Ditwan-Price/pen/QWXmmRL?editors=0012)
DitwanP
added
3 - installed
|
Installed and assigned for verification. |
6 tasks
|
Issue #10119 has been closed, this issue is ready for re-evaluation. |
|
🍠 Verified the issue was resolved and automation is still working as expected (see the bot comment above). Also checked that there was no comment on an issue that I intentionally listed without "Blocked issues: " in front of it. Also also... |
DitwanP
added
4 - verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Priority impact
p - low
Summary
The regex in action is not correctly matching for the "Blocked Issues:" part of the comment. Instead its just matching any mention of a number preceded by a
#.This is causing the action to run and fail on issues that don't actually have any blocked issues listed like this one #7748.
Here's the failed attempt: https://github.com/Esri/calcite-design-system/actions/runs/10477994663/job/29020354524
Desired Outcome
The action should correctly exit with the comment that there are no blocked issues listed on a closed issue.
Resources
No response
The text was updated successfully, but these errors were encountered: