Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel: add css variable to control spacing of slotted content #10119

Closed
2 of 6 tasks
driskull opened this issue Aug 20, 2024 · 3 comments
Closed
2 of 6 tasks

Panel: add css variable to control spacing of slotted content #10119

driskull opened this issue Aug 20, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-08-27 - Aug ...

Comments

@driskull
Copy link
Member

driskull commented Aug 20, 2024 •
edited by DitwanP
Loading

Check existing issues

Description

Add a css variable --calcite-panel-content-space to control padding of the content area

Acceptance Criteria

New CSS var

Relevant Info

Needed for #10095

Which Component

panel

Example Use Case

No response

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A
@driskull driskull added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 20, 2024
@driskull driskull mentioned this issue Aug 20, 2024
Merged
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Aug 20, 2024
@DitwanP DitwanP added 1 - assigned Issues that are assigned to a sprint and a team member. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 2 Small fix or update, may require updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 20, 2024
@DitwanP DitwanP added this to the 2024-08-27 - Aug Release milestone Aug 20, 2024
@alisonailea
Copy link
Contributor

When building new component tokens please follow the component token docs found in the wiki. https://github.com/Esri/calcite-design-system/wiki/component-tokens
Let me know if you have any questions or concerns. Since this is already here, can we use this ticket to add the rest of the Panel component tokens as well?

driskull added a commit that referenced this issue Aug 21, 2024
@driskull
feat(panel): add '--calcite-panel-content-space' style (#10117)
0e3ebcb 
**Related Issue:** #10119

## Summary

- add `--calcite-panel-content-space` style.
- adds `relative` positioning to content so that absolutely positioned
elements are contained within the panel content. (shell use case)
- add e2e test

This will allow the dialog component to set padding on the content of
the internal panel without having to surround the content with a div
which messes up the placement of the FAB within panel.
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Aug 21, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Aug 21, 2024

🍡 Verified on 2.12.0-next.28
https://codepen.io/Ditwan-Price/pen/NWZYLdP?editors=1100

@DitwanP DitwanP closed this as completed Aug 21, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Aug 21, 2024
@DitwanP DitwanP reopened this Aug 21, 2024
@DitwanP DitwanP closed this as completed Aug 21, 2024
@github-actions github-actions bot mentioned this issue Aug 21, 2024
Closed
@driskull driskull mentioned this issue Oct 7, 2024
Merged
driskull added a commit that referenced this issue Oct 10, 2024
@driskull
revert(panel): revert relative positioning on content (#10496)
239f4da 
**Related Issue:** #10494 #10095

## Summary

- reverts position relative styling
- #10119 should be verified again
benelan pushed a commit that referenced this issue Oct 11, 2024
@driskull @benelan
revert(panel): revert relative positioning on content (#10496)
4aa39b2 
**Related Issue:** #10494 #10095

## Summary

- reverts position relative styling
- #10119 should be verified again
benelan pushed a commit that referenced this issue Oct 11, 2024
@driskull @benelan
revert(panel): revert relative positioning on content (#10496)
e8cc258 
**Related Issue:** #10494 #10095

## Summary

- reverts position relative styling
- #10119 should be verified again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-08-27 - Aug Release
Development

No branches or pull requests
4 participants
@driskull @alisonailea @geospatialem @DitwanP