Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(actions): fix regex, and catch issue not found error on blocked issue action #10135

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

DitwanP
Copy link
Contributor

@DitwanP DitwanP commented Aug 21, 2024

Related Issue: #10132

Summary

Changes the regex to better match the "Blocked issue:" so that randomly mentioned issues don't get matched and attempted to be unblocked.

Also, catches the issue not found error in case somehow a issue that doesn't actually exist gets listed as blocked.

Codepen to test regex

@DitwanP DitwanP requested a review from benelan August 21, 2024 19:13
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Aug 21, 2024
@DitwanP DitwanP added the skip visual snapshots Pull requests that do not need visual regression testing. label Aug 21, 2024
@DitwanP DitwanP marked this pull request as ready for review August 21, 2024 19:13
@DitwanP DitwanP added skip visual snapshots Pull requests that do not need visual regression testing. and removed skip visual snapshots Pull requests that do not need visual regression testing. labels Aug 21, 2024
…nto dit13711/10132-fix-blocked-issues-comment-regex
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DitwanP DitwanP merged commit d3bd115 into dev Aug 21, 2024
11 checks passed
@DitwanP DitwanP deleted the dit13711/10132-fix-blocked-issues-comment-regex branch August 21, 2024 23:06
@github-actions github-actions bot added this to the 2024-08-27 - Aug Release milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants