Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(actions): fix regex, and catch issue not found error on blocked issue action #10135

Merged
merged 2 commits into from
Aug 21, 2024
Merged

ci(actions): fix regex, and catch issue not found error on blocked issue action #10135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdd5d52
fix regex, and catch issue not found error
DitwanP Aug 21, 2024
48bc6b4
Merge branch 'dev' of https://github.com/Esri/calcite-design-system i…
DitwanP Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions .github/scripts/addUnblockedComment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ module.exports = async ({ github, context }) => {
const payload = /** @type {import('@octokit/webhooks-types').IssuesLabeledEvent} */ (context.payload);
const { ISSUE_VERIFIERS } = process.env;
const issueBody = payload.issue.body;
const blockedIssuesRegex = /(?!Blocked issues:\s)(#\d+)/gi;
const blockedIssuesRegex = /Blocked issues:\s*(#\d+(?:,\s*#\d+)*)/i;

if (!issueBody) {
console.log("No issue body was found");
console.log("No issue body was found.");
return;
}

Expand All @@ -23,7 +23,7 @@ module.exports = async ({ github, context }) => {

// If "Blocked issues" line is matched in the body then create a comment on each issue listed
if (blockedIssues) {
const issueNumbers = blockedIssues.map((number) => number.slice(1));
const issueNumbers = blockedIssues[1].split(",").map((num) => num.trim().slice(1));

for (const issueNumber of issueNumbers) {
const issueProps = {
Expand All @@ -32,10 +32,19 @@ module.exports = async ({ github, context }) => {
issue_number: Number(issueNumber),
};

await github.rest.issues.createComment({
...issueProps,
body: `Issue #${context.issue.number} has been closed, this issue is ready for re-evaluation. \n\ncc ${verifiers}`,
});
try {
await github.rest.issues.createComment({
...issueProps,
body: `Issue #${context.issue.number} has been closed, this issue is ready for re-evaluation. \n\ncc ${verifiers}`,
});
} catch (error) {
if (error.status === 404) {
console.log(`Issue #${issueNumber} does not exist.`);
continue;
} else {
throw error;
}
}

try {
await github.rest.issues.removeLabel({
Expand Down
Loading