Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(stylelint): refactor to and enforce kebab-casing for Sass utilities #10147

Merged
merged 11 commits into from
Aug 24, 2024

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Aug 22, 2024

Related Issue: #7365

Summary

Refactor sass names to kebab-case.

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Aug 22, 2024
@Elijbet Elijbet marked this pull request as ready for review August 23, 2024 20:01
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

packages/calcite-components/.stylelintrc.json Outdated Show resolved Hide resolved
packages/calcite-components/.stylelintrc.json Outdated Show resolved Hide resolved
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Before merging, can you revisit the PR title to convey that this enforces kebab-casing for Sass utils?

Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 👍

@Elijbet Elijbet changed the title refactor(stylelint): refactor sass names to kebab-case refactor(stylelint): refactor to and enforce kebab-casing for Sass utilities Aug 24, 2024
@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Aug 24, 2024
@Elijbet Elijbet merged commit 3c4775c into dev Aug 24, 2024
17 checks passed
@Elijbet Elijbet deleted the elijbet/7365-refactor-sass-names-to-kebab-case branch August 24, 2024 14:53
@github-actions github-actions bot added this to the 2024-08-27 - Aug Release milestone Aug 24, 2024
benelan added a commit that referenced this pull request Aug 27, 2024
…oating-point-issue

* origin/dev:
  chore: release next
  feat(icon): add component tokens (#10062)
  refactor: fix `FunctionalComponent` return types (#10164)
  chore: release next
  fix(input-date-picker): prevent console error when using a lang (#10162)
  feat(action, action-bar, action-group, action-menu, action-pad): add component tokens (#10058)
  refactor(stylelint): refactor to and enforce kebab-casing for Sass utilities (#10147)
  chore: release next
  test(popover): unskip focusable test (#10138)
  fix(filter): fix setFocus method (#10149)
@geospatialem geospatialem mentioned this pull request Aug 29, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants