-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add web adaptor #10278
feat: add web adaptor #10278
Conversation
"web-adaptor": { | ||
"alias": ["3.29.7", "gis", "core", "web", "diagram", "nodes", "gis", "storage", "servers", "transfer"], | ||
"category": "GIS", | ||
"release": "3.29.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version here is incorrect, it will be released as 3.32.0
. For reference, the versioning strategy is called semver
.
TLDR; The format is <MAJOR>.<MINOR>.<PATCH>
-
When changing an existing icon, use the
fix:
prefix in the PR title and increment the<PATCH>
number. -
When you add icons, use the
feat:
prefix in the PR title, increment the<MINOR>
number, and set the<PATCH>
number to0
. -
When introducing a change that breaks previous functionality (e.g. renaming icons), use the
refactor!:
prefix, increment the<MAJOR>
number, and set the<MINOR>
and<PATCH>
versions to0
.
Please let me, @jcfranco, and @geospatialem know before installing breaking changes, because they require advanced messaging to our users.
"connection-middle": { | ||
"alias": ["3.29.5", "generic", "line", "point", "middle", "connect"], | ||
"category": "Generic", | ||
"release": "3.29.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The versions starting at 3.29.1
are also incorrect. Can you please create a separate fix
PR that updates them to the correct versions? You can see which version the icons were released as by checking the changelog
Related Issue: #
Summary
added
web-adaptor-16
web-adaptor-24
web-adaptor-32