Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add web adaptor #10278

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

75 changes: 75 additions & 0 deletions packages/calcite-ui-icons/docs/keywords.json
Original file line number Diff line number Diff line change
Expand Up @@ -8860,5 +8860,80 @@
],
"category": "Symbols",
"release": "3.29.0"
},
"flag-slash": {
"alias": ["3.29.1", "objects", "flag", "cancel", "stop", "slash", "signal", "remove", "important", "alert"],
"category": "Objects",
"release": "3.29.1"
},
"flag": {
"alias": ["3.29.1", "objects", "signal", "flag", "sign", "important", "warning", "alert", "caution"],
"category": "Objects",
"release": "3.29.1"
},
"closed-caption": {
"alias": ["3.29.3", "media", "media", "audio", "video", "display", "text", "information"],
"category": "Media",
"release": "3.29.3"
},
"transcript": {
"alias": ["3.29.3", "media", "captions", "text", "video", "display", "speech"],
"category": "Media",
"release": "3.29.3"
},
"layer-connection": {
"alias": ["3.29.2", "layers", "plug", "top", "connection", "network", "properties"],
"category": "Layers",
"release": "3.29.2"
},
"trace-path": {
"alias": ["3.29.4", "gis", "tracing", "lines", "points", "edges", "path", "copy"],
"category": "GIS",
"release": "3.29.4"
},
"trace-path-complete": {
"alias": ["3.29.4", "gis", "lines", "path", "completion", "edges", "points", "tracing"],
"category": "GIS",
"release": "3.29.4"
},
"connection-end-left": {
"alias": ["3.29.5", "generic", "line", "point", "connect", "end", "left"],
"category": "Generic",
"release": "3.29.5"
},
"connection-end-right": {
"alias": ["3.29.5", "generic", "line", "point", "connect", "right", "end"],
"category": "Generic",
"release": "3.29.5"
},
"connection-to-connection": {
"alias": ["3.29.5", "generic", "connect", "two points", "line"],
"category": "Generic",
"release": "3.29.5"
},
"connection-middle": {
"alias": ["3.29.5", "generic", "line", "point", "middle", "connect"],
"category": "Generic",
"release": "3.29.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versions starting at 3.29.1 are also incorrect. Can you please create a separate fix PR that updates them to the correct versions? You can see which version the icons were released as by checking the changelog

},
"justify": {
"alias": [
"3.29.6",
"lists",
"alignment",
"typography",
"paragraph",
"type",
"body text",
"format",
"justification"
],
"category": "Lists",
"release": "3.29.6"
},
"web-adaptor": {
"alias": ["3.29.7", "gis", "core", "web", "diagram", "nodes", "gis", "storage", "servers", "transfer"],
"category": "GIS",
"release": "3.29.7"
Copy link
Member

@benelan benelan Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version here is incorrect, it will be released as 3.32.0. For reference, the versioning strategy is called semver.

TLDR; The format is <MAJOR>.<MINOR>.<PATCH>

  • When changing an existing icon, use the fix: prefix in the PR title and increment the <PATCH> number.

  • When you add icons, use the feat: prefix in the PR title, increment the <MINOR> number, and set the <PATCH> number to 0.

  • When introducing a change that breaks previous functionality (e.g. renaming icons), use the refactor!: prefix, increment the <MAJOR> number, and set the <MINOR> and <PATCH> versions to 0.

Please let me, @jcfranco, and @geospatialem know before installing breaking changes, because they require advanced messaging to our users.

}
}
1 change: 1 addition & 0 deletions packages/calcite-ui-icons/icons/web-adaptor-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions packages/calcite-ui-icons/icons/web-adaptor-24.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions packages/calcite-ui-icons/icons/web-adaptor-32.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.