fix(shell-center-row): ensure deprecation warning doesn’t show when using standalone shell or shell-panel
#10561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using standalone shell
github-actions
bot
added
the
chore
|
I'll submit a follow-up PR to update other components accordingly. |
jcfranco
added
the
skip visual snapshots
jcfranco
changed the title
shell or shell-panel
jcfranco
deleted the
jcfranco/show-shell-center-row-deprecation-message-when-loading
branch
benelan
pushed a commit
that referenced
this pull request
Oct 23, 2024
…sing standalone `shell` or `shell-panel` (#10561) **Related Issue:** #10563 ## Summary Moves deprecation warnings to show when `shell-center-row` is added to the DOM and initially loaded. This warning was being shown due to [bundling](https://github.com/Esri/calcite-design-system/blob/dev/packages/calcite-components/stencil.config.ts#L76).
Merged
benelan
pushed a commit
that referenced
this pull request
Oct 24, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.13.2</summary> ## [2.13.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.1...@esri/calcite-components@2.13.2) (2024-10-23) ### Bug Fixes * **shell-center-row:** Ensure deprecation warning doesn’t show when using standalone `shell` or `shell-panel` ([#10561](#10561)) ([09d74ae](09d74ae)) </details> <details><summary>@esri/calcite-components-angular: 2.13.2</summary> ## [2.13.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.1...@esri/calcite-components-angular@2.13.2) (2024-10-23) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.1 to 2.13.2 </details> <details><summary>@esri/calcite-components-react: 2.13.2</summary> ## [2.13.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.1...@esri/calcite-components-react@2.13.2) (2024-10-23) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.1 to 2.13.2 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
benelan
pushed a commit
that referenced
this pull request
Oct 24, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.13.2</summary> [2.13.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.13.1...@esri/calcite-components@2.13.2) (2024-10-23) * **shell-center-row:** Ensure deprecation warning doesn’t show when using standalone `shell` or `shell-panel` ([#10561](#10561)) ([09d74ae](09d74ae)) </details> <details><summary>@esri/calcite-components-angular: 2.13.2</summary> [2.13.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.13.1...@esri/calcite-components-angular@2.13.2) (2024-10-23) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.1 to 2.13.2 </details> <details><summary>@esri/calcite-components-react: 2.13.2</summary> [2.13.2](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.13.1...@esri/calcite-components-react@2.13.2) (2024-10-23) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.1 to 2.13.2 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10563
Summary
Moves deprecation warnings to show when
shell-center-rowis added to the DOM and initially loaded.This warning was being shown due to bundling.