Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move deprecation warnings to componentWillLoad to avoid incorrect messaging due to bundling #10612

Merged
merged 3 commits into from
Oct 25, 2024
Merged

refactor: move deprecation warnings to componentWillLoad to avoid incorrect messaging due to bundling #10612

merged 3 commits into from
Oct 25, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Oct 25, 2024 •
edited
Loading

Related Issue: N/A

Summary

This prevents issues similar to #10563.

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Oct 25, 2024
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Oct 25, 2024
@jcfranco jcfranco requested a review from anveshmekala October 25, 2024 21:24
@jcfranco jcfranco requested a review from benelan October 25, 2024 22:00
benelan
benelan approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco merged commit d256c99 into dev Oct 25, 2024
10 checks passed
@jcfranco jcfranco deleted the jcfranco/show-deprecation-warnings-on-will-load branch October 25, 2024 22:51
@github-actions github-actions bot added this to the 2024-10-29 - Oct Milestone milestone Oct 25, 2024
@jcfranco
Copy link
Member Author

cc @geospatialem @DitwanP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

@anveshmekala anveshmekala Awaiting requested review from anveshmekala

Assignees

@jcfranco jcfranco

Labels
refactor Issues tied to code that needs to be significantly reworked. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-10-29 - Oct Milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @benelan