fix(list, sort-handle): disable sort-handle when no move to items are present and item count is one #11073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… present and item count is one. #10731
driskull
added
bug
jcfranco
approved these changes
Dec 16, 2024
| } = this; | ||
| const text = this.getLabel(); | ||
|
|
||
| const isDisabled = disabled || !setPosition || !setSize; | ||
| const isDisabled = |
There was a problem hiding this comment.
Is the optional chaining operator on moveToItems needed? It looks like it's guaranteed now, but I could be missing something.
There was a problem hiding this comment.
Its not but I added for extra safety. I can remove it.
driskull
added
the
pr ready for visual snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10731
Summary
BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE