-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow up on remaining Lumina migration notes #10731
Comments
Similar to the
Wondering if we should consider a more comprehensive testing approach to determine if there are other components with
|
When creating a dialog with cc @driskull |
…nitialization (#11038) **Related Issue:** #10731 ## Summary `willUpdate` was invoking toggling logic that was meant to be called after initialization (compare with [Stencil version](https://github.com/Esri/calcite-design-system/blame/bcc19be314a45ff584793e473e5851e15cefa83f/packages/calcite-components/src/components/panel/panel.tsx#L92)).
…ent is hidden (#11056) **Related Issue:** #10731 ## Summary This will address the following Chrome console error caused by using the `ariaHidden` prop (after #10310): > Blocked aria-hidden on an element because its descendant retained focus. The focus must not be hidden from assistive technology users. Avoid using aria-hidden on a focused element or its ancestor. Consider using the inert attribute instead, which will also prevent focus. For more details, see the aria-hidden section of the WAI-ARIA specification at https://w3c.github.io/aria/#aria-hidden. Element with focus: span Ancestor with aria-hidden: <calcite-popover reference-element="reference-element" placement="auto" offset-distance="6" offset-skidding="0" text-close="Close" aria-hidden="true" aria-live="polite" id="calcite-popover-a872ffbb-85e1-5c2c-6f14-8108c4821728" role="dialog" overlay-positioning="absolute" scale="m" calcite-hydrated>…</calcite-popover>#shadow-root (open)<div style="width: 300px; padding:12px 16px;">…</div>slot</calcite-popover> BEGIN_COMMIT_OVERRIDE END_COMMIT_OVERRIDE
… present and item count is one. #10731
**Related Issue:** #10731 ## Summary Fixes a text width logic issue where [`font`](https://developer.mozilla.org/en-US/docs/Web/CSS/font) would be empty instead of the expected shorthand value. This also moves the text-width calculation logic to a `requestAnimationFrame` callback to improve timing and performance. BEGIN_COMMIT_OVERRIDE END_COMMIT_OVERRIDE
) **Related Issue:** #10731 ## Summary Adds a guard to `popover` and `tooltip` `ref` callbacks to avoid missing ref warnings on removal. After #10310, `ref` callbacks are invoked both when the component is added and removed (see #11093). BEGIN_COMMIT_OVERRIDE omitted from changelog END_COMMIT_OVERRIDE
**Related Issue:** #10731 ## Summary Adds package export to support doc-related ESM imports.
**Related Issue:** #10731 ## Summary Uses pseudo-element + CSS logical property placement to ensure the selection indicator is consistently positioned, regardless of page direction. BEGIN_COMMIT_OVERRIDE omitted from changelog END_COMMIT_OVERRIDE --------- Co-authored-by: Blake Stearman <bstearman@esri.com>
) **Related Issue:** #10731 ## Summary Fixes a combobox regression introduced by #11265 without impacting performance. ### Notable changes * drops debouncing of * item update (initial update delay was the main cause of regression) * change event emitting * adds more test coverage for change event emitting * ignores item-initiated updates until combobox is loaded * splits up item update logic into the following sections to minimize re-renders: * item/data * item props * selection/filter * minor tidy up
…ipping (#11373) **Related Issue:** #10731 ## Summary Removes legacy `position: relative` to reduce chance of clipping (see https://floating-ui.com/docs/misc#clipping). BEGIN_COMMIT_OVERRIDE omitted from changelog END_COMMIT_OVERRIDE
**Related Issue:** #10731 ## Summary Fixes prop update delays introduced in #10310 by moving event emitting to Lit's [pre-update phase](https://lit.dev/docs/components/lifecycle/#reactive-update-cycle).
Description
In addition to the migration notes added by #10310, the following should be addressed as well:
filter#filter()
to use the debounced function (see ad054fd)list
(see ad054fd).Stabilize
☑️ – no longer shows up
✅ – #10818
Proposed Advantages
Cleaner, simpler code.
Which Component
N/A
Relevant Info
No response
Calcite package
The text was updated successfully, but these errors were encountered: