fix(combobox, input-time-zone): fix initial item selection delay #11326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
added
the
pr ready for visual snapshots
driskull
approved these changes
Jan 17, 2025
| @@ -119,7 +115,9 @@ export class Combobox | |||
|
|
|||
| defaultValue: Combobox["value"]; | |||
|
|
|||
| private emitComboboxChange = debounce(this.internalComboboxChangeEvent, 0); | |||
| @@ -1229,15 +1229,19 @@ export class Combobox | |||
| return this.filterText === "" ? this.items : this.items.filter((item) => !item.hidden); | |||
| } | |||
|
|
|||
| private updateItems = debounce((): void => { | |||
There was a problem hiding this comment.
shouldn't we still debounce this in some cases? Like the mutation observer case?
There was a problem hiding this comment.
We could keep an eye out for this. The MO callback kicks in once per batch of mutations, so I don't expect a significant increase in updateItem calls.
There was a problem hiding this comment.
Sounds good. We may want to have some internal doc/guidelines on when we should debounce a function and under what circumstances.
Comment on lines
659
to
665
| this.getItems().forEach((item) => { | ||
| item.selected = Array.isArray(value) | ||
| ? value.includes(item.value) | ||
| : value | ||
| ? value === item.value | ||
| : false; | ||
| }); |
There was a problem hiding this comment.
Suggested change
| this.getItems().forEach((item) => { | |
| item.selected = Array.isArray(value) | |
| ? value.includes(item.value) | |
| : value | |
| ? value === item.value | |
| : false; | |
| }); | |
| for (const item of this.getItems()) { | |
| item.selected = (Array.isArray(value) && value.includes(item.value)) || | |
| (!Array.isArray(value) && value === item.value); | |
| } |
|
I noticed some diffs on the initial render. Looking into this. |
jcfranco
added
pr ready for visual snapshots
jcfranco
added
pr ready for visual snapshots
jcfranco
added
pr ready for visual snapshots
jcfranco
added
pr ready for visual snapshots
jcfranco
removed
the
pr ready for visual snapshots
jcfranco
added
the
pr ready for visual snapshots
jcfranco
deleted the
jcfranco/10731-fix-combobox-initial-item-selection-delay
branch
github-actions
bot
added this to the 2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
benelan
added a commit
that referenced
this pull request
Jan 21, 2025
* origin/dev: (322 commits) chore: add ui icons package to enhancement template (#11344) chore(table): move workaround comment back to its usage (#11341) ci(actions): refine remove-issue-from-design-projects workflow (#11325) chore(actions): add icon leads notification for calcite-ui-icons requests (#11263) test(combobox): use async expect for non-throwing test case (#11332) fix(combobox, input-time-zone): fix initial item selection delay (#11326) build(deps): update dependency type-fest to v4.32.0 (#11308) chore(utility-network-layer, crosshair): add font codepoints (#11336) refactor(loadable): deprecate obsolete helpers (#11312) chore: release next feat: add crosshair (#11331) build(deps): update arcgis to ^4.32.0-next.81 (#11273) ci(actions): add action to remove issues from design projects (#11249) chore: release next fix(list-item): reflect the sortHandleOpen property (#11323) refactor(block): heading text color (#11314) chore: release next fix(list): only focus on row when clicking a list item (#11310) fix(tooltip, popover): honor prevented events (#11278) chore: release next ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10731
Summary
Fixes a combobox regression introduced by #11265 without impacting performance.
Notable changes