Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input-date-picker): display updated valueAsDate in the two range inputs #5758

Merged

Conversation

eriklharper
Copy link
Contributor

Related Issue: #5207

Summary

This PR fixes an issue where the input boxes are completely empty when the valueAsDate property is directly changed with javascript when using the range prop.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Nov 15, 2022
@eriklharper eriklharper marked this pull request as ready for review November 23, 2022 00:19
@eriklharper eriklharper requested review from a team as code owners November 23, 2022 00:19
@eriklharper eriklharper added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 23, 2022
… of github.com:Esri/calcite-components into eriklharper/5207-input-date-picker-ignores-valueAsDate
@eriklharper eriklharper requested a review from benelan November 23, 2022 00:39
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @eriklharper 🎉 🌮

@eriklharper eriklharper added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 23, 2022
@eriklharper eriklharper merged commit ea93555 into master Nov 23, 2022
@eriklharper eriklharper deleted the eriklharper/5207-input-date-picker-ignores-valueAsDate branch November 23, 2022 18:51
benelan added a commit that referenced this pull request Nov 28, 2022
* master:
  docs: update component READMEs (#5810)
  ci(chromatic): use diffThreshold value saved in secrets (#5806)
  1.0.0-next.642
  fix(combobox): 5540 - handle focus (#5774)
  1.0.0-next.641
  fix(tree-item): Allow space and enter key events when selectionMode is "none" (#5800)
  Update CONTRIBUTING.md
  1.0.0-next.640
  fix(input-date-picker): display updated valueAsDate in the two range inputs (#5758)
  docs(tree): Update interface for selectionMode. (#5801)
  docs: update component READMEs (#5804)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants