-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(input-date-picker): display updated valueAsDate in the two range inputs #5758
Merged
eriklharper
merged 11 commits into
master
from
eriklharper/5207-input-date-picker-ignores-valueAsDate
Nov 23, 2022
Merged
fix(input-date-picker): display updated valueAsDate in the two range inputs #5758
eriklharper
merged 11 commits into
master
from
eriklharper/5207-input-date-picker-ignores-valueAsDate
Nov 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a range input date picker
…lharper/5207-input-date-picker-ignores-valueAsDate
…he component instance
…lharper/5207-input-date-picker-ignores-valueAsDate
github-actions
bot
added
the
bug
Bug reports for broken functionality. Issues should include a reproduction of the bug.
label
Nov 15, 2022
eriklharper
added
the
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
label
Nov 23, 2022
… of github.com:Esri/calcite-components into eriklharper/5207-input-date-picker-ignores-valueAsDate
driskull
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @eriklharper 🎉 🌮
eriklharper
added
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
Nov 23, 2022
eriklharper
deleted the
eriklharper/5207-input-date-picker-ignores-valueAsDate
branch
November 23, 2022 18:51
benelan
added a commit
that referenced
this pull request
Nov 28, 2022
* master: docs: update component READMEs (#5810) ci(chromatic): use diffThreshold value saved in secrets (#5806) 1.0.0-next.642 fix(combobox): 5540 - handle focus (#5774) 1.0.0-next.641 fix(tree-item): Allow space and enter key events when selectionMode is "none" (#5800) Update CONTRIBUTING.md 1.0.0-next.640 fix(input-date-picker): display updated valueAsDate in the two range inputs (#5758) docs(tree): Update interface for selectionMode. (#5801) docs: update component READMEs (#5804)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Bug reports for broken functionality. Issues should include a reproduction of the bug.
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5207
Summary
This PR fixes an issue where the input boxes are completely empty when the
valueAsDate
property is directly changed with javascript when using therange
prop.