ci(chromatic): use diffThreshold value saved in secrets #5806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
benelan
added a commit
that referenced
this pull request
Nov 28, 2022
* master: docs: update component READMEs (#5810) ci(chromatic): use diffThreshold value saved in secrets (#5806) 1.0.0-next.642 fix(combobox): 5540 - handle focus (#5774) 1.0.0-next.641 fix(tree-item): Allow space and enter key events when selectionMode is "none" (#5800) Update CONTRIBUTING.md 1.0.0-next.640 fix(input-date-picker): display updated valueAsDate in the two range inputs (#5758) docs(tree): Update interface for selectionMode. (#5801) docs: update component READMEs (#5804)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #
Summary
I forgot to pass the diff threshold GH secret to the chromatic workflow's environment variables 😅
That explains why bumping up the value wasn't doing anything