build(deps)!: bump Stencil to v4 #8108

jcfranco · 2023-11-02T21:25:03Z

Related Issue: #7861

Summary

Bumps Stencil to v4 following migration guides (v2 ➡️ v3, v3 ➡️ v4).

Noteworthy changes

add components.d.ts to source control per Stencil recommendation
add workaround for JSX imports not matching what Stencil React output target expects
dropped workaround for Add support for getAssetPath to @esri/calcite-components/dist/components/index #6696 (fixed in v4)
drop obsolete tree-shaking patch (build: patch rollup tree shaking stencil issue #5233) (fixed in v4)
skips additional locales that are showing formatting differences between test/node and browser environments
updates volta and engines fields from eslint-plugin-calcite-components' package.json to match other packages
dep changes:
- bumps @typescript-eslint†, angular†, jest†, puppeteer, typescript to latest († and related deps)
- removed unused @stencil/state-tunnel
- replaced @stencil/postcss with @stencil-community/postcss (the latter is maintained)
- added missing globby (tooling) and jsdom (testing)
- override @jest/transform to ensure node types match

BREAKING CHANGE: We are treating this core version bump as a precautionary measure, particularly due to its potential impact on projects using calcite-components and Stencil.

BREAKING CHANGE: We are treating this core version bump as a precautionary measure, particularly due to its potential impact on projects using `calcite-components` and Stencil.

…ciljs.com/docs/typed-components)

This reverts commit 680e1c4.

Bumps angular packages to fix the build errors you were experiencing. Feel free to merge it yourself. --------- Co-authored-by: Anveshreddy mekala <anv11827@esri.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

## Summary Fixed a couple more package-lock merge conflicts that popped up from syncing with main after installing the renovate tailwind pr --------- Co-authored-by: Anveshreddy mekala <anv11827@esri.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

**Related Issue:** n/a ## Summary The node_module @types/yargs was added by mistake. Removing. --------- Co-authored-by: JC Franco <jfranco@esri.com>

**Related Issue:** #7526 ## Summary Updates the pull request CI to also run when the base branch is `rc`, which will be used for installing breaking changes prior to a major version release.

This PR was automatically generated by the update-browserslist-db GitHub action Co-authored-by: jcfranco <jcfranco@users.noreply.github.com>

driskull

👍 Nice!

**Related Issue:** #7861 Bumps Stencil to v4. * add `components.d.ts` to source control per [Stencil recommendation](https://stenciljs.com/docs/typed-components) * add workaround for JSX imports not matching what Stencil React output target expects * dropped workaround for #6696 (fixed in v4) * drop obsolete tree-shaking patch (#5233) (fixed in v4) * skips additional locales that are showing formatting differences between test/node and browser environments * updates `volta` and `engines` fields from `eslint-plugin-calcite-components`' `package.json` to match other packages * dep changes: * bumps `@typescript-eslint`†, `angular`†, `jest`†, `puppeteer`, `typescript` to latest († and related deps) * removed unused `@stencil/state-tunnel` * replaced `@stencil/postcss` with `@stencil-community/postcss` * added missing `globby` and `jsdom` * override `@jest/transform` to ensure node types match BREAKING CHANGE: We are treating this core version bump as a precautionary measure, particularly due to its potential impact on projects using `calcite-components` and Stencil. --------- Co-authored-by: Ben Elan <no-reply@benelan.dev> Co-authored-by: jcfranco <jcfranco@users.noreply.github.com>

ffaubry · 2023-11-16T21:49:11Z

@jcfranco I'm adding question here even if this PR is merged. Let me know there is a better place.

You are using a fix version for stencil core. Why not using ^4.7.1?
You move the angular wrapper to 17. What's your thoughts about angular 16?

BTW, we stopped using ts-node and we are using tsx. Faster IMO.

**Related Issue:** #7861 Bumps Stencil to v4. * add `components.d.ts` to source control per [Stencil recommendation](https://stenciljs.com/docs/typed-components) * add workaround for JSX imports not matching what Stencil React output target expects * dropped workaround for #6696 (fixed in v4) * drop obsolete tree-shaking patch (#5233) (fixed in v4) * skips additional locales that are showing formatting differences between test/node and browser environments * updates `volta` and `engines` fields from `eslint-plugin-calcite-components`' `package.json` to match other packages * dep changes: * bumps `@typescript-eslint`†, `angular`†, `jest`†, `puppeteer`, `typescript` to latest († and related deps) * removed unused `@stencil/state-tunnel` * replaced `@stencil/postcss` with `@stencil-community/postcss` * added missing `globby` and `jsdom` * override `@jest/transform` to ensure node types match BREAKING CHANGE: We are treating this core version bump as a precautionary measure, particularly due to its potential impact on projects using `calcite-components` and Stencil. --------- Co-authored-by: Ben Elan <no-reply@benelan.dev> Co-authored-by: jcfranco <jcfranco@users.noreply.github.com>

jcfranco · 2023-11-16T22:50:45Z

You are using a fix version for stencil core. Why not using ^4.7.1?

IIRC, mainly to ensure a consistent test/debug environment and to reduce merge conflicts in package-lock.json.

You move the angular wrapper to 17. What's your thoughts about angular 16?

We thought we would use the latest since we were updating other dependencies, but we could downgrade to v16. @benelan WDYT?

BTW, we stopped using ts-node and we are using tsx. Faster IMO.

Noted. We will look into this and possibly make the switch too.

….d.ts is now tracked (#8199) **Related Issue:** #8108 ## Summary Follow up from #8108 (review). Co-authored-by: Ben Elan <no-reply@benelan.dev>