Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: swap ts-node for tsx #8196

Merged
merged 8 commits into from
Dec 8, 2023
Merged

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Nov 17, 2023

Related Issue: N/A

Summary

🧰 ➡️ 🧰

https://www.npmjs.com/package/ts-node
https://github.com/privatenumber/ts-runtime-comparison

No type-checking shouldn't be an issue per tsx's README:

Does it type check the code it runs?

No. tsx is designed to be a simple TypeScript runner.

If you need type-checking, you can use an IDE like VS Code and it will type-check as you code via IntelliSense. Alternatively, you can run the TypeScript Compiler only for type-checking (e.g. tsc --noEmit) as a linting step.

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Nov 17, 2023
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 17, 2023
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Nov 25, 2023
…ts-node-to-tsx

* origin/main:
  chore: release next
  ci(next): install deps before running npm scripts (#8370)
  feat: provide legacy CSS custom props for backwards compatibility (#8355)
  fix(input-date-picker): no longer emits redundant change event (#8341)
  fix(shell-panel): adds border at the start when slotted in `panel-end` (#8314)
  build(deps): update dependency sortablejs to v1.15.1 (#8364)
@benelan benelan marked this pull request as ready for review December 7, 2023 21:54
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcfranco told me to move forward with this PR via Teams. #8372 Needs to be installed first, since I had to skip those rules in this PR too due to lint-staged errors.

@benelan benelan added the skip visual snapshots Pull requests that do not need visual regression testing. label Dec 7, 2023
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🌮

@benelan benelan merged commit 30ed585 into main Dec 8, 2023
12 checks passed
@benelan benelan deleted the jcfranco/switch-from-ts-node-to-tsx branch December 8, 2023 20:28
@github-actions github-actions bot added this to the 2023 December Priorities milestone Dec 8, 2023
benelan added a commit that referenced this pull request Dec 8, 2023
benelan added a commit that referenced this pull request Dec 8, 2023
…ssage

* origin/main:
  build(node): bump node version to v20 (latest LTS) (#8381)
  build: swap ts-node for tsx (#8196)
  chore: release next
  build(deps): update dependency @types/prettier to v2.7.3 (#8375)
  build(deps): update dependency ng-packagr to v17.0.2 (#8362)
  test(tab-nav): stabilize test (#8356)
  fix(list-item): drag grid cell should be accessible via arrow keys. (#8353)
  chore: release next
  feat(list): Add `calciteListDragStart` and `calciteListDragEnd` events for when a drag starts and ends. (#8361)
  build(deps): update dependency tailwindcss to v3.3.6 (#8376)
  ci(eslint): disable eslint rules that are failing (#8372)
  chore: release next
  fix: replace "\n" to support Windows for tokens output (#8352)
  chore: release next
  ci(next): install deps before running npm scripts (#8370)
  feat: provide legacy CSS custom props for backwards compatibility (#8355)
  fix(input-date-picker): no longer emits redundant change event (#8341)
  fix(shell-panel): adds border at the start when slotted in `panel-end` (#8314)
  build(deps): update dependency sortablejs to v1.15.1 (#8364)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. pr ready for visual snapshots Adding this label will run visual snapshot testing. skip visual snapshots Pull requests that do not need visual regression testing. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants