ci(eslint): disable eslint rules that are failing #8372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benelan
requested review from
jcfranco,
driskull and
geospatialem
as code owners
github-actions
bot
added
the
chore
This was referenced Dec 7, 2023
jcfranco
added
the
skip visual snapshots
benelan
added a commit
that referenced
this pull request
Dec 8, 2023
…ssage * origin/main: build(node): bump node version to v20 (latest LTS) (#8381) build: swap ts-node for tsx (#8196) chore: release next build(deps): update dependency @types/prettier to v2.7.3 (#8375) build(deps): update dependency ng-packagr to v17.0.2 (#8362) test(tab-nav): stabilize test (#8356) fix(list-item): drag grid cell should be accessible via arrow keys. (#8353) chore: release next feat(list): Add `calciteListDragStart` and `calciteListDragEnd` events for when a drag starts and ends. (#8361) build(deps): update dependency tailwindcss to v3.3.6 (#8376) ci(eslint): disable eslint rules that are failing (#8372) chore: release next fix: replace "\n" to support Windows for tokens output (#8352) chore: release next ci(next): install deps before running npm scripts (#8370) feat: provide legacy CSS custom props for backwards compatibility (#8355) fix(input-date-picker): no longer emits redundant change event (#8341) fix(shell-panel): adds border at the start when slotted in `panel-end` (#8314) build(deps): update dependency sortablejs to v1.15.1 (#8364)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #8371
Summary
Disables a few ESLint rules that we have errors for in Calcite Components. Franco asked me to disable them for now and create an issue for him to see if any can be resolved and re-enabled.
@typescript-eslint/no-duplicate-enum-values- once here@stencil-community/reserved-member-names- lots of places related to thehiddenprop@stencil-community/ban-exported-const-enumsa few places inresource.tsfiles e.g. here and hereYou can reproduce the errors with: