Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update dependency @floating-ui/dom to v1.6.3 #8759

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

jcfranco
Copy link
Member

Related Issue: N/A

Summary

🤜💥🤛

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Feb 15, 2024
@jcfranco jcfranco added low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 15, 2024
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice

@jcfranco
Copy link
Member Author

jcfranco commented Feb 15, 2024

Failing test is unrelated:

@esri/calcite-components:test: Summary of all failing tests
@esri/calcite-components:test: FAIL src/components/input/input.e2e.ts (516.731 s)
@esri/calcite-components:test:   ● calcite-input › input type number increment/decrement functionality › should stop increasing the value when pointer is moved away from the increment button
@esri/calcite-components:test: 
@esri/calcite-components:test:     expect(received).toEqual(expected) // deep equality
@esri/calcite-components:test: 
@esri/calcite-components:test:     Expected: "20"
@esri/calcite-components:test:     Received: "21"
@esri/calcite-components:test: 
@esri/calcite-components:test:       701 |       await page.mouse.move(incrementButtonRect.x, 2 * incrementButtonRect.bottom);
@esri/calcite-components:test:       702 |       await page.waitForChanges();
@esri/calcite-components:test:     > 703 |       expect(await input.getProperty("value")).toEqual(value);
@esri/calcite-components:test:           |                                                ^
@esri/calcite-components:test:       704 |
@esri/calcite-components:test:       705 |       await page.mouse.up();
@esri/calcite-components:test:       706 |       await page.waitForChanges();
@esri/calcite-components:test: 
@esri/calcite-components:test:       at Object.<anonymous> (src/components/input/input.e2e.ts:703:48)

Merging!

@jcfranco jcfranco merged commit 04c8e24 into main Feb 15, 2024
14 of 16 checks passed
@jcfranco jcfranco deleted the jcfranco/bump-floating-ui branch February 15, 2024 20:11
benelan added a commit that referenced this pull request Feb 15, 2024
* origin/main: (22 commits)
  fix: ensure ui-icons are copied from correct path (#8761)
  build(changelog): fix synced version group name (#8762)
  chore: release main (#8706)
  fix(stepper): no longer adds default `min-width` for items when `layout='horizontal'` (#8758)
  build(deps): update dependency @floating-ui/dom to v1.6.3 (#8759)
  chore: release next
  feat(table): Improve accessibility of interaction-mode: static Table (#8754)
  chore: release next
  fix: fix dragging items on a mobile device (#8751)
  build(deps): update dependency @esri/calcite-ui-icons to v3.26.4 (#8752)
  chore: release next
  fix: prevent interaction when component is disabled after initialization (Firefox) (#8746)
  fix: fix styling when dragging items on a mobile device (#8750)
  chore: release next
  feat(stepper): add horizontal-single layout (#8742)
  revert: fix(panel, flow-item): remove overflow rule (#8711)
  refactor(input): tidy up input spec test (#8733)
  chore: improve doc for createBreakpointStories helper (#8739)
  chore: release next
  feat(table): Add `interactionMode` property to control focus behavior (#8686)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants