fix: ensure ui-icons are copied from correct path #8761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benelan
requested review from
jcfranco,
driskull and
geospatialem
as code owners
github-actions
bot
added
the
chore
benelan
added
skip visual snapshots
benelan
added
pr ready for visual snapshots
benelan
changed the title
github-actions
bot
added
the
bug
benelan
added
pr ready for visual snapshots
Merged
benelan
added a commit
that referenced
this pull request
Feb 15, 2024
* origin/main: (22 commits) fix: ensure ui-icons are copied from correct path (#8761) build(changelog): fix synced version group name (#8762) chore: release main (#8706) fix(stepper): no longer adds default `min-width` for items when `layout='horizontal'` (#8758) build(deps): update dependency @floating-ui/dom to v1.6.3 (#8759) chore: release next feat(table): Improve accessibility of interaction-mode: static Table (#8754) chore: release next fix: fix dragging items on a mobile device (#8751) build(deps): update dependency @esri/calcite-ui-icons to v3.26.4 (#8752) chore: release next fix: prevent interaction when component is disabled after initialization (Firefox) (#8746) fix: fix styling when dragging items on a mobile device (#8750) chore: release next feat(stepper): add horizontal-single layout (#8742) revert: fix(panel, flow-item): remove overflow rule (#8711) refactor(input): tidy up input spec test (#8733) chore: improve doc for createBreakpointStories helper (#8739) chore: release next feat(table): Add `interactionMode` property to control focus behavior (#8686) ...
jcfranco
pushed a commit
that referenced
this pull request
Feb 16, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.5.1</summary> ## [2.5.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.5.0...@esri/calcite-components@2.5.1) (2024-02-16) ### Bug Fixes * Ensure ui-icons are copied from correct path ([#8761](#8761)) ([3015a46](3015a46)) * Prevent package patching on install ([#8766](#8766)) ([fe18b1b](fe18b1b)) </details> <details><summary>@esri/calcite-components-angular: 2.5.1</summary> ## [2.5.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.5.0...@esri/calcite-components-angular@2.5.1) (2024-02-16) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.5.1-next.1 to ^2.5.1 </details> <details><summary>@esri/calcite-components-react: 2.5.1</summary> ## [2.5.1](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.5.0...@esri/calcite-components-react@2.5.1) (2024-02-16) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.5.1-next.1 to ^2.5.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #
Summary
Re-generate package-lock.json to try to fix the release CI, which had the following error:
https://github.com/Esri/calcite-design-system/actions/runs/7922511667/job/21630265819#step:4:87
This was the suggested solution in a comment on a related issue:
nrwl/nx#15452 (comment)
If that doesn't work, we can try one of these potential solutions:
npm/cli#4828 (comment)
vercel/turborepo#3328 (comment)
Unfortunately Calcite Components v2.5.0 does not contain the ui-icons due to releasing locally after re-generating the package-lock. I'm not sure if the corrupted package-lock was installing
@esri/calcite-ui-iconsin the wrong node_modules. Or maybe updating to Node v20 resolved some weirdness with where packages are installed when using workspaces. Either way, the icons are now installed into the node_modules in the calcite-components workspace, rather than the root.