Skip to content

Commit

Permalink
fix: ensure ui-icons are copied from correct path (#8761)
Browse files Browse the repository at this point in the history
Re-generate package-lock.json to try to fix the release CI, which had
the following error:

https://github.com/Esri/calcite-design-system/actions/runs/7922511667/job/21630265819#step:4:87

This was the suggested solution in a comment on a related issue:
nrwl/nx#15452 (comment)

If that doesn't work, we can try one of these potential solutions:
npm/cli#4828 (comment)
vercel/turborepo#3328 (comment)

Unfortunately Calcite Components v2.5.0 does not contain the ui-icons
due to releasing locally after re-generating the package-lock. I'm not
sure if the corrupted package-lock was installing
`@esri/calcite-ui-icons` in the wrong node_modules. Or maybe updating to
Node v20 resolved some weirdness with where packages are installed when
using workspaces. Either way, the icons are now installed into the
node_modules in the calcite-components workspace, rather than the root.
  • Loading branch information
benelan authored Feb 15, 2024
1 parent 6dcf525 commit 3015a46
Show file tree
Hide file tree
Showing 3 changed files with 9,346 additions and 4,253 deletions.
Loading

0 comments on commit 3015a46

Please sign in to comment.