chore: use local placeholder image in html files #9392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
jcfranco
approved these changes
May 21, 2024
There was a problem hiding this comment.
LGTM!
We should look at having the linter catch this. eslint-html's no-restricted-attr-values looks promising.
|
Yeah that would be great. Should we open an issue for it? |
driskull
added
the
skip visual snapshots
|
@driskull An issue would be great, thanks! |
macandcheese
added a commit
that referenced
this pull request
May 22, 2024
**Related Issue:** #9361 , #9392 ## Summary Removes served images from stories and local demo. We keep them in `.md` file, as these need to be hosted somewhere in order to work if the samples are used in an external location. cc @driskull Ideally, we could use map tiles or something (https://codepen.io/mac_and_cheese/pen/XWwXXqx?editors=1000) for these, but not sure how reliable those are.
|
created issue #9396 |
benelan
added a commit
that referenced
this pull request
May 24, 2024
…x-constraint * origin/main: (37 commits) build(deps): update dependency @stencil/core to v4.18.2 (#9266) refactor(stepper-item): drop unnecessary transitions (#9327) docs(contributing): add commit message formatting details (#9389) docs: update component READMEs (#9328) build: update browserslist db (#9263) chore: release next fix(tree): allow single select only and add indicator (#9405) chore: release next feat(split-button): Make dividers consistent (#9402) chore: release next feat(stepper, stepper-item): add separate change events to stepper and items (deprecates `calciteStepperItemChange` on the parent) (#9351) chore(tree): fix multiple selection-mode values set in slotted dropdown-groups (#9378) fix(dropdown-group): title scale with dropdown scale (#9360) chore: release next fix(tree): allow deselection in single selectionMode (#9363) chore: Update placeholder images in stories and demos (#9395) chore: use local placeholder image in html files (#9392) chore: release next chore: release hotfix (#9382) fix(combobox): fix error that occurs when a click is emitted when the component is appended to the DOM (#9380) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: None
Summary
https://webapps-cdn.esri.com/CDN/fonts/v1.4.1/fonts.cssnextversion so it is always up to date.http://www.esri.comhttp://www.esri.com