-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dropdown-group): title scale with dropdown scale #9360
Merged
anveshmekala
merged 2 commits into
main
from
anveshmekala/9350-dropdown-group-fix-title-font-size
May 23, 2024
Merged
fix(dropdown-group): title scale with dropdown scale #9360
anveshmekala
merged 2 commits into
main
from
anveshmekala/9350-dropdown-group-fix-title-font-size
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
Bug reports for broken functionality. Issues should include a reproduction of the bug.
label
May 17, 2024
anveshmekala
added
the
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
label
May 17, 2024
jcfranco
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🦖🌮
packages/calcite-components/src/components/dropdown/dropdown.stories.ts
Outdated
Show resolved
Hide resolved
@anveshmekala Before merging, can you update the PR title (conventional commit's description/message part) to use the imperative, present tense per the conventions we link to in our contributing doc? |
anveshmekala
changed the title
fix(dropdown-group): title scales with dropdown scale
fix(dropdown-group): title scale with dropdown scale
May 22, 2024
anveshmekala
added
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
May 22, 2024
Looks great! |
anveshmekala
deleted the
anveshmekala/9350-dropdown-group-fix-title-font-size
branch
May 23, 2024 15:58
Merged
benelan
added a commit
that referenced
this pull request
May 24, 2024
…x-constraint * origin/main: (37 commits) build(deps): update dependency @stencil/core to v4.18.2 (#9266) refactor(stepper-item): drop unnecessary transitions (#9327) docs(contributing): add commit message formatting details (#9389) docs: update component READMEs (#9328) build: update browserslist db (#9263) chore: release next fix(tree): allow single select only and add indicator (#9405) chore: release next feat(split-button): Make dividers consistent (#9402) chore: release next feat(stepper, stepper-item): add separate change events to stepper and items (deprecates `calciteStepperItemChange` on the parent) (#9351) chore(tree): fix multiple selection-mode values set in slotted dropdown-groups (#9378) fix(dropdown-group): title scale with dropdown scale (#9360) chore: release next fix(tree): allow deselection in single selectionMode (#9363) chore: Update placeholder images in stories and demos (#9395) chore: use local placeholder image in html files (#9392) chore: release next chore: release hotfix (#9382) fix(combobox): fix error that occurs when a click is emitted when the component is appended to the DOM (#9380) ...
benelan
added a commit
that referenced
this pull request
May 29, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.9.0</summary> ## [2.9.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.8.3...@esri/calcite-components@2.9.0) (2024-05-28) ### Features * **split-button:** Make dividers consistent ([#9402](#9402)) ([caf27e3](caf27e3)) * **stepper, stepper-item:** Add separate change events to stepper and items (deprecates `calciteStepperItemChange` on the parent) ([#9351](#9351)) ([cf6a118](cf6a118)) ### Bug Fixes * **dropdown-group:** Title scale with dropdown scale ([#9360](#9360)) ([3529cdd](3529cdd)) * **input-date-picker, date-picker:** Ensure min/max can be unset ([#9406](#9406)) ([89b0bfe](89b0bfe)) * **tree:** Allow deselection in single selectionMode ([#9363](#9363)) ([cb6ef73](cb6ef73)) * **tree:** Allow single select only and add indicator ([#9405](#9405)) ([0d07b59](0d07b59)) </details> <details><summary>@esri/calcite-components-angular: 2.9.0</summary> ## [2.9.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.8.3...@esri/calcite-components-angular@2.9.0) (2024-05-28) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.9.0-next.23 to ^2.9.0 </details> <details><summary>@esri/calcite-components-react: 2.9.0</summary> ## [2.9.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.8.3...@esri/calcite-components-react@2.9.0) (2024-05-28) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.9.0-next.23 to ^2.9.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben Elan <no-reply@benelan.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Bug reports for broken functionality. Issues should include a reproduction of the bug.
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9350
Summary
calcite-dropdown-group
title font-size scales with dropdown scale.