fix(input-date-picker, date-picker): ensure min/max can be unset #9406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
github-actions
bot
added
the
bug
4 tasks
benelan
added
the
pr ready for visual snapshots
packages/calcite-components/src/components/date-picker/date-picker.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/date-picker/date-picker.e2e.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/date-picker/date-picker.e2e.ts
Outdated
Show resolved
Hide resolved
jcfranco
approved these changes
May 24, 2024
There was a problem hiding this comment.
Awesome! Aside from @anveshmekala's comments, this LGTM!
Before merging, can you update the conventional commit's description/message from the PR title to use the imperative, present tense per the conventions we link to in our contributing doc?
packages/calcite-components/src/components/date-picker/date-picker.e2e.ts
Outdated
Show resolved
Hide resolved
…x-constraint * origin/main: (37 commits) build(deps): update dependency @stencil/core to v4.18.2 (#9266) refactor(stepper-item): drop unnecessary transitions (#9327) docs(contributing): add commit message formatting details (#9389) docs: update component READMEs (#9328) build: update browserslist db (#9263) chore: release next fix(tree): allow single select only and add indicator (#9405) chore: release next feat(split-button): Make dividers consistent (#9402) chore: release next feat(stepper, stepper-item): add separate change events to stepper and items (deprecates `calciteStepperItemChange` on the parent) (#9351) chore(tree): fix multiple selection-mode values set in slotted dropdown-groups (#9378) fix(dropdown-group): title scale with dropdown scale (#9360) chore: release next fix(tree): allow deselection in single selectionMode (#9363) chore: Update placeholder images in stories and demos (#9395) chore: use local placeholder image in html files (#9392) chore: release next chore: release hotfix (#9382) fix(combobox): fix error that occurs when a click is emitted when the component is appended to the DOM (#9380) ...
benelan
changed the title
benelan
added
the
skip visual snapshots
Merged
benelan
added a commit
that referenced
this pull request
May 29, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.9.0</summary> ## [2.9.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.8.3...@esri/calcite-components@2.9.0) (2024-05-28) ### Features * **split-button:** Make dividers consistent ([#9402](#9402)) ([caf27e3](caf27e3)) * **stepper, stepper-item:** Add separate change events to stepper and items (deprecates `calciteStepperItemChange` on the parent) ([#9351](#9351)) ([cf6a118](cf6a118)) ### Bug Fixes * **dropdown-group:** Title scale with dropdown scale ([#9360](#9360)) ([3529cdd](3529cdd)) * **input-date-picker, date-picker:** Ensure min/max can be unset ([#9406](#9406)) ([89b0bfe](89b0bfe)) * **tree:** Allow deselection in single selectionMode ([#9363](#9363)) ([cb6ef73](cb6ef73)) * **tree:** Allow single select only and add indicator ([#9405](#9405)) ([0d07b59](0d07b59)) </details> <details><summary>@esri/calcite-components-angular: 2.9.0</summary> ## [2.9.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.8.3...@esri/calcite-components-angular@2.9.0) (2024-05-28) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.9.0-next.23 to ^2.9.0 </details> <details><summary>@esri/calcite-components-react: 2.9.0</summary> ## [2.9.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.8.3...@esri/calcite-components-react@2.9.0) (2024-05-28) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.9.0-next.23 to ^2.9.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben Elan <no-reply@benelan.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7889
Summary
Fix issue where
maxAsDateandminAsDatewere not being updated ifminormaxwere falsy.